moonlight-stream/moonlight-qt
1
0
Fork 0
mirror of https://github.com/moonlight-stream/moonlight-qt.git synced 2026-02-16 02:30:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix UB due to missing shader attribute location binding

Browse Source 
Mesa drivers seem to generally bind attributes in order, but the
proprietary PowerVR driver (pvr) doesn't and renders incorrectly
as a result.
This commit is contained in:
Cameron Gutman
2025-12-27 23:56:17 -06:00
parent 8a5f34fb01
commit f1451a0db3
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/streaming/video/ffmpeg-renderers/eglvid.cpp
View File

@@ -257,6 +257,7 @@ void EGLRenderer::renderOverlay(Overlay::OverlayType type, int viewportWidth, in
glUseProgram(m_OverlayShaderProgram);
// compileShader() ensures that aPosition and aTexCoord are indexes 0 and 1 respectively
glBindBuffer(GL_ARRAY_BUFFER, m_OverlayVbos[type]);
glVertexAttribPointer(0, 2, GL_FLOAT, GL_FALSE, sizeof(OVERLAY_VERTEX), (void*)offsetof(OVERLAY_VERTEX, x));
glEnableVertexAttribArray(0);
@@ -314,7 +315,13 @@ unsigned EGLRenderer::compileShader(const char* vertexShaderSrc, const char* fra
glAttachShader(shader, vertexShader);
glAttachShader(shader, fragmentShader);
// Bind specific attribute locations for our standard vertex shader arguments
glBindAttribLocation(shader, 0, "aPosition");
glBindAttribLocation(shader, 1, "aTexCoord");
glLinkProgram(shader);
int status;
glGetProgramiv(shader, GL_LINK_STATUS, &status);
if (!status) {
@@ -671,6 +678,7 @@ bool EGLRenderer::specialize() {
glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, EBO);
glBufferData(GL_ELEMENT_ARRAY_BUFFER, sizeof (indices), indices, GL_STATIC_DRAW);
// compileShader() ensures that aPosition and aTexCoord are indexes 0 and 1 respectively
glVertexAttribPointer(0, 2, GL_FLOAT, GL_FALSE, 4 * sizeof(float), (void*)0);
glEnableVertexAttribArray(0);
glVertexAttribPointer(1, 2, GL_FLOAT, GL_FALSE, 4 * sizeof(float), (void*)(2 * sizeof (float)));