Add debug log for specific data condition in ServerSend

CMakeLists.txt

@@ -37,4 +37,4 @@ else(WIN32) #MINGW
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Os -s --static")
     target_link_libraries(${PROJECT_NAME} ssl crypto ws2_32 ssp crypt32 z CURL::libcurl)
 endif(WIN32)
-target_include_directories(${PROJECT_NAME} PRIVATE "include" "include/Network")
+target_include_directories(${PROJECT_NAME} PRIVATE "include")

include/Http.h

@@ -11,9 +11,9 @@
 #include <string>
 class HTTP {
 public:
-    static bool Download(const std::string& IP, const beammp_fs_string& Path, const std::string& Hash, const bool& redirect = true);
-    static std::string Post(std::string IP, const std::string& Fields, const bool& redirect = true);
-    static std::string Get(std::string IP, const bool& redirect = true);
+    static bool Download(const std::string& IP, const beammp_fs_string& Path, const std::string& Hash);
+    static std::string Post(const std::string& IP, const std::string& Fields);
+    static std::string Get(const std::string& IP);
     static bool ProgressBar(size_t c, size_t t);
     static void StartProxy();
 public:

include/Network/RegionHandler.h

@@ -1,22 +0,0 @@
-/*
- Copyright (C) 2024 BeamMP Ltd., BeamMP team and contributors.
- Licensed under AGPL-3.0 (or later), see <https://www.gnu.org/licenses/>.
- SPDX-License-Identifier: AGPL-3.0-or-later
-*/
-
-#pragma once
-
-#include <vector>
-#include <string>
-#include <array>
-
-class RegionHandler final {
-public:
-    RegionHandler() = delete;
-    static void TopLevelDomainFailed();
-    static std::string RegionToTopLevelDomain();
-    static std::string RedirectURL(const std::string& URL);
-private:
-    static inline unsigned int mRegionIndex { 0 };
-    const static inline std::array<std::string, 2> mValidTLDs {"beammp.com", "beammp.net"};
-};

include/Options.h

@@ -20,7 +20,6 @@ struct Options {
     bool no_update = false;
     bool no_launch = false;
     const char* user_path = nullptr;
-    std::string region;
     const char **game_arguments = nullptr;
     int game_arguments_length = 0;
     const char** argv = nullptr;

src/Config.cpp

@@ -49,9 +49,6 @@ void ParseConfig(const nlohmann::json& d) {
         deleteDuplicateMods = d["DeleteDuplicateMods"].get<bool>();
     }
 
-    if (d.contains("Region") && d["Region"].is_string()) {
-        options.region = d["Region"].get<std::string>();
-    }
 }
 
 void ConfigInit() {

src/Network/Core.cpp

@@ -5,7 +5,6 @@
 */
 
 #include "Http.h"
-#include "RegionHandler.h"
 #include "Network/network.hpp"
 #include "Security/Init.h"
 #include "Utils.h"
@@ -227,8 +226,7 @@ void Parse(std::string Data, SOCKET CSocket) {
             TCPTerminate = true;
             Data.clear();
             futures.push_back(std::async(std::launch::async, []() {
-                std::string resp = HTTP::Get("https://backend.beammp.com/servers-info", true);
-                CoreSend("B" + resp);
+                CoreSend("B" + HTTP::Get("https://backend.beammp.com/servers-info"));
             }));
         }
         break;

src/Network/GlobalHandler.cpp

@@ -61,6 +61,10 @@ void GameSend(std::string_view Data) {
 }
 
 void ServerSend(std::string Data, bool Rel) {
+   if (Data.length() > 1 && Data[0] == 't') {
+    debug("hey");
+   }
+ 
     if (Terminate || Data.empty())
         return;
     if (Data.find("Zp") != std::string::npos && Data.size() > 500) {
@@ -73,7 +77,7 @@ void ServerSend(std::string Data, bool Rel) {
         C = Data.at(0);
     if (C == 'O' || C == 'T')
         Ack = true;
-    if (C == 'N' || C == 'W' || C == 'Y' || C == 'V' || C == 'E' || C == 'C')
+    if (C == 'N' || C == 'W' || C == 'Y' || C == 'V' || C == 'E' || C == 'C' || C == 't')
         Rel = true;
     if (compressBound(Data.size()) > 1024)
         Rel = true;
@@ -198,6 +202,10 @@ void ParserAsync(std::string_view Data) {
     default:
         break;
     }
+    if (Data.length() > 1 && Data[0] == 't') {
+        debug("omg?");
+        debug(Data.data());
+    }
     GameSend(Data);
 }
 void ServerParser(std::string_view Data) {

src/Network/Http.cpp

@@ -6,8 +6,6 @@
 
 
 #include "Http.h"
-#include "RegionHandler.h"
-#include "Options.h"
 #include <Logger.h>
 #include <Network/network.hpp>
 #include <Startup.h>
@@ -31,12 +29,9 @@ static size_t CurlWriteCallback(void* contents, size_t size, size_t nmemb, void*
 }
 
 bool HTTP::isDownload = false;
-std::string HTTP::Get(std::string IP, const bool& redirect) {
+std::string HTTP::Get(const std::string& IP) {
     std::string Ret;
     static thread_local CURL* curl = curl_easy_init();
-    if (redirect) {
-        IP = RegionHandler::RedirectURL(IP);
-    }
     if (curl) {
         CURLcode res;
         char errbuf[CURL_ERROR_SIZE];
@@ -51,18 +46,7 @@ std::string HTTP::Get(std::string IP, const bool& redirect) {
         if (res != CURLE_OK) {
             error("GET to " + IP + " failed: " + std::string(curl_easy_strerror(res)));
             error("Curl error: " + std::string(errbuf));
-            if (!redirect) {
-                return "";
-            }
-            RegionHandler::TopLevelDomainFailed();
-            IP = RegionHandler::RedirectURL(IP);
-            curl_easy_setopt(curl, CURLOPT_URL, IP.c_str());
-            res = curl_easy_perform(curl);
-            if (res != CURLE_OK) {
-                error("GET to " + IP + " failed: " + std::string(curl_easy_strerror(res)));
-                error("Curl error: " + std::string(errbuf));
-                return "";
-            }
+            return "";
         }
     } else {
         error("Curl easy init failed");
@@ -71,12 +55,9 @@ std::string HTTP::Get(std::string IP, const bool& redirect) {
     return Ret;
 }
 
-std::string HTTP::Post(std::string IP, const std::string& Fields, const bool& redirect) {
+std::string HTTP::Post(const std::string& IP, const std::string& Fields) {
     std::string Ret;
     static thread_local CURL* curl = curl_easy_init();
-    if (redirect) {
-        IP = RegionHandler::RedirectURL(IP);
-    }
     if (curl) {
         CURLcode res;
         char errbuf[CURL_ERROR_SIZE];
@@ -98,18 +79,7 @@ std::string HTTP::Post(std::string IP, const std::string& Fields, const bool& re
         if (res != CURLE_OK) {
             error("POST to " + IP + " failed: " + std::string(curl_easy_strerror(res)));
             error("Curl error: " + std::string(errbuf));
-            if (!redirect) {
-                return "";
-            }
-            RegionHandler::TopLevelDomainFailed();
-            IP = RegionHandler::RedirectURL(IP);
-            curl_easy_setopt(curl, CURLOPT_URL, IP.c_str());
-            res = curl_easy_perform(curl);
-            if (res != CURLE_OK) {
-                error("GET to " + IP + " failed: " + std::string(curl_easy_strerror(res)));
-                error("Curl error: " + std::string(errbuf));
-                return "";
-            }
+            return "";
         }
     } else {
         error("Curl easy init failed");
@@ -118,12 +88,12 @@ std::string HTTP::Post(std::string IP, const std::string& Fields, const bool& re
     return Ret;
 }
 
-bool HTTP::Download(const std::string& IP, const beammp_fs_string& Path, const std::string& Hash, const bool& redirect) {
+bool HTTP::Download(const std::string& IP, const beammp_fs_string& Path, const std::string& Hash) {
     static std::mutex Lock;
     std::scoped_lock Guard(Lock);
 
     info("Downloading an update (this may take a while)");
-    std::string Ret = Get(IP, redirect);
+    std::string Ret = Get(IP);
 
     if (Ret.empty()) {
         error("Download failed");

src/Network/RegionHandler.cpp

@@ -1,39 +0,0 @@
-/*
- Copyright (C) 2024 BeamMP Ltd., BeamMP team and contributors.
- Licensed under AGPL-3.0 (or later), see <https://www.gnu.org/licenses/>.
- SPDX-License-Identifier: AGPL-3.0-or-later
-*/
-
-#include "RegionHandler.h"
-#include "Logger.h"
-#include "Options.h"
-
-#include <regex>
-
-void RegionHandler::TopLevelDomainFailed()
-{
-    info("Top level domain of " + mValidTLDs[mRegionIndex % mValidTLDs.size()] + " didn't respond correctly , changing domain to " + mValidTLDs[(mRegionIndex + 1) % mValidTLDs.size()]);
-    mRegionIndex++;
-}
-
-std::string RegionHandler::RegionToTopLevelDomain()
-{
-    static bool isDeveloperRegion = options.region == "Developer";
-    if (isDeveloperRegion) {
-        return "beammp.dev";
-    }
-    return mValidTLDs[mRegionIndex % mValidTLDs.size()]; // Global
-}
-
-std::string RegionHandler::RedirectURL(const std::string &URL)
-{
-    std::regex link_pattern(R"(^(https:\/\/.*)beammp\.com(\/.*)?$)");
-    std::smatch link_match;
-    if (std::regex_search(URL, link_match, link_pattern) && link_match.position() == 0) {
-        //TLD matched beammp.com
-        std::string before = link_match[1].str();                     // "https://..." up to beammp
-        std::string after  = link_match[2].matched ? link_match[2].str() : ""; // "/path" or ""
-        return before + RegionToTopLevelDomain() + after;
-    }
-    return URL; //if it didn't match, just return the unmodified URL
-}

src/Options.cpp

@@ -92,13 +92,6 @@ void InitOptions(int argc, const char *argv[], Options &options) {
             }
             options.user_path = argv[i + 1];
             i++;
-        } else if (argument == "--region") {
-            if (i + 1 >= argc) {
-                error("You must specify a region after the `--region` argument");
-            }
-            options.region = argv[i + 1];
-            info("Set the region to: " + options.region);
-            i++;
         } else if (argument == "--" || argument == "--game") {
             options.game_arguments = &argv[i + 1];
             options.game_arguments_length = argc - i - 1;

src/Security/Login.cpp

@@ -6,8 +6,6 @@
 
 
 #include "Http.h"
-#include "Options.h"
-#include "RegionHandler.h"
 #include "Logger.h"
 #include <filesystem>
 #include <fstream>

src/Startup.cpp

@@ -24,7 +24,6 @@
 #include "Security/Init.h"
 #include "Startup.h"
 #include "Utils.h"
-#include "RegionHandler.h"
 #include "hashpp.h"
 #include <filesystem>
 #include <fstream>
@@ -333,7 +332,8 @@ bool VerifySignature(const std::filesystem::path& filePath)
 
 void CheckForUpdates(const std::string& CV) {
     std::string LatestHash = HTTP::Get("https://backend.beammp.com/sha/launcher?branch=" + Branch + "&pk=" + PublicKey);
-    std::string LatestVersion = HTTP::Get("https://backend.beammp.com/version/launcher?branch=" + Branch + "&pk=" + PublicKey);
+    std::string LatestVersion = HTTP::Get(
+        "https://backend.beammp.com/version/launcher?branch=" + Branch + "&pk=" + PublicKey);
 
     std::regex sha256_pattern(R"(^[a-fA-F0-9]{64}$)");
     std::smatch match;
@@ -357,13 +357,11 @@ void CheckForUpdates(const std::string& CV) {
 #else
             info("Downloading Launcher update " + LatestHash);
             std::wstring DownloadLocation = GetBP() / (beammp_wide("new_") + GetEN());
-            bool downloadSuccess = false;
-            downloadSuccess = HTTP::Download(
+            if (HTTP::Download(
                     "https://backend.beammp.com/builds/launcher?download=true"
                     "&pk="
                         + PublicKey + "&branch=" + Branch,
-                DownloadLocation, LatestHash);
-            if (downloadSuccess) {
+                    DownloadLocation, LatestHash)) {
                 if (!VerifySignature(DownloadLocation) || !CheckThumbprint(DownloadLocation)) {
                     std::error_code ec;
                     fs::remove(DownloadLocation, ec);