rustdesk/rustdesk-server
1
0
Fork 0
mirror of https://github.com/rustdesk/rustdesk-server.git synced 2026-10-19 23:24:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(hbbs): cover MAX_PUNCH_REQUESTS=0 in the punch-request test

Browse Source 
At zero capacity the loop never ran and the new front/back asserts
unwrapped an empty queue. Make at least one request so the disabled
path is exercised, and only check eviction order when records are kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PkpVy2ufxgEjKd3SjXPnJ8
This commit is contained in:
rustdesk
2026-10-10 16:45:53 +08:00
co-authored by Claude Opus 5.5
parent d75a9aad92
commit 2715ad105d
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/rendezvous_server.rs
+10 -6
View File
@@ -1432,8 +1432,10 @@ mod tests {
#[hbb_common::tokio::test]
async fn punch_reqs_bounded() {
// 31 ids keep every request just outside the 30-entry dedupe window
for i in 0..*PUNCH_REQ_MAX * 2 {
let max = *PUNCH_REQ_MAX;
// 31 ids keep every request just outside the 30-entry dedupe window;
// one request at least, so MAX_PUNCH_REQUESTS=0 is exercised too
for i in 0..(max * 2).max(1) {
record_punch_req(
"1.2.3.4".to_owned(),
"5.6.7.8".to_owned(),
@@ -1441,10 +1443,12 @@ mod tests {
)
.await;
}
assert_eq!(PUNCH_REQS.lock().await.len(), *PUNCH_REQ_MAX);
// the oldest half is evicted and the newest kept
let lock = PUNCH_REQS.lock().await;
assert_eq!(lock.front().unwrap().to_id, format!("peer{}", *PUNCH_REQ_MAX % 31));
assert_eq!(lock.back().unwrap().to_id, format!("peer{}", (*PUNCH_REQ_MAX * 2 - 1) % 31));
assert_eq!(lock.len(), max);
if max > 0 {
// the oldest half is evicted and the newest kept
assert_eq!(lock.front().unwrap().to_id, format!("peer{}", max % 31));
assert_eq!(lock.back().unwrap().to_id, format!("peer{}", (max * 2 - 1) % 31));
}
}
}