rustdesk/hbb_common
1
0
Fork 0
mirror of https://github.com/rustdesk/hbb_common.git synced 2026-08-27 12:39:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

proto: drop the reserved tag in PunchHole

Browse Source 
`requester_id = 11` was added and removed in the same rebase batch, never
reached main, and never reached hbbs — whose vendored copy of this file still
stops at field 9. So nothing has ever written or read tag 11, and reserving it
guards a wire format that does not exist.

It was also inconsistent with what this branch already does: `IceCandidate`
retyped tag 2 from `string to_id` to `bytes socket_addr` in place, which is only
sound because none of this proto has shipped. Same premise, so tag 11 is free.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
rustdesk
2026-08-06 15:21:27 +08:00
parent 0a36139a58
commit 7c4456be9b
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
protos/rendezvous.proto
-5
View File
@@ -66,11 +66,6 @@ message PunchHole {
ControlPermissions control_permissions = 8; ControlPermissions control_permissions = 8;
ControlledContext controlled_context = 9; ControlledContext controlled_context = 9;
string webrtc_sdp_offer = 10; string webrtc_sdp_offer = 10;
// Was `string requester_id = 11`, dropped once ICE routing stopped needing it. Reserved so the
// tag is never reassigned: PunchHole is written by the rendezvous server, and an hbbs built
// against the earlier field still puts a string here.
reserved 11;
reserved "requester_id";
} }
message TestNatRequest { message TestNatRequest {