From 7c4456be9bdb5c53df01ebeac5a36d67a6392a38 Mon Sep 17 00:00:00 2001 From: rustdesk Date: Thu, 6 Aug 2026 15:21:27 +0800 Subject: [PATCH] proto: drop the reserved tag in PunchHole MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `requester_id = 11` was added and removed in the same rebase batch, never reached main, and never reached hbbs — whose vendored copy of this file still stops at field 9. So nothing has ever written or read tag 11, and reserving it guards a wire format that does not exist. It was also inconsistent with what this branch already does: `IceCandidate` retyped tag 2 from `string to_id` to `bytes socket_addr` in place, which is only sound because none of this proto has shipped. Same premise, so tag 11 is free. Co-Authored-By: Claude Opus 5 (1M context) --- protos/rendezvous.proto | 5 ----- 1 file changed, 5 deletions(-) diff --git a/protos/rendezvous.proto b/protos/rendezvous.proto index 6775b5374..a73e017cc 100644 --- a/protos/rendezvous.proto +++ b/protos/rendezvous.proto @@ -66,11 +66,6 @@ message PunchHole { ControlPermissions control_permissions = 8; ControlledContext controlled_context = 9; string webrtc_sdp_offer = 10; - // Was `string requester_id = 11`, dropped once ICE routing stopped needing it. Reserved so the - // tag is never reassigned: PunchHole is written by the rendezvous server, and an hbbs built - // against the earlier field still puts a string here. - reserved 11; - reserved "requester_id"; } message TestNatRequest {