fix Minecraft bee issue

This commit is contained in:
dfsek
2022-06-16 16:46:44 -07:00
parent ba179c0991
commit 34b1aca556
7 changed files with 41 additions and 151 deletions

View File

@@ -17,22 +17,6 @@
package com.dfsek.terra.fabric.generation;
import com.dfsek.terra.api.config.ConfigPack;
import com.dfsek.terra.api.world.biome.generation.BiomeProvider;
import com.dfsek.terra.api.world.chunk.generation.ChunkGenerator;
import com.dfsek.terra.api.world.chunk.generation.ProtoChunk;
import com.dfsek.terra.api.world.chunk.generation.ProtoWorld;
import com.dfsek.terra.api.world.chunk.generation.stage.Chunkified;
import com.dfsek.terra.api.world.chunk.generation.util.GeneratorWrapper;
import com.dfsek.terra.api.world.info.WorldProperties;
import com.dfsek.terra.fabric.config.PreLoadCompatibilityOptions;
import com.dfsek.terra.fabric.data.Codecs;
import com.dfsek.terra.fabric.mixin_ifaces.BiomeProviderHolder;
import com.dfsek.terra.fabric.mixin_ifaces.entity.DelegateEntityHolder;
import com.dfsek.terra.fabric.mixin.access.ChunkRegionAccessor;
import com.dfsek.terra.fabric.mixin.access.StructureAccessorAccessor;
import com.dfsek.terra.fabric.util.FabricAdapter;
import com.mojang.serialization.Codec;
import net.minecraft.block.BlockState;
import net.minecraft.block.Blocks;
@@ -69,6 +53,20 @@ import java.util.Optional;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.Executor;
import com.dfsek.terra.api.config.ConfigPack;
import com.dfsek.terra.api.world.biome.generation.BiomeProvider;
import com.dfsek.terra.api.world.chunk.generation.ChunkGenerator;
import com.dfsek.terra.api.world.chunk.generation.ProtoChunk;
import com.dfsek.terra.api.world.chunk.generation.ProtoWorld;
import com.dfsek.terra.api.world.chunk.generation.stage.Chunkified;
import com.dfsek.terra.api.world.chunk.generation.util.GeneratorWrapper;
import com.dfsek.terra.api.world.info.WorldProperties;
import com.dfsek.terra.fabric.config.PreLoadCompatibilityOptions;
import com.dfsek.terra.fabric.data.Codecs;
import com.dfsek.terra.fabric.mixin.access.StructureAccessorAccessor;
import com.dfsek.terra.fabric.mixin_ifaces.BiomeProviderHolder;
import com.dfsek.terra.fabric.util.FabricAdapter;
public class FabricChunkGeneratorWrapper extends net.minecraft.world.gen.chunk.ChunkGenerator implements GeneratorWrapper {
private static final Logger logger = LoggerFactory.getLogger(FabricChunkGeneratorWrapper.class);
@@ -120,13 +118,6 @@ public class FabricChunkGeneratorWrapper extends net.minecraft.world.gen.chunk.C
@Override
public void populateEntities(ChunkRegion region) {
((ChunkRegionAccessor) region)
.getChunks()
.forEach(
chunk -> ((DelegateEntityHolder) chunk)
.getAndClearTerraEntities()
.forEach(entity -> chunk.addEntity(entity.createMinecraftEntity(region)))
);
if(!this.settings.value().mobGenerationDisabled()) {
ChunkPos chunkPos = region.getCenterPos();
RegistryEntry<Biome> registryEntry = region.getBiome(chunkPos.getStartPos().withY(region.getTopY() - 1));

View File

@@ -1,11 +1,7 @@
package com.dfsek.terra.fabric.mixin.fix;
import com.dfsek.terra.fabric.FabricEntryPoint;
import com.dfsek.terra.fabric.util.FabricUtil;
import net.minecraft.entity.passive.BeeEntity.MoveToFlowerGoal;
import net.minecraft.entity.passive.BeeEntity.MoveToHiveGoal;
import net.minecraft.server.world.ServerWorld;
import net.minecraft.util.math.random.CheckedRandom;
import net.minecraft.util.math.random.Random;
import net.minecraft.world.World;
@@ -13,6 +9,8 @@ import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Redirect;
import com.dfsek.terra.fabric.FabricEntryPoint;
/**
* Bees spawning uses world.random without synchronization. This causes issues when spawning bees during world generation.

View File

@@ -1,39 +0,0 @@
package com.dfsek.terra.fabric.mixin.implementations.entity_holder;
import com.dfsek.terra.fabric.mixin_ifaces.entity.DelegateEntity;
import com.dfsek.terra.fabric.mixin_ifaces.entity.DelegateEntityHolder;
import net.minecraft.world.chunk.ProtoChunk;
import org.spongepowered.asm.mixin.Implements;
import org.spongepowered.asm.mixin.Interface;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.atomic.AtomicReference;
@Mixin(ProtoChunk.class)
@Implements(@Interface(iface = DelegateEntityHolder.class, prefix = "terra$"))
public class ProtoChunkMixin {
private AtomicReference<List<DelegateEntity>> terra$entities;
@Inject(method = "<init>*", at = @At("RETURN"))
public void injectConstructor(CallbackInfo ci) {
this.terra$entities = new AtomicReference<>(new ArrayList<>());
}
public List<DelegateEntity> terra$getAndClearTerraEntities() {
return terra$entities.getAndSet(new ArrayList<>());
}
public void terra$addTerraEntity(DelegateEntity entity) {
this.terra$entities.updateAndGet(list -> {
list.add(entity);
return list;
});
}
}

View File

@@ -17,24 +17,6 @@
package com.dfsek.terra.fabric.mixin.implementations.terra.world;
import com.dfsek.terra.api.block.entity.BlockEntity;
import com.dfsek.terra.api.block.state.BlockState;
import com.dfsek.terra.api.config.ConfigPack;
import com.dfsek.terra.api.entity.Entity;
import com.dfsek.terra.api.entity.EntityType;
import com.dfsek.terra.api.util.generic.Lazy;
import com.dfsek.terra.api.util.vector.Vector3;
import com.dfsek.terra.api.world.ServerWorld;
import com.dfsek.terra.api.world.biome.generation.BiomeProvider;
import com.dfsek.terra.api.world.chunk.generation.ChunkGenerator;
import com.dfsek.terra.api.world.chunk.generation.ProtoWorld;
import com.dfsek.terra.fabric.mixin_ifaces.entity.DelegateEntity;
import com.dfsek.terra.fabric.mixin_ifaces.entity.DelegateEntityHolder;
import com.dfsek.terra.fabric.mixin_ifaces.BiomeProviderHolder;
import com.dfsek.terra.fabric.generation.FabricChunkGeneratorWrapper;
import com.dfsek.terra.fabric.generation.TerraBiomeSource;
import com.dfsek.terra.fabric.util.FabricUtil;
import net.minecraft.block.FluidBlock;
import net.minecraft.fluid.Fluid;
import net.minecraft.util.math.BlockPos;
@@ -44,13 +26,33 @@ import net.minecraft.world.chunk.Chunk;
import net.minecraft.world.chunk.ChunkStatus;
import net.minecraft.world.tick.MultiTickScheduler;
import net.minecraft.world.tick.OrderedTick;
import org.spongepowered.asm.mixin.*;
import org.spongepowered.asm.mixin.Final;
import org.spongepowered.asm.mixin.Implements;
import org.spongepowered.asm.mixin.Interface;
import org.spongepowered.asm.mixin.Intrinsic;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Shadow;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
import java.util.List;
import com.dfsek.terra.api.block.entity.BlockEntity;
import com.dfsek.terra.api.block.state.BlockState;
import com.dfsek.terra.api.config.ConfigPack;
import com.dfsek.terra.api.entity.Entity;
import com.dfsek.terra.api.entity.EntityType;
import com.dfsek.terra.api.util.generic.Lazy;
import com.dfsek.terra.api.world.ServerWorld;
import com.dfsek.terra.api.world.biome.generation.BiomeProvider;
import com.dfsek.terra.api.world.chunk.generation.ChunkGenerator;
import com.dfsek.terra.api.world.chunk.generation.ProtoWorld;
import com.dfsek.terra.fabric.generation.FabricChunkGeneratorWrapper;
import com.dfsek.terra.fabric.generation.TerraBiomeSource;
import com.dfsek.terra.fabric.mixin_ifaces.BiomeProviderHolder;
import com.dfsek.terra.fabric.util.FabricUtil;
@Mixin(ChunkRegion.class)
@Implements(@Interface(iface = ProtoWorld.class, prefix = "terraWorld$"))
@@ -143,9 +145,10 @@ public abstract class ChunkRegionMixin {
}
public Entity terraWorld$spawnEntity(double x, double y, double z, EntityType entityType) {
DelegateEntity entity = new DelegateEntity(Vector3.of(x, y, z), (ServerWorld) this.toServerWorld(), entityType);
((DelegateEntityHolder) getChunk((int) x / 16, (int) z / 16)).addTerraEntity(entity);
return entity;
net.minecraft.entity.Entity entity = ((net.minecraft.entity.EntityType<?>) entityType).create(world);
entity.setPos(x, y, z);
((ChunkRegion) (Object) this).spawnEntity(entity);
return (Entity) entity;
}
public int terraWorld$centerChunkX() {

View File

@@ -1,52 +0,0 @@
package com.dfsek.terra.fabric.mixin_ifaces.entity;
import com.dfsek.terra.api.entity.Entity;
import com.dfsek.terra.api.entity.EntityType;
import com.dfsek.terra.api.util.vector.Vector3;
import com.dfsek.terra.api.world.ServerWorld;
import net.minecraft.world.ServerWorldAccess;
public class DelegateEntity implements Entity {
private Vector3 position;
private ServerWorld world;
private final EntityType type;
public DelegateEntity(Vector3 position, ServerWorld world, EntityType type) {
this.world = world;
this.position = position;
this.type = type;
}
@Override
public Vector3 position() {
return position;
}
@Override
public void position(Vector3 position) {
this.position = position;
}
@Override
public ServerWorld world() {
return world;
}
@Override
public void world(ServerWorld world) {
this.world = world;
}
@Override
public Object getHandle() {
return this;
}
public net.minecraft.entity.Entity createMinecraftEntity(ServerWorldAccess world) {
net.minecraft.entity.Entity entity = ((net.minecraft.entity.EntityType<?>) type).create(world.toServerWorld());
entity.setPos(position.getX(), position.getY(), position.getZ());
return entity;
}
}

View File

@@ -1,10 +0,0 @@
package com.dfsek.terra.fabric.mixin_ifaces.entity;
import java.util.List;
public interface DelegateEntityHolder {
List<DelegateEntity> getAndClearTerraEntities();
void addTerraEntity(DelegateEntity entity);
}

View File

@@ -13,7 +13,6 @@
"implementations.cache.ChunkRegionMixin",
"implementations.cache.ProtoChunkMixin",
"implementations.compat.GenerationSettingsFloraFeaturesMixin",
"implementations.entity_holder.ProtoChunkMixin",
"implementations.terra.BiomeMixin",
"implementations.terra.HandleImplementationMixin",
"implementations.terra.block.BlockMixin",