V+

should fix compiling

build.gradle

@@ -24,7 +24,7 @@ plugins {
     id "de.undercouch.download" version "5.0.1"
 }
 
-version '2.5.1-1.19.4'
+version '2.6.0-1.19.4'
 def nmsVersion = "1.19.4" //[NMS]
 def apiVersion = '1.19'
 def specialSourceVersion = '1.11.0' //[NMS]

src/main/java/com/volmit/iris/Iris.java

@@ -88,7 +88,7 @@ import java.util.Map;
 
 @SuppressWarnings("CanBeFinal")
 public class Iris extends VolmitPlugin implements Listener {
-    public static final String OVERWORLD_TAG = "2100";
+    public static final String OVERWORLD_TAG = "3001";
 
     private static final Queue<Runnable> syncJobs = new ShurikenQueue<>();
 

src/main/java/com/volmit/iris/core/link/ExternalDataProvider.java

@@ -3,7 +3,6 @@ package com.volmit.iris.core.link;
 import lombok.Getter;
 import lombok.RequiredArgsConstructor;
 import org.bukkit.Bukkit;
-import org.bukkit.NamespacedKey;
 import org.bukkit.block.data.BlockData;
 import org.bukkit.inventory.ItemStack;
 import org.bukkit.plugin.Plugin;
@@ -20,8 +19,8 @@ public abstract class ExternalDataProvider {
         return Bukkit.getPluginManager().getPlugin(pluginId);
     }
 
-    public boolean isPresent() {
-        return getPlugin() != null;
+    public boolean isReady() {
+        return getPlugin() != null && getPlugin().isEnabled();
     }
 
     public abstract void init();

src/main/java/com/volmit/iris/core/link/Identifier.java

@@ -7,7 +7,7 @@ public record Identifier(String namespace, String key) {
     private static final String DEFAULT_NAMESPACE = "minecraft";
 
     public static Identifier fromString(String id) {
-        String[] strings = id.split(":", 1);
+        String[] strings = id.split(":", 2);
         if(strings.length == 1) {
             return new Identifier(DEFAULT_NAMESPACE, strings[0]);
         } else {

src/main/java/com/volmit/iris/core/link/OraxenDataProvider.java

@@ -35,7 +35,6 @@ import org.bukkit.block.data.BlockData;
 import org.bukkit.block.data.MultipleFacing;
 import org.bukkit.inventory.ItemStack;
 
-import java.lang.reflect.Field;
 import java.util.Map;
 import java.util.MissingResourceException;
 import java.util.Optional;
@@ -108,8 +107,8 @@ public class OraxenDataProvider extends ExternalDataProvider {
     }
 
     @Override
-    public boolean isPresent() {
-        return super.isPresent() && factories != null;
+    public boolean isReady() {
+        return super.isReady() && factories != null;
     }
 
     @Override

src/main/java/com/volmit/iris/core/nms/v19_4/NMSBinding19_4.java

@@ -42,6 +42,7 @@ import net.minecraft.world.level.block.Block;
 import net.minecraft.world.level.block.entity.BlockEntity;
 import net.minecraft.world.level.block.state.BlockState;
 import net.minecraft.world.level.chunk.ChunkAccess;
+import net.minecraft.world.level.chunk.ChunkStatus;
 import net.minecraft.world.level.chunk.LevelChunk;
 import org.bukkit.*;
 import org.bukkit.block.Biome;
@@ -434,7 +435,7 @@ public class NMSBinding19_4 implements INMSBinding {
 
     @Override
     public void injectBiomesFromMantle(Chunk e, Mantle mantle) {
-        LevelChunk chunk = ((CraftChunk) e).getHandle();
+        ChunkAccess chunk = ((CraftChunk) e).getHandle(ChunkStatus.FULL);
         AtomicInteger c = new AtomicInteger();
         AtomicInteger r = new AtomicInteger();
         mantle.iterateChunk(e.getX(), e.getZ(), MatterBiomeInject.class, (x, y, z, b) -> {

src/main/java/com/volmit/iris/core/service/ExternalDataSVC.java

@@ -23,8 +23,10 @@ import com.volmit.iris.core.link.*;
 import com.volmit.iris.util.collection.KList;
 import com.volmit.iris.util.plugin.IrisService;
 import lombok.Data;
-import org.bukkit.NamespacedKey;
+import org.bukkit.Bukkit;
 import org.bukkit.block.data.BlockData;
+import org.bukkit.event.EventHandler;
+import org.bukkit.event.server.PluginEnableEvent;
 import org.bukkit.inventory.ItemStack;
 
 import java.util.MissingResourceException;
@@ -33,31 +35,40 @@ import java.util.Optional;
 @Data
 public class ExternalDataSVC implements IrisService {
 
-    private KList<ExternalDataProvider> providers = new KList<>();
+    private KList<ExternalDataProvider> providers = new KList<>(), activeProviders = new KList<>();
 
     @Override
     public void onEnable() {
-        addProvider(
-//                new CustomItemsDataProvider(), //need this to be gradelized before i can add it to the master repo
-                new OraxenDataProvider(),
-                new ItemAdderDataProvider());
-    }
+        Bukkit.getPluginManager().registerEvents(this, Iris.instance);
 
-    @Override
-    public void onDisable() {
-    }
+        providers.add(new OraxenDataProvider());
+        providers.add(new ItemAdderDataProvider());
 
-    public void addProvider(ExternalDataProvider... provider) {
-        for (ExternalDataProvider p : provider) {
-            if (p.getPlugin() != null) {
-                providers.add(p);
+        for (ExternalDataProvider p : providers) {
+            if (p.isReady()) {
+                activeProviders.add(p);
                 p.init();
+                Iris.info("Enabled ExternalDataProvider for %s.", p.getPluginId());
             }
         }
     }
 
+    @Override
+    public void onDisable() { }
+
+    @EventHandler
+    public void onPluginEnable(PluginEnableEvent e) {
+        if(activeProviders.stream().noneMatch(p -> p.getPlugin().equals(e.getPlugin()))) {
+            providers.stream().filter(p -> p.isReady() && p.getPlugin().equals(e.getPlugin())).findFirst().ifPresent(edp -> {
+                activeProviders.add(edp);
+                edp.init();
+                Iris.info("Enabled ExternalDataProvider for %s.", edp.getPluginId());
+            });
+        }
+    }
+
     public Optional<BlockData> getBlockData(Identifier key) {
-        Optional<ExternalDataProvider> provider = providers.stream().filter(p -> p.isPresent() && p.isValidProvider(key, false)).findFirst();
+        Optional<ExternalDataProvider> provider = activeProviders.stream().filter(p -> p.isValidProvider(key, false)).findFirst();
         if (provider.isEmpty())
             return Optional.empty();
         try {
@@ -69,7 +80,7 @@ public class ExternalDataSVC implements IrisService {
     }
 
     public Optional<ItemStack> getItemStack(Identifier key) {
-        Optional<ExternalDataProvider> provider = providers.stream().filter(p -> p.isPresent() && p.isValidProvider(key, true)).findFirst();
+        Optional<ExternalDataProvider> provider = activeProviders.stream().filter(p -> p.isValidProvider(key, true)).findFirst();
         if (provider.isEmpty()) {
             Iris.warn("No matching Provider found for modded material \"%s\"!", key);
             return Optional.empty();
@@ -84,13 +95,13 @@ public class ExternalDataSVC implements IrisService {
 
     public Identifier[] getAllBlockIdentifiers() {
         KList<Identifier> names = new KList<>();
-        providers.stream().filter(ExternalDataProvider::isPresent).forEach(p -> names.add(p.getBlockTypes()));
+        activeProviders.forEach(p -> names.add(p.getBlockTypes()));
         return names.toArray(new Identifier[0]);
     }
 
     public Identifier[] getAllItemIdentifiers() {
         KList<Identifier> names = new KList<>();
-        providers.stream().filter(ExternalDataProvider::isPresent).forEach(p -> names.add(p.getItemTypes()));
+        activeProviders.forEach(p -> names.add(p.getItemTypes()));
         return names.toArray(new Identifier[0]);
     }
 }

src/main/resources/plugin.yml

@@ -21,6 +21,4 @@ commands:
   iris:
     aliases: [ ir, irs ]
 api-version: ${apiversion}
-softdepend:
-  - ItemsAdder
 hotload-dependencies: false