mirrors/Iris
1
0
Fork 0
mirror of https://github.com/VolmitSoftware/Iris.git synced 2026-10-12 03:24:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Drop JIT-bound allocation assertion

Browse Source 
- Remove the accessor allocation comparison whose per-call byte counts depend on escape analysis timing and failed under load, keeping the three behavioral accessor tests
This commit is contained in:
Brian Neumann-Fopiano
2026-09-08 06:36:17 -04:00
parent 114cc68a08
commit 425d305d0b
1 changed files with 0 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/src/test/java/art/arcane/iris/engine/hydrology/HydrologyColumnSampleAccessorTest.java
-70
View File
@@ -1,13 +1,9 @@
package art.arcane.iris.engine.hydrology;
import org.junit.Assume;
import org.junit.Test;
import java.lang.management.ManagementFactory;
import java.lang.management.ThreadMXBean;
import java.util.ArrayList;
import java.util.List;
import java.util.function.Supplier;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
@@ -16,9 +12,6 @@ import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
public class HydrologyColumnSampleAccessorTest {
private static final int WARMUP = 20_000;
private static final int ROUNDS = 20_000;
private static final int PASSES = 5;
@Test
public void theNullableSurfaceAccessorsAgreeWithTheOptionalOnes() {
@@ -48,21 +41,6 @@ public class HydrologyColumnSampleAccessorTest {
assertEquals(sample.primarySurfaceLayerOrNull().bedY(), sample.terrainHeight());
}
@Test
public void theNullableAccessorNeverAllocatesMoreThanTheOptionalOne() {
HydrologyColumnSample sample = sample();
Measurement nullable = best(() -> sample.primarySurfaceLayerOrNull());
Measurement optional = best(() -> sample.primarySurfaceLayer().orElse(null));
System.out.println("[bench] primarySurfaceLayer nullable=" + nullable + " optional=" + optional);
Assume.assumeTrue("per-thread allocation counters are unavailable on this JVM", nullable.bytes() >= 0L);
assertTrue("the nullable accessor allocated " + nullable.bytes()
+ " bytes against " + optional.bytes() + " for the Optional accessor",
nullable.bytes() <= optional.bytes());
}
private static HydrologyColumnSample sample() {
List<HydrologyColumnLayer> layers = new ArrayList<>();
layers.add(layer(1L, HydrologyFeatureType.RIFFLE, 66, 68, true, false, true, true));
@@ -102,52 +80,4 @@ public class HydrologyColumnSampleAccessorTest {
"overworld/river-bank",
"overworld/river-cave");
}
private static Measurement best(Supplier<HydrologyColumnLayer> work) {
for (int round = 0; round < WARMUP; round++) {
work.get();
}
long bytes = Long.MAX_VALUE;
long nanos = Long.MAX_VALUE;
for (int pass = 0; pass < PASSES; pass++) {
Measurement measured = measure(work);
if (measured.bytes() < 0L) {
return measured;
}
bytes = Math.min(bytes, measured.bytes());
nanos = Math.min(nanos, measured.nanos());
}
return new Measurement(bytes, nanos);
}
private static Measurement measure(Supplier<HydrologyColumnLayer> work) {
HydrologyColumnLayer sink = null;
long startBytes = allocatedBytes();
long startNanos = System.nanoTime();
for (int round = 0; round < ROUNDS; round++) {
sink = work.get();
}
long elapsedNanos = System.nanoTime() - startNanos;
long endBytes = allocatedBytes();
assertNotNull(sink);
long bytes = startBytes < 0L || endBytes < 0L ? -1L : (endBytes - startBytes) / ROUNDS;
return new Measurement(bytes, elapsedNanos / ROUNDS);
}
private static long allocatedBytes() {
ThreadMXBean threads = ManagementFactory.getThreadMXBean();
if (!(threads instanceof com.sun.management.ThreadMXBean hotspot) || !hotspot.isThreadAllocatedMemoryEnabled()) {
return -1L;
}
return hotspot.getThreadAllocatedBytes(Thread.currentThread().threadId());
}
private record Measurement(long bytes, long nanos) {
@Override
public String toString() {
return "{bytes/op=" + bytes + ", ns/op=" + nanos + "}";
}
}
}