fix

libs/hbb_common

@@ -1 +1 @@
-Subproject commit 58a0ca52b5340c29595aa1adcb9f7ee45e6ef4d3
+Subproject commit afce320583693795f971e081298528e32d2719bd

src/main.rs

@@ -44,23 +44,15 @@ async fn main() -> ResultType<()> {
     };
     let port = get_arg("port", DEFAULT_PORT);
     let mut relay_server = get_arg("relay-server", "");
-    if !relay_server.contains(":") {
+    if let Err(err) = test_if_valid_server(&relay_server) {
-        relay_server = format!("{}:21117", relay_server);
-    }
-    if !relay_server.parse::<std::net::SocketAddr>().is_ok() {
         relay_server = "".to_owned();
+        log::error!("Invalid relay-server: {}", err);
     }
     let serial: i32 = get_arg("serial", "").parse().unwrap_or(0);
     let rendezvous_servers: Vec<String> = get_arg("rendezvous-servers", "")
         .split(",")
-        .map(|x| {
+        .filter(|x| test_if_valid_server(x).is_ok())
-            if !x.contains(":") {
+        .map(|x| x.to_owned())
-                format!("{}:21116", x)
-            } else {
-                x.to_owned()
-            }
-        })
-        .filter(|x| x.parse::<std::net::SocketAddr>().is_ok())
         .collect();
     let addr = format!("0.0.0.0:{}", port);
     log::info!("Listening on {}", addr);

src/rendezvous_server.rs

@@ -2,6 +2,7 @@ use hbb_common::{
     allow_err,
     bytes::{Bytes, BytesMut},
     bytes_codec::BytesCodec,
+    config::Config,
     futures_util::{
         sink::SinkExt,
         stream::{SplitSink, StreamExt},
@@ -296,14 +297,7 @@ impl RendezvousServer {
                             self.rendezvous_servers = cu
                                 .rendezvous_servers
                                 .drain(..)
-                                .map(|x| {
+                                .filter(|x| test_if_valid_server(x).is_ok())
-                                    if !x.contains(":") {
-                                        format!("{}:21116", x)
-                                    } else {
-                                        x
-                                    }
-                                })
-                                .filter(|x| x.parse::<std::net::SocketAddr>().is_ok())
                                 .collect();
                             log::info!(
                                 "configure updated: serial={} rendezvous-servers={:?}",
@@ -564,3 +558,11 @@ impl RendezvousServer {
         Ok(())
     }
 }
+
+pub fn test_if_valid_server(host: &str) -> ResultType<SocketAddr> {
+    if host.contains(":") {
+        Config::to_socket_addr(host)
+    } else {
+        Config::to_socket_addr(&format!("{}:{}", host, 0))
+    }
+}