moonlight-stream/moonlight-qt
1
0
Fork 0
mirror of https://github.com/moonlight-stream/moonlight-qt.git synced 2025-07-02 15:55:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix use-after-free in VDPAU overlay rendering

Browse Source
This commit is contained in:
Cameron Gutman 2020-12-18 19:39:24 -06:00
parent 027c8dcd41
commit dcbf5affda
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/streaming/video/ffmpeg-renderers/vdpau.cpp
View File

@ -385,9 +385,6 @@ void VDPAURenderer::notifyOverlayUpdated(Overlay::OverlayType type)
return; return;
} }
// Surface data is no longer needed
SDL_FreeSurface(newSurface);
VdpRect overlayRect; VdpRect overlayRect;
if (type == Overlay::OverlayStatusUpdate) { if (type == Overlay::OverlayStatusUpdate) {
@ -404,6 +401,9 @@ void VDPAURenderer::notifyOverlayUpdated(Overlay::OverlayType type)
overlayRect.x1 = overlayRect.x0 + newSurface->w; overlayRect.x1 = overlayRect.x0 + newSurface->w;
overlayRect.y1 = overlayRect.y0 + newSurface->h; overlayRect.y1 = overlayRect.y0 + newSurface->h;
// Surface data is no longer needed
SDL_FreeSurface(newSurface);
SDL_LockMutex(m_OverlayMutex); SDL_LockMutex(m_OverlayMutex);
m_OverlaySurface[type] = newBitmapSurface; m_OverlaySurface[type] = newBitmapSurface;
m_OverlayRect[type] = overlayRect; m_OverlayRect[type] = overlayRect;