From d9eca42311e792364cd671a6f931373af9c9036d Mon Sep 17 00:00:00 2001
From: Cameron Gutman <aicommander@gmail.com>
Date: Sat, 23 May 2026 19:28:28 -0500
Subject: [PATCH] Remove redundant QString construction

---
 app/backend/nvhttp.cpp        | 20 ++++++++++----------
 app/cli/commandlineparser.cpp |  2 +-
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/app/backend/nvhttp.cpp b/app/backend/nvhttp.cpp
index c542b748..8e779b0c 100644
--- a/app/backend/nvhttp.cpp
+++ b/app/backend/nvhttp.cpp
@@ -266,17 +266,17 @@ NvHTTP::getDisplayModeList(QString serverInfo)
     while (!xmlReader.atEnd()) {
         while (xmlReader.readNextStartElement()) {
             auto name = xmlReader.name();
-            if (name == QString("DisplayMode")) {
+            if (name == "DisplayMode") {
                 modes.append(NvDisplayMode());
             }
             else if (!modes.isEmpty()) {
-                if (name == QString("Width")) {
+                if (name == "Width") {
                     modes.last().width = xmlReader.readElementText().toInt();
                 }
-                else if (name == QString("Height")) {
+                else if (name == "Height") {
                     modes.last().height = xmlReader.readElementText().toInt();
                 }
-                else if (name == QString("RefreshRate")) {
+                else if (name == "RefreshRate") {
                     modes.last().refreshRate = xmlReader.readElementText().toInt();
                 }
             }
@@ -301,7 +301,7 @@ NvHTTP::getAppList()
     while (!xmlReader.atEnd()) {
         while (xmlReader.readNextStartElement()) {
             auto name = xmlReader.name();
-            if (name == QString("App")) {
+            if (name == "App") {
                 // We must have a valid app before advancing to the next one
                 if (!apps.isEmpty() && !apps.last().isInitialized()) {
                     qWarning() << "Invalid applist XML";
@@ -310,16 +310,16 @@ NvHTTP::getAppList()
                 apps.append(NvApp());
             }
             else if (!apps.isEmpty()) {
-                if (name == QString("AppTitle")) {
+                if (name == "AppTitle") {
                     apps.last().name = xmlReader.readElementText();
                 }
-                else if (name == QString("ID")) {
+                else if (name == "ID") {
                     apps.last().id = xmlReader.readElementText().toInt();
                 }
-                else if (name == QString("IsHdrSupported")) {
+                else if (name == "IsHdrSupported") {
                     apps.last().hdrSupported = xmlReader.readElementText() == "1";
                 }
-                else if (name == QString("IsAppCollectorGame")) {
+                else if (name == "IsAppCollectorGame") {
                     apps.last().isAppCollectorGame = xmlReader.readElementText() == "1";
                 }
             }
@@ -336,7 +336,7 @@ NvHTTP::verifyResponseStatus(QString xml)
 
     while (xmlReader.readNextStartElement())
     {
-        if (xmlReader.name() == QString("root"))
+        if (xmlReader.name() == "root")
         {
             // Status code can be 0xFFFFFFFF in some rare cases on GFE 3.20.3, and
             // QString::toInt() will fail in that case, so use QString::toUInt()
diff --git a/app/cli/commandlineparser.cpp b/app/cli/commandlineparser.cpp
index a3360488..2acac458 100644
--- a/app/cli/commandlineparser.cpp
+++ b/app/cli/commandlineparser.cpp
@@ -195,7 +195,7 @@ GlobalCommandLineParser::ParseResult GlobalCommandLineParser::parse(const QStrin
             }
         }
 
-        parser.showError(QString("Invalid action"));
+        parser.showError("Invalid action");
     }
 }