diff --git a/Limelight/Database/DataManager.m b/Limelight/Database/DataManager.m index 7ecfc5ea..23e24040 100644 --- a/Limelight/Database/DataManager.m +++ b/Limelight/Database/DataManager.m @@ -20,7 +20,7 @@ Settings* settingsToSave = [self retrieveSettings]; settingsToSave.framerate = [NSNumber numberWithInteger:framerate]; // Bitrate is persisted in kbps - settingsToSave.bitrate = [NSNumber numberWithInteger:bitrate * 1000]; + settingsToSave.bitrate = [NSNumber numberWithInteger:bitrate]; settingsToSave.height = [NSNumber numberWithInteger:height]; settingsToSave.width = [NSNumber numberWithInteger:width]; settingsToSave.onscreenControls = [NSNumber numberWithInteger:onscreenControls]; diff --git a/Limelight/ViewControllers/SettingsViewController.m b/Limelight/ViewControllers/SettingsViewController.m index 20b7be45..524ebc47 100644 --- a/Limelight/ViewControllers/SettingsViewController.m +++ b/Limelight/ViewControllers/SettingsViewController.m @@ -10,12 +10,12 @@ #import "Settings.h" #import "DataManager.h" -#define BITRATE_INTERVAL 1 +#define BITRATE_INTERVAL 500 // in kbps @implementation SettingsViewController { NSInteger _bitrate; } -static NSString* bitrateFormat = @"Bitrate: %d Mbps"; +static NSString* bitrateFormat = @"Bitrate: %.1f Mbps"; - (void)viewDidLoad { @@ -25,7 +25,7 @@ static NSString* bitrateFormat = @"Bitrate: %d Mbps"; Settings* currentSettings = [dataMan retrieveSettings]; // Bitrate is persisted in kbps - _bitrate = [currentSettings.bitrate integerValue] / 1000; + _bitrate = [currentSettings.bitrate integerValue]; NSInteger framerate = [currentSettings.framerate integerValue] == 30 ? 0 : 1; NSInteger resolution; if ([currentSettings.height integerValue] == 720) { @@ -40,16 +40,20 @@ static NSString* bitrateFormat = @"Bitrate: %d Mbps"; [self.resolutionSelector setSelectedSegmentIndex:resolution]; [self.framerateSelector setSelectedSegmentIndex:framerate]; [self.onscreenControlSelector setSelectedSegmentIndex:onscreenControls]; - [self.bitrateSlider setValue:_bitrate animated:YES]; + [self.bitrateSlider setValue:(_bitrate / 1000) animated:YES]; [self.bitrateSlider addTarget:self action:@selector(bitrateSliderMoved) forControlEvents:UIControlEventValueChanged]; - [self.bitrateLabel setText:[NSString stringWithFormat:bitrateFormat, (int)_bitrate]]; + [self updateBitrateText]; } - (void) bitrateSliderMoved { - _bitrate = BITRATE_INTERVAL * floor((self.bitrateSlider.value/BITRATE_INTERVAL)+0.5); - [self.bitrateLabel setText:[NSString stringWithFormat:bitrateFormat, (int)_bitrate]]; + _bitrate = BITRATE_INTERVAL * (int)self.bitrateSlider.value; + [self updateBitrateText]; } +- (void) updateBitrateText { + // Display bitrate in Mbps + [self.bitrateLabel setText:[NSString stringWithFormat:bitrateFormat, _bitrate / 1000.]]; +} - (void) saveSettings { DataManager* dataMan = [[DataManager alloc] init]; diff --git a/iPad.storyboard b/iPad.storyboard index d67f042c..1cf1c260 100644 --- a/iPad.storyboard +++ b/iPad.storyboard @@ -1,5 +1,5 @@ - + @@ -81,7 +81,7 @@ - + diff --git a/iPhone.storyboard b/iPhone.storyboard index c20efc6a..920eca05 100644 --- a/iPhone.storyboard +++ b/iPhone.storyboard @@ -1,5 +1,5 @@ - + @@ -94,7 +94,7 @@ - +