From bfc6751f0ff730ccd5f50ae97ec1ed6cfc013144 Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Sat, 24 Oct 2026 18:46:33 -0500 Subject: [PATCH] Fix fd leak in VAAPI KMSDRM codepath --- app/streaming/video/ffmpeg-renderers/vaapi.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/streaming/video/ffmpeg-renderers/vaapi.cpp b/app/streaming/video/ffmpeg-renderers/vaapi.cpp index 9981c6ed..05bc709e 100644 --- a/app/streaming/video/ffmpeg-renderers/vaapi.cpp +++ b/app/streaming/video/ffmpeg-renderers/vaapi.cpp @@ -161,6 +161,9 @@ VAAPIRenderer::openDisplay(SDL_Window* window) errno); return nullptr; } + // This FD is owned by us (not shared with SDL), so it must be + // closed when we're done with it or adopted into m_DrmFd. + mustCloseFd = true; } // If the KMSDRM FD is not a render node FD, open the render node for libva to use.