From afcd08ccbcbb82ad25298008f3424aa924aa74d5 Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Sat, 3 Oct 2026 18:30:08 -0500 Subject: [PATCH] Require SIGNTOOL_PARAMS to be set externally --- scripts/build-arch.bat | 7 +++++-- scripts/generate-bundle.bat | 7 +++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/scripts/build-arch.bat b/scripts/build-arch.bat index aff4a249..3e1667e5 100644 --- a/scripts/build-arch.bat +++ b/scripts/build-arch.bat @@ -26,6 +26,11 @@ if /I "%BUILD_CONFIG%"=="debug" ( exit /b 1 ) + if not defined SIGNTOOL_PARAMS ( + echo "A signtool parameter string must be specified in SIGNTOOL_PARAMS for signed release builds" + exit /b 1 + ) + echo Updating dependencies powershell %cd%\setup-deps.ps1 if !ERRORLEVEL! NEQ 0 ( @@ -104,8 +109,6 @@ if not x%QT_PATH:_arm64=%==x%QT_PATH% ( echo Detected target architecture: %ARCH% -set SIGNTOOL_PARAMS=sign /tr http://timestamp.digicert.com /td sha256 /fd sha256 /sha1 8b9d0d682ad9459e54f05a79694bc10f9876e297 /v - set BUILD_ROOT=%cd%\build set SOURCE_ROOT=%cd% set BUILD_FOLDER=%BUILD_ROOT%\build-%ARCH%-%BUILD_CONFIG% diff --git a/scripts/generate-bundle.bat b/scripts/generate-bundle.bat index 56975727..16bb575d 100644 --- a/scripts/generate-bundle.bat +++ b/scripts/generate-bundle.bat @@ -25,6 +25,11 @@ if /I "%BUILD_CONFIG%"=="debug" ( echo Signed release builds must not have unstaged changes! exit /b 1 ) + + if not defined SIGNTOOL_PARAMS ( + echo "A signtool parameter string must be specified in SIGNTOOL_PARAMS for signed release builds" + exit /b 1 + ) ) else ( echo Invalid build configuration - expected 'debug' or 'release' exit /b 1 @@ -32,8 +37,6 @@ if /I "%BUILD_CONFIG%"=="debug" ( ) ) -set SIGNTOOL_PARAMS=sign /tr http://timestamp.digicert.com /td sha256 /fd sha256 /sha1 8b9d0d682ad9459e54f05a79694bc10f9876e297 /v - set BUILD_ROOT=%cd%\build set SOURCE_ROOT=%cd% set BUILD_FOLDER=%BUILD_ROOT%\build-%BUILD_CONFIG%