From afb2b465a8659eb23ca2f9f448d9cb85369bbab7 Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Sat, 22 Sep 2018 19:30:13 -0700 Subject: [PATCH] Avoid using direct submit for video decoding because FFmpeg can delay for a fairly significant period of time within avcodec_send_packet() and avcodec_receive_frame(), even for software decoding. This is particularly apparent when streaming well above hardware capabilities and leads to packet loss. --- app/streaming/session.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/app/streaming/session.cpp b/app/streaming/session.cpp index ea8926f1..a6369f0f 100644 --- a/app/streaming/session.cpp +++ b/app/streaming/session.cpp @@ -294,9 +294,6 @@ void Session::initialize() m_VideoCallbacks.setup = drSetup; m_VideoCallbacks.submitDecodeUnit = drSubmitDecodeUnit; - // Submit for decode without using a separate thread - m_VideoCallbacks.capabilities |= CAPABILITY_DIRECT_SUBMIT; - // Slice up to 4 times for parallel decode, once slice per core int slices = qMin(MAX_SLICES, SDL_GetCPUCount()); m_VideoCallbacks.capabilities |= CAPABILITY_SLICES_PER_FRAME(slices);