From 752f0a988bd087fbb1b587d7cfa18507372d9836 Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Mon, 8 Jun 2020 20:16:42 -0700 Subject: [PATCH] Fix crash during key generation introduced by dcba5762c72e --- app/backend/identitymanager.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/backend/identitymanager.cpp b/app/backend/identitymanager.cpp index b7587273..95bb9768 100644 --- a/app/backend/identitymanager.cpp +++ b/app/backend/identitymanager.cpp @@ -31,13 +31,16 @@ void IdentityManager::createCredentials(QSettings& settings) X509* cert = X509_new(); THROW_BAD_ALLOC_IF_NULL(cert); - EVP_PKEY* pk; EVP_PKEY_CTX* ctx = EVP_PKEY_CTX_new_id(EVP_PKEY_RSA, NULL); THROW_BAD_ALLOC_IF_NULL(ctx); EVP_PKEY_keygen_init(ctx); EVP_PKEY_CTX_set_rsa_keygen_bits(ctx, 2048); + + // pk must be initialized on input + EVP_PKEY* pk = NULL; EVP_PKEY_keygen(ctx, &pk); + EVP_PKEY_CTX_free(ctx); THROW_BAD_ALLOC_IF_NULL(pk);