mirror of
https://github.com/moonlight-stream/moonlight-qt.git
synced 2026-02-16 02:30:52 +00:00
Only set initial MenuItem focus if not activating via mouse
Having an initially highlighted item when using mouse navigation doesn't adhere to UX norms and also can lead to a janky feeling when the focus flip-flops from the item under the user's cursor to the first item as the Menu opens.
This commit is contained in:
@@ -288,6 +288,7 @@ CenteredGridView {
|
||||
asynchronous: true
|
||||
sourceComponent: NavigableMenu {
|
||||
id: appContextMenu
|
||||
initiator: appContextMenuLoader.parent
|
||||
NavigableMenuItem {
|
||||
text: model.running ? qsTr("Resume Game") : qsTr("Launch Game")
|
||||
onTriggered: launchOrResumeSelectedApp(true)
|
||||
|
||||
@@ -2,8 +2,12 @@ import QtQuick 2.0
|
||||
import QtQuick.Controls 2.2
|
||||
|
||||
Menu {
|
||||
property var initiator
|
||||
|
||||
onOpened: {
|
||||
// Give focus to the first visible and enabled menu item
|
||||
// If the initiating object currently has keyboard focus,
|
||||
// give focus to the first visible and enabled menu item
|
||||
if (initiator.focus) {
|
||||
for (var i = 0; i < count; i++) {
|
||||
var item = itemAt(i)
|
||||
if (item.visible && item.enabled) {
|
||||
@@ -13,3 +17,4 @@ Menu {
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -165,6 +165,7 @@ CenteredGridView {
|
||||
asynchronous: true
|
||||
sourceComponent: NavigableMenu {
|
||||
id: pcContextMenu
|
||||
initiator: pcContextMenuLoader.parent
|
||||
MenuItem {
|
||||
text: qsTr("PC Status: %1").arg(model.online ? qsTr("Online") : qsTr("Offline"))
|
||||
font.bold: true
|
||||
|
||||
Reference in New Issue
Block a user