From 6cab2bec61cb53a113909400aeffe25cdefab653 Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Fri, 15 Feb 2019 19:10:21 -0800 Subject: [PATCH] Don't trust VT to tell us whether decode is supported --- app/streaming/video/ffmpeg-renderers/vt.mm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/streaming/video/ffmpeg-renderers/vt.mm b/app/streaming/video/ffmpeg-renderers/vt.mm index 0dbca576..fef786b7 100644 --- a/app/streaming/video/ffmpeg-renderers/vt.mm +++ b/app/streaming/video/ffmpeg-renderers/vt.mm @@ -244,8 +244,11 @@ public: virtual bool needsTestFrame() override { - // We query VT to determine whether the codec is supported - return false; + // We used to trust VT to tell us whether decode will work, but + // there are cases where it can lie because the hardware technically + // can decode the format but VT is unserviceable for some other reason. + // Decoding the test frame will tell us for sure whether it will work. + return true; } virtual int getDecoderCapabilities() override