From 3e85f13e084400fe4bbfb50b48e70717fe9a73cb Mon Sep 17 00:00:00 2001
From: Cameron Gutman <aicommander@gmail.com>
Date: Fri, 9 Jan 2015 23:21:42 -0500
Subject: [PATCH] Fix crash on bad server response

---
 Limelight/Network/HttpManager.m | 27 +++++++++++++++++++++------
 1 file changed, 21 insertions(+), 6 deletions(-)

diff --git a/Limelight/Network/HttpManager.m b/Limelight/Network/HttpManager.m
index 1953ed51..c5982c03 100644
--- a/Limelight/Network/HttpManager.m
+++ b/Limelight/Network/HttpManager.m
@@ -152,6 +152,11 @@ static const NSString* PORT = @"47984";
     
     NSString* string;
     xmlNodePtr rootNode = xmlDocGetRootElement(docPtr);
+    if (rootNode == NULL) {
+        NSLog(@"ERROR: No root XML element.");
+        xmlFreeDoc(docPtr);
+        return NULL;
+    }
     
     string = [HttpManager getStatusMessage: rootNode];
     
@@ -199,17 +204,27 @@ static const NSString* PORT = @"47984";
     
 + (NSString*) getStatusMessage:(xmlNodePtr)docRoot {
     xmlChar* statusMsgXml = xmlGetProp(docRoot, (const xmlChar*)"status_message");
-    NSString* statusMsg = [NSString stringWithUTF8String:(const char*)statusMsgXml];
-    xmlFree(statusMsgXml);
+    NSString* statusMsg;
+    if (statusMsgXml != NULL) {
+        statusMsg = [NSString stringWithUTF8String:(const char*)statusMsgXml];
+        xmlFree(statusMsgXml);
+    }
+    else {
+        statusMsg = @"Server Error";
+    }
+
     return statusMsg;
 }
 
 + (bool) verifyStatus:(xmlNodePtr)docRoot {
     xmlChar* statusStr = xmlGetProp(docRoot, (const xmlChar*)"status_code");
-    //NSLog(@"status: %s", statusStr);
-    int status = [[NSString stringWithUTF8String:(const char*)statusStr] intValue];
-    xmlFree(statusStr);
-    return status == 200;
+    if (statusStr != NULL) {
+        int status = [[NSString stringWithUTF8String:(const char*)statusStr] intValue];
+        xmlFree(statusStr);
+        return status == 200;
+    }
+
+    return false;
 }
 
 + (NSData*) fixXmlVersion:(NSData*) xmlData {