From 18d1d35104ffeff4b3d55bcab1f037e06f93f2a0 Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Thu, 2 May 2019 22:54:18 -0700 Subject: [PATCH] Use QByteArray::reserve() rather than reallocating each time we must resize --- app/streaming/video/ffmpeg.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/streaming/video/ffmpeg.cpp b/app/streaming/video/ffmpeg.cpp index 436a40d1..154ad8df 100644 --- a/app/streaming/video/ffmpeg.cpp +++ b/app/streaming/video/ffmpeg.cpp @@ -620,9 +620,9 @@ int FFmpegVideoDecoder::submitDecodeUnit(PDECODE_UNIT du) // Add some extra space in case we need to do an SPS fixup requiredBufferSize += MAX_SPS_EXTRA_SIZE; } - if (requiredBufferSize + AV_INPUT_BUFFER_PADDING_SIZE > m_DecodeBuffer.length()) { - m_DecodeBuffer = QByteArray(requiredBufferSize + AV_INPUT_BUFFER_PADDING_SIZE, 0); - } + + // Ensure the decoder buffer is large enough + m_DecodeBuffer.reserve(requiredBufferSize + AV_INPUT_BUFFER_PADDING_SIZE); int offset = 0; while (entry != nullptr) {