From 0c4f7aefb6b0b72a025f57fc4e03a50dc496c907 Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Sat, 24 Oct 2026 18:37:28 -0500 Subject: [PATCH] Handle unexpected appVersion/gfeVersion quads --- app/backend/nvpairingmanager.cpp | 2 +- app/streaming/session.cpp | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/app/backend/nvpairingmanager.cpp b/app/backend/nvpairingmanager.cpp index 665e7e86..59be94ea 100644 --- a/app/backend/nvpairingmanager.cpp +++ b/app/backend/nvpairingmanager.cpp @@ -215,7 +215,7 @@ NvPairingManager::saltPin(const QByteArray& salt, QString pin) NvPairingManager::PairState NvPairingManager::pair(QString appVersion, QString pin, QSslCertificate& serverCert) { - int serverMajorVersion = NvHTTP::parseQuad(appVersion).at(0); + int serverMajorVersion = NvHTTP::parseQuad(appVersion).value(0); qInfo() << "Pairing with server generation:" << serverMajorVersion; QCryptographicHash::Algorithm hashAlgo; diff --git a/app/streaming/session.cpp b/app/streaming/session.cpp index c6e3470d..3898c00f 100644 --- a/app/streaming/session.cpp +++ b/app/streaming/session.cpp @@ -840,9 +840,8 @@ bool Session::initialize(QQuickWindow* qtWindow) // to allow decoding via VideoToolbox on macOS. Since we don't // have fixup code for HEVC, just avoid it if GFE is too old. QVector gfeVersion = NvHTTP::parseQuad(m_Computer->gfeVersion); - if (gfeVersion.isEmpty() || // Very old versions don't have GfeVersion at all - gfeVersion[0] < 3 || - (gfeVersion[0] == 3 && gfeVersion[1] < 11)) { + if (gfeVersion.value(0) < 3 || + (gfeVersion.value(0) == 3 && gfeVersion.value(1) < 11)) { SDL_LogWarn(SDL_LOG_CATEGORY_APPLICATION, "Disabling HEVC on macOS due to old GFE version"); m_SupportedVideoFormats.removeByMask(VIDEO_FORMAT_MASK_H265);