From 07277c3d788c5863d0f62e65d863c5db4b62eac8 Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Sat, 17 Jul 2021 20:32:50 -0500 Subject: [PATCH] Remove unneccessary EVP_get_digestbyname() invocation This causes problems with pre-OpenSSL 1.1.0 clients that don't call OpenSSL_add_all_algorithms() during initialization. This is known to affect Steam Link on firmware 815. --- app/backend/nvpairingmanager.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/app/backend/nvpairingmanager.cpp b/app/backend/nvpairingmanager.cpp index 6053e8be..3e03359b 100644 --- a/app/backend/nvpairingmanager.cpp +++ b/app/backend/nvpairingmanager.cpp @@ -167,11 +167,7 @@ NvPairingManager::signMessage(const QByteArray& message) EVP_MD_CTX *ctx = EVP_MD_CTX_create(); THROW_BAD_ALLOC_IF_NULL(ctx); - const EVP_MD *md = EVP_get_digestbyname("SHA256"); - THROW_BAD_ALLOC_IF_NULL(md); - - EVP_DigestInit_ex(ctx, md, NULL); - EVP_DigestSignInit(ctx, NULL, md, NULL, m_PrivateKey); + EVP_DigestSignInit(ctx, NULL, EVP_sha256(), NULL, m_PrivateKey); EVP_DigestSignUpdate(ctx, reinterpret_cast(const_cast(message.data())), message.length()); size_t signatureLength = 0;