From e6e7ec9202af6af7a69f2e7ae1b20e37b7eb91ea Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Thu, 31 May 2018 01:22:03 -0700 Subject: [PATCH] Avoid animating the loading frame --- Limelight/ViewControllers/MainFrameViewController.m | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Limelight/ViewControllers/MainFrameViewController.m b/Limelight/ViewControllers/MainFrameViewController.m index a4be5c5..ca9cc9a 100644 --- a/Limelight/ViewControllers/MainFrameViewController.m +++ b/Limelight/ViewControllers/MainFrameViewController.m @@ -550,11 +550,16 @@ static NSMutableSet* hostList; - (void) showLoadingFrame { LoadingFrameViewController* loadingFrame = [self.storyboard instantiateViewControllerWithIdentifier:@"loadingFrame"]; - [self.navigationController presentViewController:loadingFrame animated:YES completion:nil]; + + // Avoid animating this as it significantly prolongs the loading frame's + // time on screen and can lead to warnings about dismissing while it's + // still animating. + [self.navigationController presentViewController:loadingFrame animated:NO completion:nil]; } - (void) hideLoadingFrame { - [self dismissViewControllerAnimated:YES completion:nil]; + // See comment above in showLoadingFrame about why we don't animate this + [self dismissViewControllerAnimated:NO completion:nil]; [self enableNavigation]; }