moonlight-stream/moonlight-ios
1
0
Fork 0
mirror of https://github.com/moonlight-stream/moonlight-ios.git synced 2025-07-01 15:26:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix leaks from getClientCertificate

Browse Source 
Ref: #654
This commit is contained in:
Cameron Gutman 2024-12-20 15:15:22 -06:00
parent 1cfabac4b5
commit b88cf14b4e
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Limelight/Network/HttpManager.m
View File

@ -326,7 +326,7 @@
SecIdentityCopyCertificate(identity, &certificate); SecIdentityCopyCertificate(identity, &certificate);
return [[NSArray alloc] initWithObjects:(__bridge id)certificate, nil]; return [[NSArray alloc] initWithObjects:(__bridge_transfer id)certificate, nil];
} }
// Returns the identity // Returns the identity
@ -338,13 +338,14 @@
const void *keys[] = { kSecImportExportPassphrase }; const void *keys[] = { kSecImportExportPassphrase };
const void *values[] = { password }; const void *values[] = { password };
CFDictionaryRef options = CFDictionaryCreate(NULL, keys, values, 1, NULL, NULL); CFDictionaryRef options = CFDictionaryCreate(NULL, keys, values, 1, NULL, NULL);
CFArrayRef items = CFArrayCreate(NULL, 0, 0, NULL); CFArrayRef items = nil;
OSStatus securityError = SecPKCS12Import(p12Data, options, &items); OSStatus securityError = SecPKCS12Import(p12Data, options, &items);
if (securityError == errSecSuccess) { if (securityError == errSecSuccess) {
//Log(LOG_D, @"Success opening p12 certificate. Items: %ld", CFArrayGetCount(items)); //Log(LOG_D, @"Success opening p12 certificate. Items: %ld", CFArrayGetCount(items));
CFDictionaryRef identityDict = CFArrayGetValueAtIndex(items, 0); CFDictionaryRef identityDict = CFArrayGetValueAtIndex(items, 0);
identityApp = (SecIdentityRef)CFDictionaryGetValue(identityDict, kSecImportItemIdentity); identityApp = (SecIdentityRef)CFRetain(CFDictionaryGetValue(identityDict, kSecImportItemIdentity));
CFRelease(items);
} else { } else {
Log(LOG_E, @"Error opening Certificate."); Log(LOG_E, @"Error opening Certificate.");
} }
@ -398,6 +399,7 @@
SecIdentityRef identity = [self getClientCertificate]; SecIdentityRef identity = [self getClientCertificate];
NSArray* certArray = [self getCertificate:identity]; NSArray* certArray = [self getCertificate:identity];
NSURLCredential* newCredential = [NSURLCredential credentialWithIdentity:identity certificates:certArray persistence:NSURLCredentialPersistencePermanent]; NSURLCredential* newCredential = [NSURLCredential credentialWithIdentity:identity certificates:certArray persistence:NSURLCredentialPersistencePermanent];
CFRelease(identity);
completionHandler(NSURLSessionAuthChallengeUseCredential, newCredential); completionHandler(NSURLSessionAuthChallengeUseCredential, newCredential);
} }
else else