From aea2067e1c7d61f9ab42da48722c348741b176eb Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Tue, 29 May 2018 20:17:48 -0700 Subject: [PATCH] Silence the firehose of debug logging statements --- Limelight/Network/DiscoveryWorker.m | 2 +- Limelight/Stream/Connection.m | 6 +++--- Limelight/Utility/Logger.m | 8 ++++++++ 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/Limelight/Network/DiscoveryWorker.m b/Limelight/Network/DiscoveryWorker.m index 15ae3b4..696584d 100644 --- a/Limelight/Network/DiscoveryWorker.m +++ b/Limelight/Network/DiscoveryWorker.m @@ -112,7 +112,7 @@ static const float POLL_RATE = 2.0f; // Poll every 2 seconds } if (receivedResponse) { - Log(LOG_I, @"Received serverinfo response on try %d", i); + Log(LOG_D, @"Received serverinfo response on try %d", i); break; } else { diff --git a/Limelight/Stream/Connection.m b/Limelight/Stream/Connection.m index b02aaa3..96051f7 100644 --- a/Limelight/Stream/Connection.m +++ b/Limelight/Stream/Connection.m @@ -128,14 +128,14 @@ int ArInit(int audioConfiguration, POPUS_MULTISTREAM_CONFIGURATION opusConfig, v status = AudioQueueNewOutput(&audioFormat, FillOutputBuffer, nil, nil, nil, 0, &audioQueue); if (status != noErr) { - NSLog(@"Error allocating output queue: %d\n", status); + Log(LOG_E, @"Error allocating output queue: %d\n", status); return status; } for (int i = 0; i < AUDIO_QUEUE_BUFFERS; i++) { status = AudioQueueAllocateBuffer(audioQueue, audioFormat.mBytesPerFrame * FRAME_SIZE, &audioBuffers[i]); if (status != noErr) { - NSLog(@"Error allocating output buffer: %d\n", status); + Log(LOG_E, @"Error allocating output buffer: %d\n", status); return status; } @@ -144,7 +144,7 @@ int ArInit(int audioConfiguration, POPUS_MULTISTREAM_CONFIGURATION opusConfig, v status = AudioQueueStart(audioQueue, nil); if (status != noErr) { - NSLog(@"Error starting queue: %d\n", status); + Log(LOG_E, @"Error starting queue: %d\n", status); return status; } diff --git a/Limelight/Utility/Logger.m b/Limelight/Utility/Logger.m index f676313..3d1d004 100644 --- a/Limelight/Utility/Logger.m +++ b/Limelight/Utility/Logger.m @@ -8,6 +8,8 @@ #import "Logger.h" +static LogLevel LoggerLogLevel = LOG_I; + void LogTagv(LogLevel level, NSString* tag, NSString* fmt, va_list args); void Log(LogLevel level, NSString* fmt, ...) { @@ -27,6 +29,10 @@ void LogTag(LogLevel level, NSString* tag, NSString* fmt, ...) { void LogTagv(LogLevel level, NSString* tag, NSString* fmt, va_list args) { NSString* levelPrefix = @""; + if (level < LoggerLogLevel) { + return; + } + switch(level) { case LOG_D: levelPrefix = PRFX_DEBUG; @@ -41,6 +47,8 @@ void LogTagv(LogLevel level, NSString* tag, NSString* fmt, va_list args) { levelPrefix = PRFX_ERROR; break; default: + levelPrefix = @""; + assert(false); break; } NSString* prefixedString;