Remove executeRequest from HttpManager. It has some show-stopping bugs, like leaking semaphore counts (since it never waited) and being generally thread-unsafe. Implementing it in a way that would be asynchronous and thread-safe is a non-trivial task, so I've opted to remove it and change callers to use executeRequestSynchronously.

This commit is contained in:
Cameron Gutman
2015-07-08 21:26:01 -07:00
parent c0b2bbe552
commit 6bb559303b
4 changed files with 10 additions and 15 deletions

View File

@@ -62,10 +62,6 @@ static const NSString* PORT = @"47984";
_errorOccurred = false;
}
- (void) executeRequest:(HttpRequest*)request {
[NSURLConnection connectionWithRequest:request.request delegate:self];
}
- (NSURLRequest*) createRequestFromString:(NSString*) urlString enableTimeout:(BOOL)normalTimeout {
NSURL* url = [[NSURL alloc] initWithString:urlString];
NSMutableURLRequest* request = [NSMutableURLRequest requestWithURL:url];