Compare commits

...

2 Commits

Author SHA1 Message Date
Cameron Gutman
a6bf7154a7 Reduce MAX_FRAMES for RK backend
See b1d111b5f7 (r146373202)
2024-09-08 00:32:30 -05:00
Mingjie Shen
274d3db34d fix unbounded write of sprintf
Buffer write operations that do not control the length of data written
may overflow. Fix by replacing sprintf() with snprintf().
2024-03-25 00:11:49 -05:00
3 changed files with 6 additions and 6 deletions

View File

@ -51,10 +51,10 @@ int http_init(const char* keyDirectory, int logLevel) {
return GS_FAILED;
char certificateFilePath[4096];
sprintf(certificateFilePath, "%s/%s", keyDirectory, CERTIFICATE_FILE_NAME);
snprintf(certificateFilePath, sizeof(certificateFilePath), "%s/%s", keyDirectory, CERTIFICATE_FILE_NAME);
char keyFilePath[4096];
sprintf(&keyFilePath[0], "%s/%s", keyDirectory, KEY_FILE_NAME);
snprintf(keyFilePath, sizeof(keyFilePath), "%s/%s", keyDirectory, KEY_FILE_NAME);
curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0L);
curl_easy_setopt(curl, CURLOPT_SSLENGINE_DEFAULT, 1L);

View File

@ -411,11 +411,11 @@ void config_parse(int argc, char* argv[], PCONFIGURATION config) {
struct passwd *pw = getpwuid(getuid());
const char *dir;
if ((dir = getenv("XDG_CACHE_DIR")) != NULL)
sprintf(config->key_dir, "%s" MOONLIGHT_PATH, dir);
snprintf(config->key_dir, sizeof(config->key_dir), "%s" MOONLIGHT_PATH, dir);
else if ((dir = getenv("HOME")) != NULL)
sprintf(config->key_dir, "%s" DEFAULT_CACHE_DIR MOONLIGHT_PATH, dir);
snprintf(config->key_dir, sizeof(config->key_dir), "%s" DEFAULT_CACHE_DIR MOONLIGHT_PATH, dir);
else
sprintf(config->key_dir, "%s" DEFAULT_CACHE_DIR MOONLIGHT_PATH, pw->pw_dir);
snprintf(config->key_dir, sizeof(config->key_dir), "%s" DEFAULT_CACHE_DIR MOONLIGHT_PATH, pw->pw_dir);
}
if (config->stream.bitrate == -1) {

View File

@ -39,7 +39,7 @@
#include <rockchip/rk_mpi.h>
#define MAX_FRAMES 16
#define MAX_FRAMES 3
#define RK_H264 0x7
#define RK_H265 0x1000004
#define RK_AV1 0x1000008