From e8dd103ed93b2cd2642938d9d663b5473bce5d7e Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Thu, 22 Nov 2018 12:52:11 -0800 Subject: [PATCH] Use existing cleanup path for handling early-out errors --- src/Connection.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/Connection.c b/src/Connection.c index 6eb9b00..36b72e5 100644 --- a/src/Connection.c +++ b/src/Connection.c @@ -179,18 +179,16 @@ int LiStartConnection(PSERVER_INFORMATION serverInfo, PSTREAM_CONFIGURATION stre if (StreamConfig.packetSize == 0) { Limelog("Invalid packet size specified\n"); - free(RemoteAddrString); - RemoteAddrString = NULL; - return -1; + err = -1; + goto Cleanup; } // Extract the appversion from the supplied string if (extractVersionQuadFromString(serverInfo->serverInfoAppVersion, AppVersionQuad) < 0) { Limelog("Invalid appversion string: %s\n", serverInfo->serverInfoAppVersion); - free(RemoteAddrString); - RemoteAddrString = NULL; - return -1; + err = -1; + goto Cleanup; } // Replace missing callbacks with placeholders