moonlight-stream/moonlight-common-c
1
0
Fork 0
mirror of https://github.com/moonlight-stream/moonlight-common-c.git synced 2025-08-18 01:15:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't enable QoS for remote IPv4 streams

Browse Source 
Some broken routers/CPE will drop all QoS tagged packets
This commit is contained in:
Cameron Gutman 2020-10-28 20:35:45 -05:00
parent edf08d0a60
commit dbf81dcb63
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/SdpGenerator.c
View File

@ -246,9 +246,20 @@ static PSDP_OPTION getAttributesList(char*urlSafeAddr) {
err |= addAttributeString(&optionHead, "x-nv-vqos[0].videoQualityScoreUpdateTime", "5000"); err |= addAttributeString(&optionHead, "x-nv-vqos[0].videoQualityScoreUpdateTime", "5000");
// Enable DSCP marking to hopefully increase QoS priority // If the remote host is local (RFC 1918) or IPv6 (where it's hard to tell based on the address
err |= addAttributeString(&optionHead, "x-nv-vqos[0].qosTrafficType", "5"); // alone), enable QoS tagging for our traffic. Windows qWave will disable it if the host is
err |= addAttributeString(&optionHead, "x-nv-aqos.qosTrafficType", "4"); // off-link, *however* Windows may get it wrong in cases where the host is directly connected
// to the Internet without a NAT. In this case, it may send DSCP marked traffic off-link and
// it could lead to black holes due to misconfigured ISP hardware or CPE. For this reason,
// we only enable it in cases where it looks like it will work.
if (StreamConfig.streamingRemotely == STREAM_CFG_LOCAL || RemoteAddr.ss_family == AF_INET6) {
err |= addAttributeString(&optionHead, "x-nv-vqos[0].qosTrafficType", "5");
err |= addAttributeString(&optionHead, "x-nv-aqos.qosTrafficType", "4");
}
else {
err |= addAttributeString(&optionHead, "x-nv-vqos[0].qosTrafficType", "0");
err |= addAttributeString(&optionHead, "x-nv-aqos.qosTrafficType", "0");
}
if (AppVersionQuad[0] == 3) { if (AppVersionQuad[0] == 3) {
err |= addGen3Options(&optionHead, urlSafeAddr); err |= addGen3Options(&optionHead, urlSafeAddr);