Fix double-free and memory leak in RTSP option parsing failure path

This commit is contained in:
Cameron Gutman
2017-09-02 16:09:22 -07:00
parent 454fdccffc
commit 957b1de1ad
+1 -2
View File
@@ -159,7 +159,6 @@ int parseRtspMessage(PRTSP_MESSAGE msg, char* rtspMessage, int length) {
// Create a new node containing the option and content // Create a new node containing the option and content
newOpt = (POPTION_ITEM)malloc(sizeof(OPTION_ITEM)); newOpt = (POPTION_ITEM)malloc(sizeof(OPTION_ITEM));
if (newOpt == NULL) { if (newOpt == NULL) {
freeOptionList(options);
exitCode = RTSP_ERROR_NO_MEMORY; exitCode = RTSP_ERROR_NO_MEMORY;
goto ExitFailure; goto ExitFailure;
} }
@@ -221,7 +220,7 @@ int parseRtspMessage(PRTSP_MESSAGE msg, char* rtspMessage, int length) {
ExitFailure: ExitFailure:
if (options) { if (options) {
free(options); freeOptionList(options);
} }
if (messageBuffer) { if (messageBuffer) {
free(messageBuffer); free(messageBuffer);