moonlight-stream/moonlight-common-c
1
0
Fork 0
mirror of https://github.com/moonlight-stream/moonlight-common-c.git synced 2025-08-18 01:15:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix unsafe modification of the peer variable during shutdown

Browse Source
This commit is contained in:
Cameron Gutman 2016-04-18 16:36:45 -04:00
parent 597199ed92
commit 8846493eb4
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/ControlStream.c
View File

@ -291,6 +291,12 @@ static int sendMessageEnet(short ptype, short paylen, const void* payload) {
int err;
LC_ASSERT(ServerMajorVersion >= 5);
// We may be trying to disconnect, so our peer could be gone.
// This check is safe because we're guaranteed to be holding enetMutex.
if (peer == NULL) {
return 0;
}
packet = malloc(sizeof(*packet) + paylen);
if (packet == NULL) {
@ -570,6 +576,7 @@ int stopControlStream(void) {
if (peer != NULL) {
PltLockMutex(&enetMutex);
enet_peer_disconnect_now(peer, 0);
peer = NULL;
PltUnlockMutex(&enetMutex);
}
@ -586,7 +593,6 @@ int stopControlStream(void) {
PltCloseThread(&lossStatsThread);
PltCloseThread(&invalidateRefFramesThread);
peer = NULL;
if (client != NULL) {
enet_host_destroy(client);
client = NULL;