Tighten up a bunch of declarations to make Lint happier

app/src/main/java/com/limelight/binding/audio/AndroidAudioRenderer.java

@@ -9,7 +9,7 @@ import com.limelight.nvstream.av.audio.AudioRenderer;
 
 public class AndroidAudioRenderer implements AudioRenderer {
 
-	public static final int FRAME_SIZE = 960;
+	private static final int FRAME_SIZE = 960;
 	
 	private AudioTrack track;
 

app/src/main/java/com/limelight/binding/crypto/AndroidCryptoProvider.java

@@ -45,8 +45,8 @@ import com.limelight.nvstream.http.LimelightCryptoProvider;
 
 public class AndroidCryptoProvider implements LimelightCryptoProvider {
 
-	private File certFile;
-	private File keyFile;
+	private final File certFile;
+	private final File keyFile;
 	
 	private X509Certificate cert;
 	private RSAPrivateKey key;

app/src/main/java/com/limelight/binding/input/ControllerHandler.java

@@ -30,17 +30,17 @@ public class ControllerHandler implements InputManager.InputDeviceListener {
 	private static final int EMULATED_SPECIAL_UP_DELAY_MS = 100;
 	private static final int EMULATED_SELECT_UP_DELAY_MS = 30;
 	
-	private Vector2d inputVector = new Vector2d();
+	private final Vector2d inputVector = new Vector2d();
 	
-	private HashMap<String, ControllerContext> contexts = new HashMap<String, ControllerContext>();
+	private final HashMap<String, ControllerContext> contexts = new HashMap<String, ControllerContext>();
 	
-	private NvConnection conn;
-    private double stickDeadzone;
+	private final NvConnection conn;
+    private final double stickDeadzone;
     private final ControllerContext defaultContext = new ControllerContext();
-    private GameGestures gestures;
+    private final GameGestures gestures;
     private boolean hasGameController;
 
-    private boolean multiControllerEnabled;
+    private final boolean multiControllerEnabled;
     private short currentControllers;
 	
 	public ControllerHandler(NvConnection conn, GameGestures gestures, boolean multiControllerEnabled, int deadzonePercentage) {

app/src/main/java/com/limelight/binding/input/KeyboardTranslator.java

@@ -15,7 +15,7 @@ public class KeyboardTranslator extends KeycodeTranslator {
 	/**
 	 * GFE's prefix for every key code
 	 */
-	public static final short KEY_PREFIX = (short) 0x80;
+	private static final short KEY_PREFIX = (short) 0x80;
 	
 	public static final int VK_0 = 48;
 	public static final int VK_9 = 57;

app/src/main/java/com/limelight/binding/input/TouchContext.java

@@ -11,9 +11,10 @@ public class TouchContext {
 	private long originalTouchTime = 0;
     private boolean cancelled;
 	
-	private NvConnection conn;
-	private int actionIndex;
-    private double xFactor, yFactor;
+	private final NvConnection conn;
+	private final int actionIndex;
+    private final double xFactor;
+    private final double yFactor;
 	
 	private static final int TAP_MOVEMENT_THRESHOLD = 10;
 	private static final int TAP_TIME_THRESHOLD = 250;

app/src/main/java/com/limelight/binding/input/evdev/EvdevEvent.java

@@ -29,9 +29,9 @@ public class EvdevEvent {
 	/* Keys */
 	public static final short KEY_Q = 16;
 	
-	public short type;
-	public short code;
-	public int value;
+	public final short type;
+	public final short code;
+	public final int value;
 	
 	public EvdevEvent(short type, short code, int value) {
 		this.type = type;

app/src/main/java/com/limelight/binding/input/evdev/EvdevHandler.java

@@ -7,12 +7,12 @@ import com.limelight.LimeLog;
 
 public class EvdevHandler {
 
-	private String absolutePath;
-	private EvdevListener listener;
+	private final String absolutePath;
+	private final EvdevListener listener;
 	private boolean shutdown = false;
 	private int fd = -1;
 	
-	private Thread handlerThread = new Thread() {
+	private final Thread handlerThread = new Thread() {
 		@Override
 		public void run() {
 			// All the finally blocks here make this code look like a mess

app/src/main/java/com/limelight/binding/input/evdev/EvdevTranslator.java

@@ -4,7 +4,7 @@ import android.view.KeyEvent;
 
 public class EvdevTranslator {
 
-	public static final short EVDEV_KEY_CODES[] = {
+	private static final short[] EVDEV_KEY_CODES = {
 		0, //KeyEvent.VK_RESERVED
 		KeyEvent.KEYCODE_ESCAPE,
 		KeyEvent.KEYCODE_1,

app/src/main/java/com/limelight/binding/video/AndroidCpuDecoderRenderer.java

@@ -36,7 +36,7 @@ public class AndroidCpuDecoderRenderer extends EnhancedDecoderRenderer {
 	private int totalFrames;
 	private long totalTimeMs;
 	
-	private int cpuCount = Runtime.getRuntime().availableProcessors();
+	private final int cpuCount = Runtime.getRuntime().availableProcessors();
 	
 	@SuppressWarnings("unused")
 	private int findOptimalPerformanceLevel() {

app/src/main/java/com/limelight/binding/video/MediaCodecDecoderRenderer.java

@@ -558,8 +558,8 @@ public class MediaCodecDecoderRenderer extends EnhancedDecoderRenderer {
     public class RendererException extends RuntimeException {
 		private static final long serialVersionUID = 8985937536997012406L;
 		
-		private Exception originalException;
-		private MediaCodecDecoderRenderer renderer;
+		private final Exception originalException;
+		private final MediaCodecDecoderRenderer renderer;
 		private ByteBuffer currentBuffer;
 		private int currentCodecFlags;
 		

app/src/main/java/com/limelight/binding/video/MediaCodecHelper.java

@@ -20,12 +20,12 @@ import com.limelight.LimeLog;
 
 public class MediaCodecHelper {
 	
-	public static final List<String> preferredDecoders;
+	private static final List<String> preferredDecoders;
 
-	public static final List<String> blacklistedDecoderPrefixes;
-	public static final List<String> spsFixupBitstreamFixupDecoderPrefixes;
-	public static final List<String> whitelistedAdaptiveResolutionPrefixes;
-    public static final List<String> baselineProfileHackPrefixes;
+	private static final List<String> blacklistedDecoderPrefixes;
+	private static final List<String> spsFixupBitstreamFixupDecoderPrefixes;
+	private static final List<String> whitelistedAdaptiveResolutionPrefixes;
+    private static final List<String> baselineProfileHackPrefixes;
 	
 	static {
 		preferredDecoders = new LinkedList<String>();
@@ -146,7 +146,7 @@ public class MediaCodecHelper {
 		return str;
 	}
 	
-	public static MediaCodecInfo findPreferredDecoder() {
+	private static MediaCodecInfo findPreferredDecoder() {
 		// This is a different algorithm than the other findXXXDecoder functions,
 		// because we want to evaluate the decoders in our list's order
 		// rather than MediaCodecList's order
@@ -217,7 +217,7 @@ public class MediaCodecHelper {
 	// since some bad decoders can throw IllegalArgumentExceptions unexpectedly
 	// and we want to be sure all callers are handling this possibility
 	@SuppressWarnings("RedundantThrows")
-    public static MediaCodecInfo findKnownSafeDecoder() throws Exception {
+    private static MediaCodecInfo findKnownSafeDecoder() throws Exception {
 		for (MediaCodecInfo codecInfo : getMediaCodecList()) {		
 			// Skip encoders
 			if (codecInfo.isEncoder()) {