From 8c910101c7554395c00d85b18be9023cc5d136ed Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Wed, 19 Feb 2020 23:53:44 -0800 Subject: [PATCH] Fix Lint errors on API level 16 --- app/src/main/java/com/limelight/Game.java | 4 +++- .../binding/video/MediaCodecHelper.java | 19 ++++++++++--------- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/app/src/main/java/com/limelight/Game.java b/app/src/main/java/com/limelight/Game.java index b5edee80..cbf2ac66 100644 --- a/app/src/main/java/com/limelight/Game.java +++ b/app/src/main/java/com/limelight/Game.java @@ -603,7 +603,9 @@ public class Game extends Activity implements SurfaceHolder.Callback, try { Field field = windowLayoutParams.getClass().getDeclaredField("preferMinimalPostProcessing"); field.set(windowLayoutParams, isPreferred); - } catch (NoSuchFieldException | IllegalAccessException e) { + } catch (NoSuchFieldException e) { + e.printStackTrace(); + } catch (IllegalAccessException e) { e.printStackTrace(); } } diff --git a/app/src/main/java/com/limelight/binding/video/MediaCodecHelper.java b/app/src/main/java/com/limelight/binding/video/MediaCodecHelper.java index 59b208a4..a7ede6e8 100644 --- a/app/src/main/java/com/limelight/binding/video/MediaCodecHelper.java +++ b/app/src/main/java/com/limelight/binding/video/MediaCodecHelper.java @@ -335,16 +335,17 @@ public class MediaCodecHelper { } public static boolean decoderSupportsLowLatency(MediaCodecInfo decoderInfo, String mimeType) { - try { - if (decoderInfo.getCapabilitiesForType(mimeType). - isFeatureSupported(FEATURE_LowLatency)) - { - LimeLog.info("Low latency decoding mode supported (FEATURE_LowLatency)"); - return true; + // KitKat added CodecCapabilities.isFeatureSupported() + if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) { + try { + if (decoderInfo.getCapabilitiesForType(mimeType).isFeatureSupported(FEATURE_LowLatency)) { + LimeLog.info("Low latency decoding mode supported (FEATURE_LowLatency)"); + return true; + } + } catch (Exception e) { + // Tolerate buggy codecs + e.printStackTrace(); } - } catch (Exception e) { - // Tolerate buggy codecs - e.printStackTrace(); } return false;