Use LiStringifyPortFlags() instead of coding it ourselves

app/src/main/java/com/limelight/nvstream/jni/MoonBridge.java

@@ -293,13 +293,11 @@ public class MoonBridge {
 
     public static native int testClientConnectivity(String testServerHostName, int referencePort, int testFlags);
 
-    public static native int getPortFromPortFlagIndex(int portFlagIndex);
-
-    public static native String getProtocolFromPortFlagIndex(int portFlagIndex);
-
     public static native int getPortFlagsFromStage(int stage);
 
     public static native int getPortFlagsFromTerminationErrorCode(int errorCode);
 
+    public static native String stringifyPortFlags(int portFlags, String separator);
+
     public static native void init();
 }

app/src/main/java/com/limelight/utils/ServerHelper.java

@@ -101,11 +101,7 @@ public class ServerHelper {
                 }
                 else {
                     dialogSummary = parent.getResources().getString(R.string.nettest_text_failure);
-                    for (int i = 0; i < 32; i++) {
+                    dialogSummary += MoonBridge.stringifyPortFlags(ret, "\n");
-                        if ((ret & (1 << i)) != 0) {
-                            dialogSummary += MoonBridge.getProtocolFromPortFlagIndex(i) + " " + MoonBridge.getPortFromPortFlagIndex(i) + "\n";
-                        }
-                    }
                 }
 
                 Dialog.displayDialog(parent,

app/src/main/jni/moonlight-core/simplejni.c

@@ -115,17 +115,6 @@ Java_com_limelight_nvstream_jni_MoonBridge_testClientConnectivity(JNIEnv *env, j
     return ret;
 }
 
-JNIEXPORT jint JNICALL
-Java_com_limelight_nvstream_jni_MoonBridge_getPortFromPortFlagIndex(JNIEnv *env, jclass clazz, jint portFlagIndex) {
-    return LiGetPortFromPortFlagIndex(portFlagIndex);
-}
-
-JNIEXPORT jstring JNICALL
-Java_com_limelight_nvstream_jni_MoonBridge_getProtocolFromPortFlagIndex(JNIEnv *env, jclass clazz, jint portFlagIndex) {
-    int protocol = LiGetProtocolFromPortFlagIndex(portFlagIndex);
-    return (*env)->NewStringUTF(env, protocol == IPPROTO_TCP ? "TCP" : "UDP");
-}
-
 JNIEXPORT jint JNICALL
 Java_com_limelight_nvstream_jni_MoonBridge_getPortFlagsFromStage(JNIEnv *env, jclass clazz, jint stage) {
     return LiGetPortFlagsFromStage(stage);
@@ -134,4 +123,15 @@ Java_com_limelight_nvstream_jni_MoonBridge_getPortFlagsFromStage(JNIEnv *env, jc
 JNIEXPORT jint JNICALL
 Java_com_limelight_nvstream_jni_MoonBridge_getPortFlagsFromTerminationErrorCode(JNIEnv *env, jclass clazz, jint errorCode) {
     return LiGetPortFlagsFromTerminationErrorCode(errorCode);
+}
+
+JNIEXPORT jstring JNICALL
+Java_com_limelight_nvstream_jni_MoonBridge_stringifyPortFlags(JNIEnv *env, jclass clazz, jint portFlags, jstring separator) {
+    const char* separatorStr = (*env)->GetStringUTFChars(env, separator, NULL);
+    char outputBuffer[512];
+
+    LiStringifyPortFlags(portFlags, separatorStr, outputBuffer, sizeof(outputBuffer));
+
+    (*env)->ReleaseStringUTFChars(env, separator, separatorStr);
+    return (*env)->NewStringUTF(env, outputBuffer);
 }