From 5af7d83ec1f0714947fb6d7c2fb038cfc8dcfd35 Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Wed, 19 Nov 2014 22:06:22 -0800 Subject: [PATCH] Fix RTL Lint warnings by using start/end --- app/src/main/res/layout-land/activity_pc_view.xml | 8 +++++++- app/src/main/res/layout-port/activity_pc_view.xml | 6 ++++++ .../main/res/layout/activity_add_computer_manually.xml | 2 ++ app/src/main/res/layout/activity_app_view.xml | 2 ++ app/src/main/res/layout/pc_grid_item.xml | 2 ++ 5 files changed, 19 insertions(+), 1 deletion(-) diff --git a/app/src/main/res/layout-land/activity_pc_view.xml b/app/src/main/res/layout-land/activity_pc_view.xml index e26a78ba..91169932 100644 --- a/app/src/main/res/layout-land/activity_pc_view.xml +++ b/app/src/main/res/layout-land/activity_pc_view.xml @@ -24,7 +24,9 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_toRightOf="@+id/pcs_loading" + android:layout_toEndOf="@+id/pcs_loading" android:layout_marginLeft="5dp" + android:layout_marginStart="5dp" android:layout_centerVertical="true" android:textAppearance="?android:attr/textAppearanceLarge" android:gravity="center" @@ -41,7 +43,9 @@ android:layout_alignParentBottom="true" android:layout_alignParentTop="true" android:layout_toLeftOf="@+id/manuallyAddPc" - android:layout_toRightOf="@+id/settingsButton"/> + android:layout_toStartOf="@+id/manuallyAddPc" + android:layout_toRightOf="@+id/settingsButton" + android:layout_toEndOf="@+id/settingsButton"/> diff --git a/app/src/main/res/layout-port/activity_pc_view.xml b/app/src/main/res/layout-port/activity_pc_view.xml index 138f6f44..e1480aae 100644 --- a/app/src/main/res/layout-port/activity_pc_view.xml +++ b/app/src/main/res/layout-port/activity_pc_view.xml @@ -24,7 +24,9 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_toRightOf="@+id/pcs_loading" + android:layout_toEndOf="@+id/pcs_loading" android:layout_marginLeft="5dp" + android:layout_marginStart="5dp" android:layout_centerVertical="true" android:textAppearance="?android:attr/textAppearanceLarge" android:gravity="center" @@ -39,7 +41,9 @@ android:columnWidth="160dp" android:gravity="center" android:layout_toLeftOf="@+id/manuallyAddPc" + android:layout_toStartOf="@+id/manuallyAddPc" android:layout_toRightOf="@+id/settingsButton" + android:layout_toEndOf="@+id/settingsButton" android:layout_alignParentBottom="true" android:layout_alignParentTop="true"/> @@ -50,6 +54,7 @@ android:cropToPadding="false" android:scaleType="fitXY" android:layout_alignParentLeft="true" + android:layout_alignParentStart="true" android:layout_alignParentTop="true" android:src="@drawable/settings" style="?android:attr/borderlessButtonStyle"/> @@ -61,6 +66,7 @@ android:cropToPadding="false" android:scaleType="fitXY" android:layout_alignParentTop="true" + android:layout_alignParentEnd="true" android:layout_alignParentRight="true" android:src="@drawable/add_computer" style="?android:attr/borderlessButtonStyle"/> diff --git a/app/src/main/res/layout/activity_add_computer_manually.xml b/app/src/main/res/layout/activity_add_computer_manually.xml index 696d0297..fcc46533 100644 --- a/app/src/main/res/layout/activity_add_computer_manually.xml +++ b/app/src/main/res/layout/activity_add_computer_manually.xml @@ -24,7 +24,9 @@ android:layout_below="@+id/manuallyAddPcText" android:layout_marginTop="25dp" android:layout_alignParentLeft="true" + android:layout_alignParentStart="true" android:layout_alignParentRight="true" + android:layout_alignParentEnd="true" android:ems="10" android:singleLine="true" android:inputType="textNoSuggestions" diff --git a/app/src/main/res/layout/activity_app_view.xml b/app/src/main/res/layout/activity_app_view.xml index f0cc7824..de65756e 100644 --- a/app/src/main/res/layout/activity_app_view.xml +++ b/app/src/main/res/layout/activity_app_view.xml @@ -17,7 +17,9 @@ android:stretchMode="spacingWidth" android:gravity="center" android:layout_alignParentLeft="true" + android:layout_alignParentStart="true" android:layout_alignParentRight="true" + android:layout_alignParentEnd="true" android:layout_alignParentBottom="true" android:layout_below="@+id/appListText"> diff --git a/app/src/main/res/layout/pc_grid_item.xml b/app/src/main/res/layout/pc_grid_item.xml index 8347e204..b5601395 100644 --- a/app/src/main/res/layout/pc_grid_item.xml +++ b/app/src/main/res/layout/pc_grid_item.xml @@ -17,7 +17,9 @@ android:id="@+id/grid_overlay" android:layout_marginTop="15dp" android:layout_marginLeft="65dp" + android:layout_marginStart="65dp" android:layout_marginRight="20dp" + android:layout_marginEnd="20dp" android:layout_width="50dp" android:layout_height="50dp">