Merge branch 'master' into virtualcontroller_master

Conflicts:
	app/app.iml
	app/build.gradle
	app/libs/limelight-common.jar
	app/src/main/java/com/limelight/Game.java
	app/src/main/java/com/limelight/binding/input/ControllerHandler.java
	app/src/main/java/com/limelight/binding/video/MediaCodecHelper.java
	app/src/main/java/com/limelight/computers/ComputerDatabaseManager.java
	app/src/main/java/com/limelight/preferences/PreferenceConfiguration.java
	app/src/main/jni/evdev_reader/evdev_reader.c
	app/src/main/res/xml/preferences.xml
	limelight-android.iml
	limelight_vc.iml
	moonlight-android.iml

app/app.iml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<module external.linked.project.id=":app" external.linked.project.path="$MODULE_DIR$" external.root.project.path="$MODULE_DIR$/.." external.system.id="GRADLE" external.system.module.group="moonlight-new" external.system.module.version="unspecified" type="JAVA_MODULE" version="4">
+<module external.linked.project.id=":app" external.linked.project.path="$MODULE_DIR$" external.root.project.path="$MODULE_DIR$/.." external.system.id="GRADLE" external.system.module.group="moonlight-android" external.system.module.version="unspecified" type="JAVA_MODULE" version="4">
   <component name="FacetManager">
     <facet type="android-gradle" name="Android-Gradle">
       <configuration>
@@ -85,30 +85,36 @@
       <sourceFolder url="file://$MODULE_DIR$/src/androidTest/jni" isTestSource="true" />
       <sourceFolder url="file://$MODULE_DIR$/src/androidTest/rs" isTestSource="true" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/assets" />
+      <excludeFolder url="file://$MODULE_DIR$/build/intermediates/bundles" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/classes" />
+      <excludeFolder url="file://$MODULE_DIR$/build/intermediates/coverage-instrumented-classes" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/dependency-cache" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/dex" />
+      <excludeFolder url="file://$MODULE_DIR$/build/intermediates/dex-cache" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/incremental" />
+      <excludeFolder url="file://$MODULE_DIR$/build/intermediates/jacoco" />
+      <excludeFolder url="file://$MODULE_DIR$/build/intermediates/javaResources" />
+      <excludeFolder url="file://$MODULE_DIR$/build/intermediates/libs" />
+      <excludeFolder url="file://$MODULE_DIR$/build/intermediates/lint" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/manifests" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/ndk" />
-      <excludeFolder url="file://$MODULE_DIR$/build/intermediates/nonRootDebug" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/pre-dexed" />
+      <excludeFolder url="file://$MODULE_DIR$/build/intermediates/proguard" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/res" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/rs" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/symbols" />
-      <excludeFolder url="file://$MODULE_DIR$/build/intermediates/tmp" />
       <excludeFolder url="file://$MODULE_DIR$/build/outputs" />
       <excludeFolder url="file://$MODULE_DIR$/build/tmp" />
     </content>
     <orderEntry type="jdk" jdkName="Android API 23 Platform" jdkType="Android SDK" />
     <orderEntry type="sourceFolder" forTests="false" />
-    <orderEntry type="library" exported="" name="okhttp-2.4.0" level="project" />
     <orderEntry type="library" exported="" name="bcprov-jdk15on-1.52" level="project" />
-    <orderEntry type="library" exported="" name="jmdns-3.4.2" level="project" />
+    <orderEntry type="library" exported="" name="bcpkix-jdk15on-1.52" level="project" />
-    <orderEntry type="library" exported="" name="okio-1.5.0" level="project" />
-    <orderEntry type="library" exported="" name="jcodec-0.1.9-patched" level="project" />
     <orderEntry type="library" exported="" name="tinyrtsp" level="project" />
     <orderEntry type="library" exported="" name="limelight-common" level="project" />
-    <orderEntry type="library" exported="" name="bcpkix-jdk15on-1.52" level="project" />
+    <orderEntry type="library" exported="" name="jmdns-3.4.2" level="project" />
+    <orderEntry type="library" exported="" name="okhttp-2.4.0" level="project" />
+    <orderEntry type="library" exported="" name="jcodec-0.1.9-patched" level="project" />
+    <orderEntry type="library" exported="" name="okio-1.5.0" level="project" />
   </component>
 </module>

app/build.gradle

@@ -11,8 +11,8 @@ android {
         minSdkVersion 16
         targetSdkVersion 23
 
-        versionName "4.0.2"
+        versionName "4.0.3"
-        versionCode = 79
+        versionCode = 81
     }
 
     productFlavors {

app/src/main/java/com/limelight/Game.java

@@ -369,8 +369,10 @@ public class Game extends Activity implements SurfaceHolder.Callback,
         SpinnerDialog.closeDialogs(this);
         Dialog.closeDialogs();
 
-        InputManager inputManager = (InputManager) getSystemService(Context.INPUT_SERVICE);
+        if (controllerHandler != null) {
-        inputManager.unregisterInputDeviceListener(controllerHandler);
+            InputManager inputManager = (InputManager) getSystemService(Context.INPUT_SERVICE);
+            inputManager.unregisterInputDeviceListener(controllerHandler);
+        }
 
         wifiLock.release();
 
@@ -379,36 +381,38 @@ public class Game extends Activity implements SurfaceHolder.Callback,
             unbindService(usbDriverServiceConnection);
         }
 
-        VideoDecoderRenderer.VideoFormat videoFormat = conn.getActiveVideoFormat();
+        if (conn != null) {
+            VideoDecoderRenderer.VideoFormat videoFormat = conn.getActiveVideoFormat();
 
-        displayedFailureDialog = true;
+            displayedFailureDialog = true;
-        stopConnection();
+            stopConnection();
 
-        int averageEndToEndLat = decoderRenderer.getAverageEndToEndLatency();
+            int averageEndToEndLat = decoderRenderer.getAverageEndToEndLatency();
-        int averageDecoderLat = decoderRenderer.getAverageDecoderLatency();
+            int averageDecoderLat = decoderRenderer.getAverageDecoderLatency();
-        String message = null;
+            String message = null;
-        if (averageEndToEndLat > 0) {
+            if (averageEndToEndLat > 0) {
-            message = getResources().getString(R.string.conn_client_latency)+" "+averageEndToEndLat+" ms";
+                message = getResources().getString(R.string.conn_client_latency)+" "+averageEndToEndLat+" ms";
-            if (averageDecoderLat > 0) {
+                if (averageDecoderLat > 0) {
-                message += " ("+getResources().getString(R.string.conn_client_latency_hw)+" "+averageDecoderLat+" ms)";
+                    message += " ("+getResources().getString(R.string.conn_client_latency_hw)+" "+averageDecoderLat+" ms)";
+                }
             }
-        }
+            else if (averageDecoderLat > 0) {
-        else if (averageDecoderLat > 0) {
+                message = getResources().getString(R.string.conn_hardware_latency)+" "+averageDecoderLat+" ms";
-            message = getResources().getString(R.string.conn_hardware_latency)+" "+averageDecoderLat+" ms";
-        }
-
-        // Add the video codec to the post-stream toast
-        if (message != null && videoFormat != VideoDecoderRenderer.VideoFormat.Unknown) {
-            if (videoFormat == VideoDecoderRenderer.VideoFormat.H265) {
-                message += " [H.265]";
             }
-            else {
-                message += " [H.264]";
-            }
-        }
 
-        if (message != null) {
+            // Add the video codec to the post-stream toast
-            Toast.makeText(this, message, Toast.LENGTH_LONG).show();
+            if (message != null && videoFormat != VideoDecoderRenderer.VideoFormat.Unknown) {
+                if (videoFormat == VideoDecoderRenderer.VideoFormat.H265) {
+                    message += " [H.265]";
+                }
+                else {
+                    message += " [H.264]";
+                }
+            }
+
+            if (message != null) {
+                Toast.makeText(this, message, Toast.LENGTH_LONG).show();
+            }
         }
 
         finish();

app/src/main/java/com/limelight/binding/input/ControllerHandler.java

@@ -362,7 +362,7 @@ public class ControllerHandler implements InputManager.InputDeviceListener, UsbD
             }
             // Samsung's face buttons appear as a non-virtual button so we'll explicitly ignore
             // back presses on this device
-            else if (devName.equals("sec_touchscreen")) {
+            else if (devName.equals("sec_touchscreen") || devName.equals("sec_touchkey")) {
                 context.ignoreBack = true;
             }
             // The Serval has a couple of unknown buttons that are start and select. It also has

app/src/main/java/com/limelight/binding/video/MediaCodecHelper.java

@@ -76,14 +76,31 @@ public class MediaCodecHelper {
 
 		constrainedHighProfilePrefixes = new LinkedList<String>();
 		constrainedHighProfilePrefixes.add("omx.intel");
+	}
 
+	static {
 		whitelistedHevcDecoders = new LinkedList<>();
+
+		// Exynos seems to be the only HEVC decoder that works reliably
 		whitelistedHevcDecoders.add("omx.exynos");
-		// whitelistedHevcDecoders.add("omx.nvidia"); TODO: This needs a similar fixup to the Tegra 3
+
-		whitelistedHevcDecoders.add("omx.mtk");
+		// TODO: This needs a similar fixup to the Tegra 3 otherwise it buffers 16 frames
-		whitelistedHevcDecoders.add("omx.amlogic");
+		//whitelistedHevcDecoders.add("omx.nvidia");
-		whitelistedHevcDecoders.add("omx.rk");
+
-		// omx.qcom added conditionally during initialization
+		// Sony ATVs have broken MediaTek codecs (decoder hangs after rendering the first frame).
+		// I know the Fire TV 2 works, so I'll just whitelist Amazon devices which seem
+		// to actually be tested. Ugh...
+		if (Build.MANUFACTURER.equalsIgnoreCase("Amazon")) {
+			whitelistedHevcDecoders.add("omx.mtk");
+		}
+
+		// These theoretically have good HEVC decoding capabilities (potentially better than
+		// their AVC decoders), but haven't been tested enough
+		//whitelistedHevcDecoders.add("omx.amlogic");
+		//whitelistedHevcDecoders.add("omx.rk");
+
+		// Based on GPU attributes queried at runtime, the omx.qcom prefix will be added
+		// during initialization to avoid SoCs with broken HEVC decoders.
 	}
 
 	public static void initializeWithContext(Context context) {

app/src/main/java/com/limelight/computers/ComputerDatabaseManager.java

@@ -53,7 +53,7 @@ public class ComputerDatabaseManager {
     }
 
     public void deleteComputer(String name) {
-        computerDb.delete(COMPUTER_TABLE_NAME, COMPUTER_NAME_COLUMN_NAME+"='"+name+"'", null);
+        computerDb.delete(COMPUTER_TABLE_NAME, COMPUTER_NAME_COLUMN_NAME+"=?", new String[]{name});
     }
 
     public boolean updateComputer(ComputerDetails details) {
@@ -118,7 +118,7 @@ public class ComputerDatabaseManager {
     }
 
     public ComputerDetails getComputerByName(String name) {
-        Cursor c = computerDb.rawQuery("SELECT * FROM "+COMPUTER_TABLE_NAME+" WHERE "+COMPUTER_NAME_COLUMN_NAME+"='"+name+"'", null);
+        Cursor c = computerDb.query(COMPUTER_TABLE_NAME, null, COMPUTER_NAME_COLUMN_NAME+"=?", new String[]{name}, null, null, null);
         ComputerDetails details = new ComputerDetails();
         if (!c.moveToFirst()) {
             // No matching computer

app/src/main/jni/evdev_reader/evdev_reader.c

@@ -14,6 +14,8 @@
 
 #include <android/log.h>
 
+#define EVDEV_MAX_EVENT_SIZE 24
+
 #define REL_X 0x00
 #define REL_Y 0x01
 #define KEY_Q 16
@@ -69,7 +71,7 @@ void* pollThreadFunc(void* context) {
     struct DeviceEntry *device = context;
     struct pollfd pollinfo;
     int pollres, ret;
-    char data[64];
+    char data[EVDEV_MAX_EVENT_SIZE];
 
     __android_log_print(ANDROID_LOG_INFO, "EvdevReader", "Polling /dev/input/%s", device->devName);
 
@@ -94,7 +96,7 @@ void* pollThreadFunc(void* context) {
 
         if (pollres > 0 && (pollinfo.revents & POLLIN)) {
             // We'll have data available now
-            ret = read(device->fd, data, sizeof(struct input_event));
+            ret = read(device->fd, data, EVDEV_MAX_EVENT_SIZE);
             if (ret < 0) {
                 __android_log_print(ANDROID_LOG_ERROR, "EvdevReader",
                                     "read() failed: %d", errno);
@@ -132,6 +134,9 @@ cleanup:
     {
         struct DeviceEntry *lastEntry;
 
+        // Lock the device list
+        pthread_mutex_lock(&DeviceListLock);
+
         if (DeviceListHead == device) {
             DeviceListHead = device->next;
         }
@@ -146,6 +151,9 @@ cleanup:
                 lastEntry = lastEntry->next;
             }
         }
+
+        // Unlock device list
+        pthread_mutex_unlock(&DeviceListLock);
     }
 
     // Free the context
@@ -254,6 +262,11 @@ static int enumerateDevices(void) {
             continue;
         }
 
+        if (strstr(dirEnt->d_name, "event") == NULL) {
+            // Skip non-event devices
+            continue;
+        }
+
         startPollForDevice(dirEnt->d_name);
     }
 
@@ -269,6 +282,8 @@ int main(int argc, char* argv[]) {
     int pollres;
     struct pollfd pollinfo;
 
+    __android_log_print(ANDROID_LOG_INFO, "EvdevReader", "Entered main()");
+
     // Perform initial enumeration
     ret = enumerateDevices();
     if (ret < 0) {
@@ -293,33 +308,49 @@ int main(int argc, char* argv[]) {
         }
         while (pollres == 0);
 
-        ret = fread(&requestId, sizeof(requestId), 1, stdin);
+        if (pollres > 0 && (pollinfo.revents & POLLIN)) {
-        if (ret < sizeof(requestId)) {
+            // We'll have data available now
-            __android_log_print(ANDROID_LOG_ERROR, "EvdevReader", "Short read on input");
+            ret = fread(&requestId, sizeof(requestId), 1, stdin);
-            return errno;
+            if (ret < sizeof(requestId)) {
-        }
+                __android_log_print(ANDROID_LOG_ERROR, "EvdevReader", "Short read on input");
-
+                return errno;
-        if (requestId != UNGRAB_REQ && requestId != REGRAB_REQ) {
-            __android_log_print(ANDROID_LOG_ERROR, "EvdevReader", "Unknown request");
-            return requestId;
-        }
-
-        {
-            struct DeviceEntry *currentEntry;
-
-            pthread_mutex_lock(&DeviceListLock);
-
-            // Update state for future devices
-            grabbing = (requestId == REGRAB_REQ);
-
-            // Carry out the requested action on each device
-            currentEntry = DeviceListHead;
-            while (currentEntry != NULL) {
-                ioctl(currentEntry->fd, EVIOCGRAB, grabbing);
-                currentEntry = currentEntry->next;
             }
 
-            pthread_mutex_unlock(&DeviceListLock);
+            if (requestId != UNGRAB_REQ && requestId != REGRAB_REQ) {
+                __android_log_print(ANDROID_LOG_ERROR, "EvdevReader", "Unknown request");
+                return requestId;
+            }
+
+            {
+                struct DeviceEntry *currentEntry;
+
+                pthread_mutex_lock(&DeviceListLock);
+
+                // Update state for future devices
+                grabbing = (requestId == REGRAB_REQ);
+
+                // Carry out the requested action on each device
+                currentEntry = DeviceListHead;
+                while (currentEntry != NULL) {
+                    ioctl(currentEntry->fd, EVIOCGRAB, grabbing);
+                    currentEntry = currentEntry->next;
+                }
+
+                pthread_mutex_unlock(&DeviceListLock);
+            }
+        }
+        else {
+            // Terminate this thread
+            if (pollres < 0) {
+                __android_log_print(ANDROID_LOG_ERROR, "EvdevReader",
+                                    "Stdin poll() failed: %d", errno);
+            }
+            else {
+                __android_log_print(ANDROID_LOG_ERROR, "EvdevReader",
+                                    "Stdin unexpected revents: %d", pollinfo.revents);
+            }
+
+            return -1;
         }
     }
 }

limelight_vc.iml

@@ -1,21 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<module external.linked.project.path="$MODULE_DIR$" external.root.project.path="$MODULE_DIR$" external.system.id="GRADLE" type="JAVA_MODULE" version="4">
-  <component name="FacetManager">
-    <facet type="java-gradle" name="Java-Gradle">
-      <configuration>
-        <option name="BUILD_FOLDER_PATH" value="$MODULE_DIR$/build" />
-      </configuration>
-    </facet>
-  </component>
-  <component name="NewModuleRootManager" inherit-compiler-output="false">
-    <output url="file://$MODULE_DIR$/build/classes/main" />
-    <output-test url="file://$MODULE_DIR$/build/classes/test" />
-    <exclude-output />
-    <content url="file://$MODULE_DIR$">
-      <excludeFolder url="file://$MODULE_DIR$/.gradle" />
-    </content>
-    <orderEntry type="inheritedJdk" />
-    <orderEntry type="sourceFolder" forTests="false" />
-  </component>
-</module>
-