mirrors/Terra
1
0
Fork 0
mirror of https://github.com/PolyhedralDev/Terra.git synced 2026-06-17 14:21:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optimize logging statements to avoid string concatenation

Browse Source 
Signed-off-by: solonovamax <solonovamax@12oclockpoint.com>
This commit is contained in:
solonovamax
2021-11-23 15:13:50 -05:00
parent 92046fe345
commit 2b2255a590
3 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/addons/manifest-addon-loader/src/main/java/com/dfsek/terra/addons/manifest/impl/ManifestAddon.java
+11 -12
View File
@@ -7,11 +7,13 @@
package com.dfsek.terra.addons.manifest.impl; package com.dfsek.terra.addons.manifest.impl;
import java.util.List;
import java.util.Map;
import ca.solostudios.strata.version.Version; import ca.solostudios.strata.version.Version;
import ca.solostudios.strata.version.VersionRange; import ca.solostudios.strata.version.VersionRange;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import java.util.List;
import java.util.Map;
import com.dfsek.terra.addons.manifest.api.AddonInitializer; import com.dfsek.terra.addons.manifest.api.AddonInitializer;
import com.dfsek.terra.addons.manifest.impl.config.AddonManifest; import com.dfsek.terra.addons.manifest.impl.config.AddonManifest;
@@ -20,9 +22,6 @@ import com.dfsek.terra.api.addon.BaseAddon;
import com.dfsek.terra.api.inject.Injector; import com.dfsek.terra.api.inject.Injector;
import com.dfsek.terra.api.inject.annotations.Inject; import com.dfsek.terra.api.inject.annotations.Inject;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
public class ManifestAddon implements BaseAddon { public class ManifestAddon implements BaseAddon {
private final AddonManifest manifest; private final AddonManifest manifest;
@@ -32,7 +31,7 @@ public class ManifestAddon implements BaseAddon {
@Inject @Inject
private Platform platform; private Platform platform;
private static final Logger LOGGER = LoggerFactory.getLogger(ManifestAddon.class); private static final Logger logger = LoggerFactory.getLogger(ManifestAddon.class);
public ManifestAddon(AddonManifest manifest, List<AddonInitializer> initializers) { public ManifestAddon(AddonManifest manifest, List<AddonInitializer> initializers) {
this.manifest = manifest; this.manifest = manifest;
@@ -47,14 +46,14 @@ public class ManifestAddon implements BaseAddon {
public void initialize() { public void initialize() {
Injector<BaseAddon> addonInjector = Injector.get(this); Injector<BaseAddon> addonInjector = Injector.get(this);
addonInjector.addExplicitTarget(BaseAddon.class); addonInjector.addExplicitTarget(BaseAddon.class);
Injector<Platform> platformInjector = Injector.get(platform); Injector<Platform> platformInjector = Injector.get(platform);
platformInjector.addExplicitTarget(Platform.class); platformInjector.addExplicitTarget(Platform.class);
LOGGER.info("Initializing addon " + getID()); logger.info("Initializing addon {}", getID());
initializers.forEach(initializer -> { initializers.forEach(initializer -> {
LOGGER.debug("Invoking entry point {}", initializer.getClass()); logger.debug("Invoking entry point {}", initializer.getClass());
addonInjector.inject(initializer); addonInjector.inject(initializer);
platformInjector.inject(initializer); platformInjector.inject(initializer);
initializer.initialize(); initializer.initialize();
common/implementation/base/src/main/java/com/dfsek/terra/config/pack/ConfigPackImpl.java
+1 -1
View File
@@ -201,7 +201,7 @@ public class ConfigPackImpl implements ConfigPack {
selfLoader.load(template, configuration); selfLoader.load(template, configuration);
logger.info("Loading config pack \"" + template.getID() + "\""); logger.info("Loading config pack \"{}\"", template.getID());
load(l, platform); load(l, platform);
common/implementation/base/src/main/java/com/dfsek/terra/registry/master/ConfigRegistry.java
+1 -1
View File
@@ -56,7 +56,7 @@ public class ConfigRegistry extends OpenRegistryImpl<ConfigPack> {
} }
for(File zip : packsFolder.listFiles(file -> file.getName().endsWith(".zip") || file.getName().endsWith(".terra"))) { for(File zip : packsFolder.listFiles(file -> file.getName().endsWith(".zip") || file.getName().endsWith(".terra"))) {
try { try {
logger.info("Loading ZIP archive: " + zip.getName()); logger.info("Loading ZIP archive: {}", zip.getName());
load(new ZipFile(zip), platform); load(new ZipFile(zip), platform);
} catch(IOException | ConfigException e) { } catch(IOException | ConfigException e) {
logger.error("Error loading config pack {}", zip.getName(), e); logger.error("Error loading config pack {}", zip.getName(), e);