From 1b4824c5db6b67baa186847b10eb0d6bbb7cadd8 Mon Sep 17 00:00:00 2001 From: Mirai Date: Sun, 2 Mar 2025 09:57:48 +0200 Subject: [PATCH] fix crash chunk generate column in generate chunk process The change removes the subtraction of one from properties.getMinHeight(), fixing a crash on version 1.21.4. --- .../terra/bukkit/nms/v1_21_3/NMSChunkGeneratorDelegate.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platforms/bukkit/nms/v1_21_3/src/main/java/com/dfsek/terra/bukkit/nms/v1_21_3/NMSChunkGeneratorDelegate.java b/platforms/bukkit/nms/v1_21_3/src/main/java/com/dfsek/terra/bukkit/nms/v1_21_3/NMSChunkGeneratorDelegate.java index 4df28da50..a8a8d21d1 100644 --- a/platforms/bukkit/nms/v1_21_3/src/main/java/com/dfsek/terra/bukkit/nms/v1_21_3/NMSChunkGeneratorDelegate.java +++ b/platforms/bukkit/nms/v1_21_3/src/main/java/com/dfsek/terra/bukkit/nms/v1_21_3/NMSChunkGeneratorDelegate.java @@ -155,7 +155,7 @@ public class NMSChunkGeneratorDelegate extends ChunkGenerator { BlockState[] array = new BlockState[world.getHeight()]; WorldProperties properties = new NMSWorldProperties(seed, world); BiomeProvider biomeProvider = pack.getBiomeProvider(); - for(int y = properties.getMaxHeight() - 1; y >= properties.getMinHeight(); y--) { + for(int y = properties.getMaxHeight(); y >= properties.getMinHeight(); y--) { array[y - properties.getMinHeight()] = ((CraftBlockData) delegate.getBlock(properties, x, y, z, biomeProvider) .getHandle()).getState(); }