From 0ab463f34f27630c2c4b1a8c365d2c6c4d0d0035 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zo=C3=AB=20Gidiere?= <duplexsys@protonmail.com>
Date: Sun, 5 Nov 2023 21:07:25 -0700
Subject: [PATCH] bukkit clean up

---
 .../dfsek/terra/bukkit/TerraBukkitPlugin.java | 38 +++++++++++--------
 1 file changed, 22 insertions(+), 16 deletions(-)

diff --git a/platforms/bukkit/common/src/main/java/com/dfsek/terra/bukkit/TerraBukkitPlugin.java b/platforms/bukkit/common/src/main/java/com/dfsek/terra/bukkit/TerraBukkitPlugin.java
index a33393cfd..2d3c2e0ee 100644
--- a/platforms/bukkit/common/src/main/java/com/dfsek/terra/bukkit/TerraBukkitPlugin.java
+++ b/platforms/bukkit/common/src/main/java/com/dfsek/terra/bukkit/TerraBukkitPlugin.java
@@ -63,21 +63,7 @@ public class TerraBukkitPlugin extends JavaPlugin {
         
         
         try {
-            PaperCommandManager<CommandSender> commandManager = new PaperCommandManager<>(this,
-                                                                                          CommandExecutionCoordinator.simpleCoordinator(),
-                                                                                          BukkitAdapter::adapt,
-                                                                                          BukkitAdapter::adapt);
-            if(commandManager.queryCapability(CloudBukkitCapabilities.NATIVE_BRIGADIER)) {
-                commandManager.registerBrigadier();
-                final CloudBrigadierManager<?, ?> brigManager = commandManager.brigadierManager();
-                if(brigManager != null) {
-                    brigManager.setNativeNumberSuggestions(false);
-                }
-            }
-            
-            if(commandManager.queryCapability(CloudBukkitCapabilities.ASYNCHRONOUS_COMPLETION)) {
-                commandManager.registerAsynchronousCompletions();
-            }
+            PaperCommandManager<CommandSender> commandManager = getCommandSenderPaperCommandManager();
             
             platform.getEventManager().callEvent(new CommandRegistrationEvent(commandManager));
             
@@ -98,6 +84,26 @@ public class TerraBukkitPlugin extends JavaPlugin {
         Initializer.init(platform);
     }
     
+    @NotNull
+    private PaperCommandManager<CommandSender> getCommandSenderPaperCommandManager() throws Exception {
+        PaperCommandManager<CommandSender> commandManager = new PaperCommandManager<>(this,
+                                                                                      CommandExecutionCoordinator.simpleCoordinator(),
+                                                                                      BukkitAdapter::adapt,
+                                                                                      BukkitAdapter::adapt);
+        if(commandManager.hasCapability(CloudBukkitCapabilities.NATIVE_BRIGADIER)) {
+            commandManager.registerBrigadier();
+            final CloudBrigadierManager<?, ?> brigManager = commandManager.brigadierManager();
+            if(brigManager != null) {
+                brigManager.setNativeNumberSuggestions(false);
+            }
+        }
+        
+        if(commandManager.hasCapability(CloudBukkitCapabilities.ASYNCHRONOUS_COMPLETION)) {
+            commandManager.registerAsynchronousCompletions();
+        }
+        return commandManager;
+    }
+    
     public PlatformImpl getPlatform() {
         return platform;
     }
@@ -153,7 +159,7 @@ public class TerraBukkitPlugin extends JavaPlugin {
                                  """.strip());
                 };
                 runnable.run();
-                getFoliaLib().getImpl().runLaterAsync(runnable, 200L);
+                foliaLib.getImpl().runLaterAsync(runnable, 200L);
                 // Bukkit.shutdown(); // we're not *that* evil
                 Bukkit.getPluginManager().disablePlugin(this);
                 return false;