Fixed Structure Crash

- Don't carash anymore when you disable structures in the server.properties.

adapters/modded-common/src/test/java/art/arcane/iris/modded/ModdedBindFailureTest.java

@@ -57,8 +57,11 @@ public class ModdedBindFailureTest {
         when(server.generateStructures()).thenReturn(false);
 
         try (MockedStatic<NativeModdedServer> servers = mockStatic(NativeModdedServer.class);
+             MockedStatic<ModdedWorldEngines> engines = mockStatic(ModdedWorldEngines.class);
              MockedStatic<ModdedIrisLog> log = mockStatic(ModdedIrisLog.class)) {
             servers.when(() -> NativeModdedServer.forWorld(level)).thenReturn(server);
+            engines.when(() -> ModdedWorldEngines.get(eq(level), any(), any(), anyLong(), any()))
+                    .thenThrow(new IllegalStateException("broken world binding"));
 
             IllegalStateException recorded = assertThrows(IllegalStateException.class, () -> generator.bindLevel(level));
             IllegalStateException second = assertThrows(IllegalStateException.class, generator::engine);
@@ -66,9 +69,9 @@ public class ModdedBindFailureTest {
 
             assertSame(recorded, second.getCause());
             assertSame(recorded, third.getCause());
-            servers.verify(() -> NativeModdedServer.forWorld(level), times(1));
+            engines.verify(() -> ModdedWorldEngines.get(eq(level), any(), any(), anyLong(), any()), times(1));
             log.verify(() -> ModdedIrisLog.error(argThat((String line) -> line != null && line.startsWith("Cause: ")
-                    && line.contains("generate-structures=false"))), times(1));
+                    && line.contains("broken world binding"))), times(1));
         }
     }
 
@@ -117,13 +120,15 @@ public class ModdedBindFailureTest {
              MockedStatic<ModdedWorldEngines> engines = mockStatic(ModdedWorldEngines.class);
              MockedStatic<ModdedIrisLog> log = mockStatic(ModdedIrisLog.class)) {
             servers.when(() -> NativeModdedServer.forWorld(level)).thenReturn(server);
+            engines.when(() -> ModdedWorldEngines.get(eq(level), any(), any(), anyLong(), any()))
+                    .thenAnswer(invocation -> { throw new IllegalStateException("broken world binding"); });
 
             IllegalStateException first = assertThrows(IllegalStateException.class, () -> generator.bindLevel(level));
             generator.unbindEngine(level);
             IllegalStateException second = assertThrows(IllegalStateException.class, () -> generator.bindLevel(level));
 
             assertNotSame(first, second.getCause());
-            servers.verify(() -> NativeModdedServer.forWorld(level), times(2));
+            engines.verify(() -> ModdedWorldEngines.get(eq(level), any(), any(), anyLong(), any()), times(2));
             engines.verify(() -> ModdedWorldEngines.evictOrThrow(level));
         }
     }

adapters/modded-common/src/test/java/art/arcane/iris/modded/ModdedStructureBindingOrderTest.java

@@ -37,7 +37,7 @@ public class ModdedStructureBindingOrderTest {
     }
 
     @Test
-    public void initialBindingPublishesReadyEngineBeforeStartingStructureSearches() throws Exception {
+    public void disabledStructuresAllowInitialBindingBeforeStartingStructureSearches() throws Exception {
         NativeModdedChunkGenerator<?, ?, ?> nativeGenerator = mock(NativeModdedChunkGenerator.class);
         ModdedEngineBinding<Engine> binding = new ModdedEngineBinding<>(1L, TimeUnit.MILLISECONDS);
         IrisModdedChunkGenerator generator = generator(nativeGenerator, binding);
@@ -45,7 +45,7 @@ public class ModdedStructureBindingOrderTest {
         NativeModdedServer server = mock(NativeModdedServer.class);
         Engine engine = readyEngine();
         when(nativeGenerator.represents(world)).thenReturn(true);
-        when(server.generateStructures()).thenReturn(true);
+        when(server.generateStructures()).thenReturn(false);
         doAnswer(invocation -> {
             assertSame(engine, generator.awaitStructureEngine());
             assertSame(engine, binding.await("overworld"));
@@ -88,7 +88,7 @@ public class ModdedStructureBindingOrderTest {
     }
 
     @Test
-    public void repointPublishesReplacementBindingBeforeStartingStructureSearches() throws Exception {
+    public void disabledStructuresAllowReplacementBindingBeforeStartingStructureSearches() throws Exception {
         NativeModdedChunkGenerator<?, ?, ?> nativeGenerator = mock(NativeModdedChunkGenerator.class);
         ModdedEngineBinding<Engine> binding = new ModdedEngineBinding<>(1L, TimeUnit.MILLISECONDS);
         IrisModdedChunkGenerator generator = generator(nativeGenerator, binding);
@@ -96,7 +96,7 @@ public class ModdedStructureBindingOrderTest {
         NativeModdedServer server = mock(NativeModdedServer.class);
         Engine replacement = readyEngine();
         when(nativeGenerator.represents(world)).thenReturn(true);
-        when(server.generateStructures()).thenReturn(true);
+        when(server.generateStructures()).thenReturn(false);
         doAnswer(invocation -> {
             assertSame(replacement, generator.awaitStructureEngine());
             assertSame(replacement, binding.await("overworld"));

adapters/modded-common/src/test/java/art/arcane/iris/modded/NativeStructureFailureContractTest.java

@@ -7,7 +7,6 @@ import org.junit.BeforeClass;
 import org.junit.Test;
 
 import static org.junit.Assert.assertSame;
-import static org.junit.Assert.assertThrows;
 import static org.junit.Assert.assertTrue;
 
 public class NativeStructureFailureContractTest {
@@ -17,21 +16,6 @@ public class NativeStructureFailureContractTest {
         Bootstrap.bootStrap();
     }
 
-    @Test
-    public void globalStructureDisableRefusesGeneratorBinding() {
-        IrisModdedChunkGenerator.requireGlobalStructureGeneration(true, "overworld:overworld");
-
-        IllegalStateException error = assertThrows(
-                IllegalStateException.class,
-                () -> IrisModdedChunkGenerator.requireGlobalStructureGeneration(
-                        false, "overworld:overworld"));
-
-        assertTrue(error.getMessage().contains("overworld:overworld"));
-        assertTrue(error.getMessage().contains("generate-structures=false"));
-        assertTrue(error.getMessage().contains("importedStructures.disabled"));
-        assertTrue(error.getMessage().contains("importedStructures.disabledExact"));
-    }
-
     @Test
     public void structureFailurePreservesPhaseIdentityChunkAndCause() {
         IllegalArgumentException cause = new IllegalArgumentException("broken placement");