This commit is contained in:
Brian Neumann-Fopiano
2026-08-05 02:28:14 -06:00
parent cd217c05f9
commit a66cba6418
5 changed files with 37 additions and 6 deletions
@@ -975,8 +975,7 @@ public class CommandIris implements DirectorExecutor {
try {
IrisData data = IrisData.get(pack);
for (String key : data.getDimensionLoader().getPossibleKeys()) {
options.add(key);
options.add(pack.getName() + ":" + key);
options.add(packDimensionOption(pack.getName(), key));
}
} catch (Throwable ex) {
Iris.warn("Failed to read dimension keys from pack %s: %s%s",
@@ -990,6 +989,12 @@ public class CommandIris implements DirectorExecutor {
return new KList<>(options);
}
static String packDimensionOption(String packName, String dimensionKey) {
return packName.equalsIgnoreCase(dimensionKey)
? packName
: packName + ":" + dimensionKey;
}
@Override
public String toString(String value) {
return value == null ? "" : value;
@@ -0,0 +1,21 @@
package art.arcane.iris.core.commands;
import org.junit.Test;
import static org.junit.Assert.assertEquals;
public class CommandIrisPackDimensionTypeHandlerTest {
@Test
public void matchingPackAndDimensionUsesBarePackName() {
assertEquals("overworld",
CommandIris.PackDimensionTypeHandler.packDimensionOption("overworld", "overworld"));
assertEquals("OverWorld",
CommandIris.PackDimensionTypeHandler.packDimensionOption("OverWorld", "overworld"));
}
@Test
public void differingDimensionUsesExplicitPackReference() {
assertEquals("custom_pack:dimensions/sky",
CommandIris.PackDimensionTypeHandler.packDimensionOption("custom_pack", "dimensions/sky"));
}
}