diff --git a/core/src/main/java/art/arcane/iris/generation/biome/IrisBiome.java b/core/src/main/java/art/arcane/iris/generation/biome/IrisBiome.java index 33565e95e..5783ab4e4 100644 --- a/core/src/main/java/art/arcane/iris/generation/biome/IrisBiome.java +++ b/core/src/main/java/art/arcane/iris/generation/biome/IrisBiome.java @@ -516,7 +516,7 @@ public class IrisBiome extends IrisRegistrant implements Rarity { } private CNG createChildrenGenerator(RNG random, int sig, double scale) { - return getChildStyle().create(deriveChildStyleSeed(random, sig), getLoader()).bake().scale(scale).bake(); + return getChildStyle().createNoCache(deriveChildStyleSeed(random, sig), getLoader()).bake().scale(scale).bake(); } static RNG deriveChildStyleSeed(RNG random, int signature) { diff --git a/core/src/test/java/art/arcane/iris/generation/biome/IrisBiomeChildrenGeneratorTest.java b/core/src/test/java/art/arcane/iris/generation/biome/IrisBiomeChildrenGeneratorTest.java index 68dc8b086..f7f1202fd 100644 --- a/core/src/test/java/art/arcane/iris/generation/biome/IrisBiomeChildrenGeneratorTest.java +++ b/core/src/test/java/art/arcane/iris/generation/biome/IrisBiomeChildrenGeneratorTest.java @@ -3,20 +3,14 @@ package art.arcane.iris.generation.biome; import art.arcane.iris.generation.noise.IrisGeneratorStyle; import art.arcane.iris.generation.noise.NoiseStyle; import art.arcane.iris.pack.loading.IrisData; -import art.arcane.iris.testsupport.ExpectedToFailUntilFixed; -import art.arcane.iris.testsupport.ExpectedToFailUntilFixedRule; import art.arcane.iris.testsupport.RunningEnginePackData; import art.arcane.volmlib.util.math.RNG; -import org.junit.Rule; import org.junit.Test; import static art.arcane.iris.testsupport.GeneratorSampling.sampleAtBlocks; import static org.junit.Assert.assertArrayEquals; public class IrisBiomeChildrenGeneratorTest { - private static final String SHARED_CHILD_STYLE_GENERATOR_BUG = - "IrisBiome scales the shared child style generator instead of its own. " - + "Ref.: https://github.com/VolmitSoftware/Iris/issues/1251"; private static final long WORLD_SEED = 7L; private static final int CHILDREN_SIGNATURE = 123; private static final double CHILD_SHRINK_FACTOR = 4D; @@ -25,10 +19,6 @@ public class IrisBiomeChildrenGeneratorTest { private final IrisData packData = RunningEnginePackData.create(); private final IrisBiome biome = createBiomeWithSimplexChildStyle(packData); - @Rule - public final ExpectedToFailUntilFixedRule expectedFailures = new ExpectedToFailUntilFixedRule(); - - @ExpectedToFailUntilFixed(SHARED_CHILD_STYLE_GENERATOR_BUG) @Test public void doesBuildingTheChildrenGeneratorLeaveTheSharedChildStyleGeneratorUnscaled() { assertArrayEquals(sampleUntouchedSharedChildStyleGenerator(), sampleSharedChildStyleGeneratorAfterChildrenGeneratorBuilt(), 0D);