test:

- Added carving entry shared child style test, expected to fail until the fix Ref.: https://github.com/VolmitSoftware/Iris/issues/1251
2026-10-11 19:14:11 +00:00 · 2026-10-02 07:31:17 +02:00
parent ff74a6f811
commit 1e25c07eac
1 changed files with 83 additions and 0 deletions
@@ -0,0 +1,83 @@
+package art.arcane.iris.generation.terrain;
+
+import art.arcane.iris.generation.noise.IrisGeneratorStyle;
+import art.arcane.iris.generation.noise.NoiseStyle;
+import art.arcane.iris.generation.runtime.Engine;
+import art.arcane.iris.pack.loading.IrisData;
+import art.arcane.iris.testsupport.ExpectedToFailUntilFixed;
+import art.arcane.iris.testsupport.ExpectedToFailUntilFixedRule;
+import art.arcane.volmlib.util.math.RNG;
+import art.arcane.volmlib.util.noise.CNG;
+import org.junit.Rule;
+import org.junit.Test;
+
+import java.util.Arrays;
+
+import static org.junit.Assert.assertArrayEquals;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class IrisDimensionCarvingEntryTest {
+    private static final String SHARED_CHILD_STYLE_GENERATOR_BUG =
+            "IrisDimensionCarvingEntry scales the shared child style generator instead of its own. "
+                    + "Ref.: https://github.com/VolmitSoftware/Iris/issues/1251";
+    private static final long WORLD_SEED = 7L;
+    private static final String CARVING_ENTRY_ID = "deep-caves";
+    private static final double CHILD_SHRINK_FACTOR = 4D;
+    private static final double[][] SAMPLE_BLOCKS = {{1000D, -2000D}, {12.5D, -7.25D}, {-517D, 333D}};
+
+    private final IrisData packData = createPackDataThatBelongsToOneRunningEngine();
+    private final IrisDimensionCarvingEntry carvingEntry = createCarvingEntry();
+
+    @Rule
+    public final ExpectedToFailUntilFixedRule expectedFailures = new ExpectedToFailUntilFixedRule();
+
+    @ExpectedToFailUntilFixed(SHARED_CHILD_STYLE_GENERATOR_BUG)
+    @Test
+    public void doesBuildingTheChildrenGeneratorLeaveTheSharedChildStyleGeneratorUnscaled() {
+        assertArrayEquals(sampleUntouchedSharedChildStyleGenerator(), sampleSharedChildStyleGeneratorAfterChildrenGeneratorBuilt(), 0D);
+    }
+
+    private double[] sampleSharedChildStyleGeneratorAfterChildrenGeneratorBuilt() {
+        carvingEntry.getChildrenGenerator(WORLD_SEED, packData);
+        return sampleSharedChildStyleGenerator(carvingEntry.getChildStyle());
+    }
+
+    private double[] sampleUntouchedSharedChildStyleGenerator() {
+        return sampleSharedChildStyleGenerator(createSimplexStyle());
+    }
+
+    private double[] sampleSharedChildStyleGenerator(IrisGeneratorStyle childStyle) {
+        return sampleAtBlocks(childStyle.create(deriveSharedChildStyleSeed(), packData));
+    }
+
+    private RNG deriveSharedChildStyleSeed() {
+        return IrisDimensionCarvingEntry.deriveChildStyleSeed(carvingEntry.deriveChildrenGeneratorSeed(WORLD_SEED));
+    }
+
+    private static double[] sampleAtBlocks(CNG generator) {
+        return Arrays.stream(SAMPLE_BLOCKS).mapToDouble(block -> generator.noise(block[0], block[1])).toArray();
+    }
+
+    private static IrisDimensionCarvingEntry createCarvingEntry() {
+        return withShrinkingSimplexChildStyle(new IrisDimensionCarvingEntry().setId(CARVING_ENTRY_ID));
+    }
+
+    private static IrisDimensionCarvingEntry withShrinkingSimplexChildStyle(IrisDimensionCarvingEntry carvingEntry) {
+        return carvingEntry.setChildStyle(createSimplexStyle()).setChildShrinkFactor(CHILD_SHRINK_FACTOR);
+    }
+
+    private static IrisGeneratorStyle createSimplexStyle() {
+        return new IrisGeneratorStyle(NoiseStyle.SIMPLEX);
+    }
+
+    private static IrisData createPackDataThatBelongsToOneRunningEngine() {
+        IrisData newPackData = mock(IrisData.class);
+        bindToNewRunningEngine(newPackData);
+        return newPackData;
+    }
+
+    private static void bindToNewRunningEngine(IrisData packData) {
+        when(packData.getEngine()).thenReturn(mock(Engine.class));
+    }
+}