diff --git a/core/src/main/java/art/arcane/iris/generation/terrain/IrisDimensionCarvingEntry.java b/core/src/main/java/art/arcane/iris/generation/terrain/IrisDimensionCarvingEntry.java index cee7da319..782cba9d5 100644 --- a/core/src/main/java/art/arcane/iris/generation/terrain/IrisDimensionCarvingEntry.java +++ b/core/src/main/java/art/arcane/iris/generation/terrain/IrisDimensionCarvingEntry.java @@ -87,7 +87,7 @@ public class IrisDimensionCarvingEntry { } private CNG createChildrenGenerator(long childrenGeneratorSeed, IrisData data) { - return scaleByShrinkFactor(getChildStyle().create(deriveChildStyleSeed(childrenGeneratorSeed), data)); + return scaleByShrinkFactor(getChildStyle().createNoCache(deriveChildStyleSeed(childrenGeneratorSeed), data)); } long deriveChildrenGeneratorSeed(long worldSeed) { diff --git a/core/src/test/java/art/arcane/iris/generation/terrain/IrisDimensionCarvingEntryTest.java b/core/src/test/java/art/arcane/iris/generation/terrain/IrisDimensionCarvingEntryTest.java index fc51f6ab9..079ef46c4 100644 --- a/core/src/test/java/art/arcane/iris/generation/terrain/IrisDimensionCarvingEntryTest.java +++ b/core/src/test/java/art/arcane/iris/generation/terrain/IrisDimensionCarvingEntryTest.java @@ -3,20 +3,14 @@ package art.arcane.iris.generation.terrain; import art.arcane.iris.generation.noise.IrisGeneratorStyle; import art.arcane.iris.generation.noise.NoiseStyle; import art.arcane.iris.pack.loading.IrisData; -import art.arcane.iris.testsupport.ExpectedToFailUntilFixed; -import art.arcane.iris.testsupport.ExpectedToFailUntilFixedRule; import art.arcane.iris.testsupport.RunningEnginePackData; import art.arcane.volmlib.util.math.RNG; -import org.junit.Rule; import org.junit.Test; import static art.arcane.iris.testsupport.GeneratorSampling.sampleAtBlocks; import static org.junit.Assert.assertArrayEquals; public class IrisDimensionCarvingEntryTest { - private static final String SHARED_CHILD_STYLE_GENERATOR_BUG = - "IrisDimensionCarvingEntry scales the shared child style generator instead of its own. " - + "Ref.: https://github.com/VolmitSoftware/Iris/issues/1251"; private static final long WORLD_SEED = 7L; private static final String CARVING_ENTRY_ID = "deep-caves"; private static final double CHILD_SHRINK_FACTOR = 4D; @@ -25,10 +19,6 @@ public class IrisDimensionCarvingEntryTest { private final IrisData packData = RunningEnginePackData.create(); private final IrisDimensionCarvingEntry carvingEntry = createCarvingEntry(); - @Rule - public final ExpectedToFailUntilFixedRule expectedFailures = new ExpectedToFailUntilFixedRule(); - - @ExpectedToFailUntilFixed(SHARED_CHILD_STYLE_GENERATOR_BUG) @Test public void doesBuildingTheChildrenGeneratorLeaveTheSharedChildStyleGeneratorUnscaled() { assertArrayEquals(sampleUntouchedSharedChildStyleGenerator(), sampleSharedChildStyleGeneratorAfterChildrenGeneratorBuilt(), 0D);