Create pull_request_template.md (#262)

Depends on #260

.github/FUNDING.yml

@@ -1 +0,0 @@
-patreon: BeamMP

.github/pull_request_template.md

@@ -1,6 +1,7 @@
-Please replace this text <-> with your PR description and leave the below declarations intact.
+<!-- 
-
+The following is a disclaimer. Since all content in the repository is licensed under AGPL-3.0, 
----
+the terms of the license apply to your contributions as well.
-
+Please make sure that all code or other content you're contributing is your own, or is licensed under
-By creating this pull request, I understand that code that is AI generated or otherwise automatically generated may be rejected without further discussion.
+an AGPL-3.0 compatible license.
-I declare that I fully understand all code I pushed into this PR, and wrote all this code myself and own the rights to this code.
+-->
+These contributions are my own and I own all rights to them. I understand and agree that these contributions are licensed under [AGPL-3.0](https://www.gnu.org/licenses/agpl-3.0.en.html).

.github/workflows/linux.yml

@@ -1,11 +1,7 @@
 name: Linux
 
-on:
+on: [push]
-  push:
+
-    branches:
-      - 'develop'
-      - 'minor'
-  pull_request:
 
 env: 
   VCPKG_BINARY_SOURCES: "clear;x-gha,readwrite"
@@ -26,7 +22,7 @@ jobs:
           - distro: ubuntu
             version: 22.04
           - distro: ubuntu
-            version: 24.04
+            version: 20.04
     container:
       image: ${{ matrix.distro }}:${{ matrix.version }}
     steps:
@@ -63,13 +59,13 @@ jobs:
         run: bash ./scripts/${{ matrix.distro }}-${{ matrix.version }}/3-build.sh
 
       - name: Archive server artifact
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v2
         with:
           name: BeamMP-Server.${{ matrix.distro }}.${{ matrix.version }}.x86_64
           path: ./bin/BeamMP-Server
 
       - name: Archive server debug info artifact
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v2
         with:
           name: debuginfo.${{ matrix.distro }}.${{ matrix.version }}.x86_64
           path: ./bin/BeamMP-Server.debug
@@ -97,7 +93,7 @@ jobs:
           - distro: ubuntu
             version: 22.04
           - distro: ubuntu
-            version: 24.04
+            version: 20.04
     container:
       image: ${{ matrix.distro }}:${{ matrix.version }}
     steps:
@@ -134,13 +130,13 @@ jobs:
         run: bash ./scripts/${{ matrix.distro }}-${{ matrix.version }}/3-build.sh
 
       - name: Archive server artifact
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v2
         with:
           name: BeamMP-Server.${{ matrix.distro }}.${{ matrix.version }}.arm64
           path: ./bin/BeamMP-Server
 
       - name: Archive server debug info artifact
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v2
         with:
           name: debuginfo.${{ matrix.distro }}.${{ matrix.version }}.arm64
           path: ./bin/BeamMP-Server.debug

.github/workflows/release.yml

@@ -45,7 +45,7 @@ jobs:
           - distro: ubuntu
             version: 22.04
           - distro: ubuntu
-            version: 24.04
+            version: 20.04
     container:
       image: ${{ matrix.distro }}:${{ matrix.version }}
     steps:
@@ -116,7 +116,7 @@ jobs:
           - distro: ubuntu
             version: 22.04
           - distro: ubuntu
-            version: 24.04
+            version: 20.04
     env:
       VCPKG_DEFAULT_TRIPLET: "arm64-linux"
       VCPKG_FORCE_SYSTEM_BINARIES: 1

.github/workflows/windows.yml

@@ -1,11 +1,6 @@
 name: Windows
 
-on:
+on: [push]
-  push:
-    branches:
-      - 'develop'
-      - 'minor'
-  pull_request:
 
 env:
   VCPKG_DEFAULT_TRIPLET: x64-windows-static
@@ -41,7 +36,7 @@ jobs:
         run: bash ./scripts/windows/2-build.sh
 
       - name: Archive server artifact
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v2
         with:
           name: BeamMP-Server-windows
           path: ./bin/Release/BeamMP-Server.exe

.gitignore

@@ -1,4 +1,5 @@
 .idea/
+.sentry-native/
 *.orig
 *.toml
 boost_*

.gitmodules

@@ -4,6 +4,3 @@
 [submodule "vcpkg"]
 	path = vcpkg
 	url = https://github.com/Microsoft/vcpkg.git
-[submodule "deps/toml11"]
-	path = deps/toml11
-	url = https://github.com/ToruNiina/toml11

CMakeLists.txt

@@ -49,9 +49,6 @@ set(PRJ_HEADERS
     include/TServer.h
     include/VehicleData.h
     include/Env.h
-    include/Settings.h
-    include/Profiling.h
-    include/ChronoWrapper.h
 )
 # add all source files (.cpp) to this, except the one with main()
 set(PRJ_SOURCES
@@ -75,9 +72,6 @@ set(PRJ_SOURCES
     src/TServer.cpp
     src/VehicleData.cpp
     src/Env.cpp
-    src/Settings.cpp
-    src/Profiling.cpp
-    src/ChronoWrapper.cpp
 )
 
 find_package(Lua REQUIRED)
@@ -104,7 +98,6 @@ set(PRJ_LIBRARIES
     httplib::httplib
     libzip::zip
     OpenSSL::SSL OpenSSL::Crypto
-    CURL::libcurl
     ${LUA_LIBRARIES}
 )
 
@@ -117,8 +110,7 @@ find_package(httplib CONFIG REQUIRED)
 find_package(libzip CONFIG REQUIRED)
 find_package(RapidJSON CONFIG REQUIRED)
 find_package(sol2 CONFIG REQUIRED)
-find_package(CURL CONFIG REQUIRED)
+find_package(toml11 CONFIG REQUIRED)
-add_subdirectory("deps/toml11")
 
 include_directories(include)
 
@@ -149,7 +141,6 @@ endif(UNIX)
 
 if (WIN32)
     add_compile_options("-D_WIN32_WINNT=0x0601")
-    add_compile_options("/bigobj")
 endif(WIN32)
 
 
@@ -179,11 +170,6 @@ add_library(commandline_static
     deps/commandline/src/backends/BufferedBackend.cpp
     deps/commandline/src/backends/BufferedBackend.h
 )
-
-# Ensure the commandline library uses C++11
-set_target_properties(commandline_static PROPERTIES CXX_STANDARD 11 CXX_STANDARD_REQUIRED YES)
-
-
 if (WIN32)
     target_compile_definitions(commandline_static PRIVATE -DPLATFORM_WINDOWS=1)
 else ()
@@ -208,7 +194,6 @@ target_compile_definitions(${PROJECT_NAME} PRIVATE ${PRJ_DEFINITIONS} ${PRJ_WARN
 )
 
 if(MSVC)
-    target_compile_options(${PROJECT_NAME} PUBLIC "/bigobj")
     target_link_options(${PROJECT_NAME} PRIVATE "/SUBSYSTEM:CONSOLE")
 endif(MSVC)
 
@@ -227,3 +212,4 @@ if(${PROJECT_NAME}_ENABLE_UNIT_TESTING)
         target_link_options(${PROJECT_NAME}-tests PRIVATE "/SUBSYSTEM:CONSOLE")
     endif(MSVC)
 endif()
+

CONTRIBUTING.md

@@ -53,28 +53,11 @@ Do **NOT** pull with merge. This is the default git behavior for `git pull`, but
 
 The only acceptable merge commits are those which actually merge functionally different branches into each other, for example for merging one feature branch into another.
 
-## Workflow
-
-### Making an issue and fixing it
-
-1. Create an issue detailing the feature or bug.
-2. Assign a milestone to the issue, or wait for a maintainer to add a milestone to your issue.
-3. Fork the repository and base your work on the branch mentioned in the milestone attached to your issue (e.g. `v3.0.0 (develop)` -> `develop`).
-4. Program your feature or bug fix.
-5. Open a PR that references the issue by number in the format: `#12345`.
-6. Someone will review your PR and merge it, or ask for changes.
-
-### Fixing an existing issue
-
-1. Fork the repository and base your work on the branch mentioned in the milestone attached to your issue (e.g. `v3.0.0 (develop)` -> `develop`).
-2. Program your feature or bug fix.
-3. Open a PR that references the issue by number in the format: `#12345`.
-4. Someone will review your PR and merge it, or ask for changes.
-
 ## Branches
 
-- `minor`: Minor releases, like `v1.2.3` -> `v1.3.0` or `v1.2.3` -> `v1.2.4`.
+### Which branch should I base my work on?
-- `develop`: Major releases, like `v1.2.3` -> `v2.0.0`, and larger feature/minor releases.
+
+Each *feature* or *bug-fix* is implemented on a new Git branch, branched off of the branch it should be based on. The `master` branch is usually stable, so we don't do development on it. It is always a safe bet to branch off of `master`, but it may be more work to merge later. Branches to base your work on are usually branches like `rc-v3.3.0`, when the latest public version is `3.2.0`, for example. These can often be found in Pull-Requests on GitHub which are tagged `Release Candidate`.
 
 ## Unit tests & CI/CD
 
@@ -108,8 +91,8 @@ A BeamMP-Developer must review your code in detail, and leave a review. If this
 5. Run `git submodule update --init --recursive`.
 6. Make a new branch for your feature or fix from the branch you are on. You can do this via `git checkout -b <branch name>`. See [this section on branches](#branches) for more info on branch naming.
 7. Install all dependencies. Those are usually listed in the `README.md` in the branch you're in, or, more reliably, in one of the files in `.github/workflows` (if you can read `yaml`).
-8. Run CMake to configure the project. You can find tutorials on this online. You will want to tell CMake to build with `CMAKE_BUILD_TYPE=Debug`, for example by passing it to CMake via the commandline switch `-DCMAKE_BUILD_TYPE=Debug`. An example invocation on Linux with GNU make would be 
+8. Run CMake to configure the project. You can find tutorials on this online. You will want to tell CMake to build with `CMAKE_BUILD_TYPE=Debug`, for example by passing it to CMake via the commandline switch `-DCMAKE_BUILD_TYPE=Debug`. You may also want to turn off sentry by setting `SENTRY_BACKEND=none` (for example via commandline switch `-DSENTRY_BACKEND=none`). An example invocation on Linux with GNU make would be 
-`cmake . -DCMAKE_BUILD_TYPE=Debug` . 
+`cmake . -DCMAKE_BUILD_TYPE=Debug -DSENTRY_BACKEND=none` . 
 9. Build the `BeamMP-Server` target to build the BeamMP-Server, or the `BeamMP-Server-tests` target to build the unit-tests (does not include a working server). In the example from 8. (on Linux), you could build with  `make BeamMP-Server`, `make -j BeamMP-Server` or `cmake --build . --parallel --target BeamMP-Server` . Or, on Windows, (in Visual Studio), you would just press some big green "run" or "debug" button.
 10. When making changes, refer to [this section on how to commit properly](#how-to-commit). Not following those guidelines will result in your changes being rejected, so please take a look.
 11. Make sure to add Unit-tests with `doctest` if you build new stuff. You can find examples all over the latest version of the codebase (search for `TEST_CASE`).

README.md

@@ -19,7 +19,7 @@ Feel free to ask any questions via the following channels:
 
 These values are guesstimated and are subject to change with each release.
 
-* RAM: 30-100 MiB usable (not counting OS overhead)
+* RAM: 50+ MiB usable (not counting OS overhead)
 * CPU: >1GHz, preferably multicore
 * OS: Windows, Linux (theoretically any POSIX)
 * GPU: None
@@ -38,7 +38,7 @@ If you need support with understanding the codebase, please write us in the Disc
 
 ## About Building from Source
 
-We only allow building unmodified (original) source code for public use. `master` is considered **unstable** and we will not provide technical support if such a build doesn't work, so always build from a tag. You can checkout a tag with `git checkout tags/TAGNAME`, where `TAGNAME` is the tag, for example `v3.4.1`. See [the tags](https://github.com/BeamMP/BeamMP-Server/tags) for possible versions/tags, as well as [the releases](https://github.com/BeamMP/BeamMP-Server/releases) to check which version is marked as a release/prerelease. We recommend using the [latest release](https://github.com/BeamMP/BeamMP-Server/releases/latest).
+We only allow building unmodified (original) source code for public use. `master` is considered **unstable** and we will not provide technical support if such a build doesn't work, so always build from a tag. You can checkout a tag with `git checkout tags/TAGNAME`, where `TAGNAME` is the tag, for example `v3.1.0`. 
 
 ## Supported Operating Systems
 
@@ -66,10 +66,9 @@ You can build on **Windows, Linux** or other platforms by following these steps:
 
 1. Check out the repository with git: `git clone --recursive https://github.com/BeamMP/BeamMP-Server`.
 2. Go into the directory `cd BeamMP-Server`.
-3. Specify the server version to build by checking out a tag: `git checkout tags/v3.4.1` - [Possible versions/tags](https://github.com/BeamMP/BeamMP-Server/tags)
+3. Run CMake `cmake -S . -B bin -DCMAKE_BUILD_TYPE=Release` - this can take a few minutes and may take a lot of disk space and bandwidth.
-4. Run CMake `cmake -S . -B bin -DCMAKE_BUILD_TYPE=Release` - this can take a few minutes and may take a lot of disk space and bandwidth.
+4. Build via `cmake --build bin --parallel --config Release -t BeamMP-Server`.
-5. Build via `cmake --build bin --parallel --config Release -t BeamMP-Server`.
+5. Your executable can be found in `bin/`.
-6. Your executable can be found in `bin/`.
 
 When you make changes to the code, you only have to run step 4 again.
 ### Building for FreeBSD

cmake/CompilerWarnings.cmake

@@ -73,6 +73,7 @@ function(set_project_warnings project_name)
             -Werror=missing-declarations
             -Werror=missing-field-initializers
             -Werror=ctor-dtor-privacy
+            -Werror=switch-enum
             -Wswitch-default
             -Werror=unused-result
             -Werror=implicit-fallthrough

cmake/Git.cmake

@@ -2,7 +2,7 @@ find_package(Git)
 if(${PROJECT_NAME}_CHECKOUT_GIT_SUBMODULES)
     if(Git_FOUND)
         message(STATUS "Git found, submodule update and init")
-        execute_process(COMMAND ${GIT_EXECUTABLE} submodule update --init
+        execute_process(COMMAND ${GIT_EXECUTABLE} submodule update --init --recursive
                         WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
                         RESULT_VARIABLE GIT_SUBMOD_RESULT)
         if(NOT GIT_SUBMOD_RESULT EQUAL "0")

include/ChronoWrapper.h

@@ -1,8 +0,0 @@
-#pragma once
-
-#include <chrono>
-#include <string>
-
-namespace ChronoWrapper {
-std::chrono::high_resolution_clock::duration TimeFromStringWithLiteral(const std::string& time_str);
-}

include/Client.h

@@ -66,6 +66,7 @@ public:
     std::string GetCarData(int Ident);
     std::string GetCarPositionRaw(int Ident);
     void SetUDPAddr(const ip::udp::endpoint& Addr) { mUDPAddress = Addr; }
+    void SetDownSock(ip::tcp::socket&& CSock) { mDownSocket = std::move(CSock); }
     void SetTCPSock(ip::tcp::socket&& CSock) { mSocket = std::move(CSock); }
     void Disconnect(std::string_view Reason);
     bool IsDisconnected() const { return !mSocket.is_open(); }
@@ -74,6 +75,8 @@ public:
     [[nodiscard]] const std::unordered_map<std::string, std::string>& GetIdentifiers() const { return mIdentifiers; }
     [[nodiscard]] const ip::udp::endpoint& GetUDPAddr() const { return mUDPAddress; }
     [[nodiscard]] ip::udp::endpoint& GetUDPAddr() { return mUDPAddress; }
+    [[nodiscard]] ip::tcp::socket& GetDownSock() { return mDownSocket; }
+    [[nodiscard]] const ip::tcp::socket& GetDownSock() const { return mDownSocket; }
     [[nodiscard]] ip::tcp::socket& GetTCPSock() { return mSocket; }
     [[nodiscard]] const ip::tcp::socket& GetTCPSock() const { return mSocket; }
     [[nodiscard]] std::string GetRoles() const { return mRole; }
@@ -85,7 +88,7 @@ public:
     void ClearCars();
     [[nodiscard]] int GetID() const { return mID; }
     [[nodiscard]] int GetUnicycleID() const { return mUnicycleID; }
-    [[nodiscard]] bool IsUDPConnected() const { return mIsUDPConnected; }
+    [[nodiscard]] bool IsConnected() const { return mIsConnected; }
     [[nodiscard]] bool IsSynced() const { return mIsSynced; }
     [[nodiscard]] bool IsSyncing() const { return mIsSyncing; }
     [[nodiscard]] bool IsGuest() const { return mIsGuest; }
@@ -97,7 +100,7 @@ public:
     [[nodiscard]] const std::queue<std::vector<uint8_t>>& MissedPacketQueue() const { return mPacketsSync; }
     [[nodiscard]] size_t MissedPacketQueueSize() const { return mPacketsSync.size(); }
     [[nodiscard]] std::mutex& MissedPacketQueueMutex() const { return mMissedPacketsMutex; }
-    void SetIsUDPConnected(bool NewIsConnected) { mIsUDPConnected = NewIsConnected; }
+    void SetIsConnected(bool NewIsConnected) { mIsConnected = NewIsConnected; }
     [[nodiscard]] TServer& Server() const;
     void UpdatePingTime();
     int SecondsSinceLastPing();
@@ -106,7 +109,7 @@ private:
     void InsertVehicle(int ID, const std::string& Data);
 
     TServer& mServer;
-    bool mIsUDPConnected = false;
+    bool mIsConnected = false;
     bool mIsSynced = false;
     bool mIsSyncing = false;
     mutable std::mutex mMissedPacketsMutex;
@@ -119,12 +122,13 @@ private:
     SparseArray<std::string> mVehiclePosition;
     std::string mName = "Unknown Client";
     ip::tcp::socket mSocket;
+    ip::tcp::socket mDownSocket;
     ip::udp::endpoint mUDPAddress {};
     int mUnicycleID = -1;
     std::string mRole;
     std::string mDID;
     int mID = -1;
-    std::chrono::time_point<std::chrono::high_resolution_clock> mLastPingTime = std::chrono::high_resolution_clock::now();
+    std::chrono::time_point<std::chrono::high_resolution_clock> mLastPingTime;
 };
 
 std::optional<std::weak_ptr<TClient>> GetClient(class TServer& Server, int ID);

include/Common.h

@@ -18,7 +18,6 @@
 
 #pragma once
 
-#include <algorithm>
 #include <array>
 #include <atomic>
 #include <cstring>
@@ -29,7 +28,6 @@
 #include <memory>
 #include <mutex>
 #include <shared_mutex>
-#include <span>
 #include <sstream>
 #include <unordered_map>
 #include <zlib.h>
@@ -38,7 +36,6 @@
 #include <filesystem>
 namespace fs = std::filesystem;
 
-#include "Settings.h"
 #include "TConsole.h"
 
 struct Version {
@@ -61,6 +58,32 @@ using SparseArray = std::unordered_map<size_t, T>;
 class Application final {
 public:
     // types
+    struct TSettings {
+        std::string ServerName { "BeamMP Server" };
+        std::string ServerDesc { "BeamMP Default Description" };
+        std::string ServerTags { "Freeroam" };
+        std::string Resource { "Resources" };
+        std::string MapName { "/levels/gridmap_v2/info.json" };
+        std::string Key {};
+        std::string Password{};
+        std::string SSLKeyPath { "./.ssl/HttpServer/key.pem" };
+        std::string SSLCertPath { "./.ssl/HttpServer/cert.pem" };
+        bool HTTPServerEnabled { false };
+        int MaxPlayers { 8 };
+        bool Private { true };
+        int MaxCars { 1 };
+        bool DebugModeEnabled { false };
+        int Port { 30814 };
+        std::string CustomIP {};
+        bool LogChat { true };
+        bool SendErrors { true };
+        bool SendErrorsMessageEnabled { true };
+        int HTTPServerPort { 8080 };
+        std::string HTTPServerIP { "127.0.0.1" };
+        bool HTTPServerUseSSL { false };
+        bool HideUpdateMessages { false };
+        [[nodiscard]] bool HasCustomIP() const { return !CustomIP.empty(); }
+    };
 
     using TShutdownHandler = std::function<void()>;
 
@@ -74,19 +97,21 @@ public:
     static TConsole& Console() { return mConsole; }
     static std::string ServerVersionString();
     static const Version& ServerVersion() { return mVersion; }
-    static Version ClientMinimumVersion() { return Version { 2, 2, 0 }; }
+    static uint8_t ClientMajorVersion() { return 2; }
     static std::string PPS() { return mPPS; }
     static void SetPPS(const std::string& NewPPS) { mPPS = NewPPS; }
 
-    static inline struct Settings Settings { };
+    static TSettings Settings;
 
     static std::vector<std::string> GetBackendUrlsInOrder() {
         return {
-            "https://backend.beammp.com",
+            "backend.beammp.com",
+            "backup1.beammp.com",
+            "backup2.beammp.com"
         };
     }
 
-    static std::string GetBackendUrlForAuth() { return "https://auth.beammp.com"; }
+    static std::string GetBackendUrlForAuth() { return "auth.beammp.com"; }
     static std::string GetBackendUrlForSocketIO() { return "https://backend.beammp.com"; }
     static void CheckForUpdates();
     static std::array<uint8_t, 3> VersionStrToInts(const std::string& str);
@@ -127,7 +152,7 @@ private:
     static inline std::mutex mShutdownHandlersMutex {};
     static inline std::deque<TShutdownHandler> mShutdownHandlers {};
 
-    static inline Version mVersion { 3, 8, 1 };
+    static inline Version mVersion { 3, 2, 2 };
 };
 
 void SplitString(std::string const& str, const char delim, std::vector<std::string>& out);
@@ -139,6 +164,7 @@ void RegisterThread(const std::string& str);
 #define KB 1024llu
 #define MB (KB * 1024llu)
 #define GB (MB * 1024llu)
+#define SSU_UNRAW SECRET_SENTRY_URL
 
 #define _file_basename std::filesystem::path(__FILE__).filename().string()
 #define _line std::to_string(__LINE__)
@@ -188,10 +214,6 @@ void RegisterThread(const std::string& str);
         do {                                                                                  \
             Application::Console().Write(_this_location + std::string("[LUA ERROR] ") + (x)); \
         } while (false)
-    #define beammp_lua_log(level, plugin, x)                                                               \
-        do {                                                                                 \
-            Application::Console().Write(_this_location + fmt::format("[{}] [{}] ", plugin, level) + (x)); \
-        } while (false)
     #define beammp_lua_warn(x)                                                               \
         do {                                                                                 \
             Application::Console().Write(_this_location + std::string("[LUA WARN] ") + (x)); \
@@ -199,13 +221,13 @@ void RegisterThread(const std::string& str);
     #define luaprint(x) Application::Console().Write(_this_location + std::string("[LUA] ") + (x))
     #define beammp_debug(x)                                                                   \
         do {                                                                                  \
-            if (Application::Settings.getAsBool(Settings::Key::General_Debug)) {                                     \
+            if (Application::Settings.DebugModeEnabled) {                                     \
                 Application::Console().Write(_this_location + std::string("[DEBUG] ") + (x)); \
             }                                                                                 \
         } while (false)
     #define beammp_event(x)                                                                   \
         do {                                                                                  \
-            if (Application::Settings.getAsBool(Settings::Key::General_Debug)) {                                     \
+            if (Application::Settings.DebugModeEnabled) {                                     \
                 Application::Console().Write(_this_location + std::string("[EVENT] ") + (x)); \
             }                                                                                 \
         } while (false)
@@ -213,7 +235,7 @@ void RegisterThread(const std::string& str);
     #if defined(DEBUG)
         #define beammp_trace(x)                                                                   \
             do {                                                                                  \
-                if (Application::Settings.getAsBool(Settings::Key::General_Debug)) {                                     \
+                if (Application::Settings.DebugModeEnabled) {                                     \
                     Application::Console().Write(_this_location + std::string("[TRACE] ") + (x)); \
                 }                                                                                 \
             } while (false)
@@ -247,7 +269,6 @@ void RegisterThread(const std::string& str);
     #define beammp_tracef(...) beammp_trace(fmt::format(__VA_ARGS__))
     #define beammp_lua_errorf(...) beammp_lua_error(fmt::format(__VA_ARGS__))
     #define beammp_lua_warnf(...) beammp_lua_warn(fmt::format(__VA_ARGS__))
-    #define beammp_lua_log(level, plugin, x) /* x */
 
 #endif // DOCTEST_CONFIG_DISABLE
 
@@ -262,14 +283,57 @@ void RegisterThread(const std::string& str);
 
 void LogChatMessage(const std::string& name, int id, const std::string& msg);
 
-std::vector<uint8_t> Comp(std::span<const uint8_t> input);
+#define Biggest 30000
-std::vector<uint8_t> DeComp(std::span<const uint8_t> input);
+
+template <typename T>
+inline T Comp(const T& Data) {
+    std::array<char, Biggest> C {};
+    // obsolete
+    C.fill(0);
+    z_stream defstream;
+    defstream.zalloc = nullptr;
+    defstream.zfree = nullptr;
+    defstream.opaque = nullptr;
+    defstream.avail_in = uInt(Data.size());
+    defstream.next_in = const_cast<Bytef*>(reinterpret_cast<const Bytef*>(&Data[0]));
+    defstream.avail_out = Biggest;
+    defstream.next_out = reinterpret_cast<Bytef*>(C.data());
+    deflateInit(&defstream, Z_BEST_COMPRESSION);
+    deflate(&defstream, Z_SYNC_FLUSH);
+    deflate(&defstream, Z_FINISH);
+    deflateEnd(&defstream);
+    size_t TotalOut = defstream.total_out;
+    T Ret;
+    Ret.resize(TotalOut);
+    std::fill(Ret.begin(), Ret.end(), 0);
+    std::copy_n(C.begin(), TotalOut, Ret.begin());
+    return Ret;
+}
+
+template <typename T>
+inline T DeComp(const T& Compressed) {
+    std::array<char, Biggest> C {};
+    // not needed
+    C.fill(0);
+    z_stream infstream;
+    infstream.zalloc = nullptr;
+    infstream.zfree = nullptr;
+    infstream.opaque = nullptr;
+    infstream.avail_in = Biggest;
+    infstream.next_in = const_cast<Bytef*>(reinterpret_cast<const Bytef*>(&Compressed[0]));
+    infstream.avail_out = Biggest;
+    infstream.next_out = const_cast<Bytef*>(reinterpret_cast<const Bytef*>(C.data()));
+    inflateInit(&infstream);
+    inflate(&infstream, Z_SYNC_FLUSH);
+    inflate(&infstream, Z_FINISH);
+    inflateEnd(&infstream);
+    size_t TotalOut = infstream.total_out;
+    T Ret;
+    Ret.resize(TotalOut);
+    std::fill(Ret.begin(), Ret.end(), 0);
+    std::copy_n(C.begin(), TotalOut, Ret.begin());
+    return Ret;
+}
 
 std::string GetPlatformAgnosticErrorString();
 #define S_DSN SU_RAW
-
-class InvalidDataError : std::runtime_error {
-public:
-    InvalidDataError() : std::runtime_error("Invalid data") {
-    }
-};

include/CustomAssert.h

@@ -32,7 +32,6 @@
 #include <thread>
 
 #include "Common.h"
-#include "Compat.h"
 
 static const char* const ANSI_RESET = "\u001b[0m";
 
@@ -57,7 +56,7 @@ static const char* const ANSI_WHITE_BOLD = "\u001b[37;1m";
 static const char* const ANSI_BOLD = "\u001b[1m";
 static const char* const ANSI_UNDERLINE = "\u001b[4m";
 
-#if defined(DEBUG) && !defined(BEAMMP_FREEBSD)
+#ifdef DEBUG
 #include <iostream>
 inline void _assert([[maybe_unused]] const char* file, [[maybe_unused]] const char* function, [[maybe_unused]] unsigned line,
     [[maybe_unused]] const char* condition_string, [[maybe_unused]] bool result) {

include/Env.h

@@ -25,8 +25,6 @@ namespace Env {
 enum class Key {
     // provider settings
     PROVIDER_UPDATE_MESSAGE,
-    PROVIDER_DISABLE_CONFIG,
-    PROVIDER_PORT_ENV,
 };
 
 std::optional<std::string> Get(Key key);

include/Http.h

@@ -23,7 +23,6 @@
 #include <filesystem>
 #include <string>
 #include <unordered_map>
-#include <curl/curl.h>
 
 #if defined(BEAMMP_LINUX)
 #pragma GCC diagnostic push
@@ -39,8 +38,8 @@
 namespace fs = std::filesystem;
 
 namespace Http {
-std::string GET(const std::string& url, unsigned int* status = nullptr);
+std::string GET(const std::string& host, int port, const std::string& target, unsigned int* status = nullptr);
-std::string POST(const std::string& url, const std::string& body, const std::string& ContentType, unsigned int* status = nullptr, const std::map<std::string, std::string>& headers = {});
+std::string POST(const std::string& host, int port, const std::string& target, const std::string& body, const std::string& ContentType, unsigned int* status = nullptr, const httplib::Headers& headers = {});
 namespace Status {
     std::string ToString(int code);
 }

include/Json.h

@@ -17,7 +17,7 @@
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 #pragma once
-#include "rapidjson/document.h"
-#include "rapidjson/prettywriter.h"
 #include "rapidjson/stringbuffer.h"
+#include "rapidjson/prettywriter.h"
+#include "rapidjson/document.h"
 #include "rapidjson/writer.h"

include/LuaAPI.h

@@ -35,10 +35,8 @@ namespace MP {
     inline size_t GetPlayerCount() { return Engine->Server().ClientCount(); }
     std::pair<bool, std::string> DropPlayer(int ID, std::optional<std::string> MaybeReason);
     std::pair<bool, std::string> SendChatMessage(int ID, const std::string& Message);
-    std::pair<bool, std::string> SendNotification(int ID, const std::string& Message, const std::string& Icon, const std::string& Category);
     std::pair<bool, std::string> RemoveVehicle(int PlayerID, int VehicleID);
     void Set(int ConfigID, sol::object NewValue);
-    TLuaValue Get(int ConfigID);
     bool IsPlayerGuest(int ID);
     bool IsPlayerConnected(int ID);
     void Sleep(size_t Ms);

include/Profiling.h

@@ -1,75 +0,0 @@
-#pragma once
-
-#include <boost/thread/synchronized_value.hpp>
-#include <chrono>
-#include <cstddef>
-#include <limits>
-#include <unordered_map>
-
-#undef max
-#undef min
-
-namespace prof {
-
-using Duration = std::chrono::duration<double, std::milli>;
-using TimePoint = std::chrono::high_resolution_clock::time_point;
-
-/// Returns the current time.
-TimePoint now();
-
-/// Returns a sub-millisecond resolution duration between start and end.
-Duration duration(const TimePoint& start, const TimePoint& end);
-
-struct Stats {
-    double mean;
-    double stdev;
-    double min;
-    double max;
-    size_t n;
-};
-
-/// Calculates and stores the moving average over K samples of execution time data
-/// for some single unit of code. Threadsafe.
-struct UnitExecutionTime {
-    UnitExecutionTime();
-
-    /// Adds a sample to the collection, overriding the oldest sample if needed.
-    void add_sample(const Duration& dur);
-
-    /// Calculates the mean duration over the `measurement_count()` measurements,
-    /// as well as the standard deviation.
-    Stats stats() const;
-
-    /// Returns the number of elements the moving average is calculated over.
-    size_t measurement_count() const;
-
-private:
-    mutable std::mutex m_mtx {};
-    size_t m_total_calls {};
-    double m_sum {};
-    // sum of measurements squared (for running stdev)
-    double m_measurement_sqr_sum {};
-    double m_min { std::numeric_limits<double>::max() };
-    double m_max { std::numeric_limits<double>::min() };
-};
-
-/// Holds profiles for multiple units by name. Threadsafe.
-struct UnitProfileCollection {
-    /// Adds a sample to the collection, overriding the oldest sample if needed.
-    void add_sample(const std::string& unit, const Duration& duration);
-
-    /// Calculates the mean duration over the `measurement_count()` measurements,
-    /// as well as the standard deviation.
-    Stats stats(const std::string& unit);
-
-    /// Returns the number of elements the moving average is calculated over.
-    size_t measurement_count(const std::string& unit);
-
-    /// Returns the stats for all stored units.
-    std::unordered_map<std::string, Stats> all_stats();
-
-private:
-    boost::synchronized_value<std::unordered_map<std::string, UnitExecutionTime>> m_map;
-};
-
-}

include/RWMutex.h

@@ -23,8 +23,8 @@
  * and write locks and read locks are mutually exclusive.
  */
 
-#include <mutex>
 #include <shared_mutex>
+#include <mutex>
 
 // Use ReadLock(m) and WriteLock(m) to lock it.
 using RWMutex = std::shared_mutex;

include/Settings.h

@@ -1,143 +0,0 @@
-// BeamMP, the BeamNG.drive multiplayer mod.
-// Copyright (C) 2024 BeamMP Ltd., BeamMP team and contributors.
-//
-// BeamMP Ltd. can be contacted by electronic mail via contact@beammp.com.
-//
-// This program is free software: you can redistribute it and/or modify
-// it under the terms of the GNU Affero General Public License as published
-// by the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// This program is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU Affero General Public License for more details.
-//
-// You should have received a copy of the GNU Affero General Public License
-// along with this program.  If not, see <https://www.gnu.org/licenses/>.
-
-#pragma once
-#include "Sync.h"
-#include <concepts>
-#include <cstdint>
-#include <doctest/doctest.h>
-#include <fmt/core.h>
-#include <fmt/format.h>
-#include <stdexcept>
-#include <string>
-#include <unordered_map>
-#include <variant>
-
-struct ComposedKey {
-    std::string Category;
-    std::string Key;
-
-    bool operator==(const ComposedKey& rhs) const {
-        return (this->Category == rhs.Category && this->Key == rhs.Key);
-    }
-};
-
-template <>
-struct fmt::formatter<ComposedKey> : formatter<std::string> {
-    auto format(ComposedKey key, format_context& ctx) const;
-};
-
-inline auto fmt::formatter<ComposedKey>::format(ComposedKey key, fmt::format_context& ctx) const {
-    std::string key_metadata = fmt::format("{}::{}", key.Category, key.Key);
-    return formatter<std::string>::format(key_metadata, ctx);
-}
-
-namespace std {
-template <>
-class hash<ComposedKey> {
-public:
-    std::uint64_t operator()(const ComposedKey& key) const {
-        std::hash<std::string> hash_fn;
-        return hash_fn(key.Category + key.Key);
-    }
-};
-}
-
-struct Settings {
-    using SettingsTypeVariant = std::variant<std::string, bool, int>;
-
-    Settings();
-
-    enum Key {
-        // Keys that correspond to the keys set in TOML
-        // Keys have their TOML section name as prefix
-
-        // [Misc]
-        Misc_ImScaredOfUpdates,
-        Misc_UpdateReminderTime,
-
-        // [General]
-        General_Description,
-        General_Tags,
-        General_MaxPlayers,
-        General_Name,
-        General_Map,
-        General_AuthKey,
-        General_Private,
-        General_Port,
-        General_MaxCars,
-        General_LogChat,
-        General_ResourceFolder,
-        General_Debug,
-        General_AllowGuests,
-        General_InformationPacket,
-    };
-
-    Sync<std::unordered_map<Key, SettingsTypeVariant>> SettingsMap;
-    enum SettingsAccessMask {
-        READ_ONLY, // Value can be read from console
-        READ_WRITE, // Value can be read and written to from console
-        NO_ACCESS // Value is inaccessible from console (no read OR write)
-    };
-
-    using SettingsAccessControl = std::pair<
-        Key, // The Key's corresponding enum encoding
-        SettingsAccessMask // Console read/write permissions
-        >;
-
-    Sync<std::unordered_map<ComposedKey, SettingsAccessControl>> InputAccessMapping;
-    std::string getAsString(Key key);
-
-    int getAsInt(Key key);
-
-    bool getAsBool(Key key);
-
-    SettingsTypeVariant get(Key key);
-
-    void set(Key key, const std::string& value);
-
-    template <typename Integer, std::enable_if_t<std::is_same_v<Integer, int>, bool> = true>
-    void set(Key key, Integer value) {
-        auto map = SettingsMap.synchronize();
-        if (!map->contains(key)) {
-            throw std::logic_error { "Undefined setting key accessed in Settings::set(int)" };
-        }
-        if (!std::holds_alternative<int>(map->at(key))) {
-            throw std::logic_error { fmt::format("Wrong value type in Settings::set(int): index {}", map->at(key).index()) };
-        }
-        map->at(key) = value;
-    }
-    template <typename Boolean, std::enable_if_t<std::is_same_v<bool, Boolean>, bool> = true>
-    void set(Key key, Boolean value) {
-        auto map = SettingsMap.synchronize();
-        if (!map->contains(key)) {
-            throw std::logic_error { "Undefined setting key accessed in Settings::set(bool)" };
-        }
-        if (!std::holds_alternative<bool>(map->at(key))) {
-            throw std::logic_error { fmt::format("Wrong value type in Settings::set(bool): index {}", map->at(key).index()) };
-        }
-        map->at(key) = value;
-    }
-
-    const std::unordered_map<ComposedKey, SettingsAccessControl> getAccessControlMap() const;
-    SettingsAccessControl getConsoleInputAccessMapping(const ComposedKey& keyName);
-
-    void setConsoleInputAccessMapping(const ComposedKey& keyName, const std::string& value);
-    void setConsoleInputAccessMapping(const ComposedKey& keyName, int value);
-    void setConsoleInputAccessMapping(const ComposedKey& keyName, bool value);
-};

include/Sync.h

@@ -1,9 +0,0 @@
-#pragma once
-
-#include <boost/thread/synchronized_value.hpp>
-#include <mutex>
-
-/// This header provides convenience aliases for synchronization primitives.
-
-template <typename T>
-using Sync = boost::synchronized_value<T, std::recursive_mutex>;

include/TConfig.h

@@ -19,7 +19,6 @@
 #pragma once
 
 #include "Common.h"
-#include "Settings.h"
 
 #include <atomic>
 #include <filesystem>
@@ -36,17 +35,18 @@ public:
     [[nodiscard]] bool Failed() const { return mFailed; }
 
     void FlushToFile();
-    void PrintDebug();
 
 private:
     void CreateConfigFile();
     void ParseFromFile(std::string_view name);
-    void TryReadValue(toml::value& Table, const std::string& Category, const std::string_view& Key, const std::string_view& Env, Settings::Key key);
+    void PrintDebug();
+    void TryReadValue(toml::value& Table, const std::string& Category, const std::string_view& Key, const std::string_view& Env, std::string& OutValue);
+    void TryReadValue(toml::value& Table, const std::string& Category, const std::string_view& Key, const std::string_view& Env, bool& OutValue);
+    void TryReadValue(toml::value& Table, const std::string& Category, const std::string_view& Key, const std::string_view& Env, int& OutValue);
 
     void ParseOldFormat();
     std::string TagsAsPrettyArray() const;
     bool IsDefault();
     bool mFailed { false };
-    bool mDisableConfig { false };
     std::string mConfigFileName;
 };

include/TConsole.h

@@ -58,7 +58,6 @@ private:
     void Command_Status(const std::string& cmd, const std::vector<std::string>& args);
     void Command_Settings(const std::string& cmd, const std::vector<std::string>& args);
     void Command_Clear(const std::string&, const std::vector<std::string>& args);
-    void Command_Version(const std::string& cmd, const std::vector<std::string>& args);
 
     void Command_Say(const std::string& FullCommand);
     bool EnsureArgsCount(const std::vector<std::string>& args, size_t n);
@@ -76,7 +75,6 @@ private:
         { "settings", [this](const auto& a, const auto& b) { Command_Settings(a, b); } },
         { "clear", [this](const auto& a, const auto& b) { Command_Clear(a, b); } },
         { "say", [this](const auto&, const auto&) { Command_Say(""); } }, // shouldn't actually be called
-        { "version", [this](const auto& a, const auto& b) { Command_Version(a, b); } },
     };
 
     std::unique_ptr<Commandline> mCommandline { nullptr };

include/THeartbeatThread.h

@@ -29,7 +29,6 @@ public:
     //~THeartbeatThread();
     void operator()() override;
 
-    static inline std::string lastCall = "";
 private:
     std::string GenerateCall();
     std::string GetPlayers();

include/TLuaEngine.h

@@ -18,11 +18,9 @@
 
 #pragma once
 
-#include "Profiling.h"
 #include "TNetwork.h"
 #include "TServer.h"
 #include <any>
-#include <chrono>
 #include <condition_variable>
 #include <filesystem>
 #include <initializer_list>
@@ -30,7 +28,6 @@
 #include <lua.hpp>
 #include <memory>
 #include <mutex>
-#include <nlohmann/json.hpp>
 #include <queue>
 #include <random>
 #include <set>
@@ -39,34 +36,19 @@
 #include <vector>
 
 #define SOL_ALL_SAFETIES_ON 1
-#define SOL_USER_C_ASSERT SOL_ON
-#define SOL_C_ASSERT(...) \
-    beammp_lua_errorf("SOL2 assertion failure: Assertion `{}` failed in {}:{}. This *should* be a fatal error, but BeamMP Server overrides it to not be fatal. This may cause the Lua Engine to crash, or cause other issues.", #__VA_ARGS__, __FILE__, __LINE__)
 #include <sol/sol.hpp>
 
-struct JsonString {
-    std::string value;
-};
-
-// value used to keep nils in a table or array, across serialization boundaries like
-// JsonEncode, so that the nil stays at the same index and isn't treated like a special
-// value (e.g. one that can be ignored or discarded).
-const inline std::string BEAMMP_INTERNAL_NIL = "BEAMMP_SERVER_INTERNAL_NIL_VALUE";
-
 using TLuaStateId = std::string;
 namespace fs = std::filesystem;
 /**
  * std::variant means, that TLuaArgTypes may be one of the Types listed as template args
  */
-using TLuaValue = std::variant<std::string, int, JsonString, bool, std::unordered_map<std::string, std::string>, float>;
+using TLuaArgTypes = std::variant<std::string, int, sol::variadic_args, bool, std::unordered_map<std::string, std::string>>;
-enum TLuaType {
+static constexpr size_t TLuaArgTypes_String = 0;
-    String = 0,
+static constexpr size_t TLuaArgTypes_Int = 1;
-    Int = 1,
+static constexpr size_t TLuaArgTypes_VariadicArgs = 2;
-    Json = 2,
+static constexpr size_t TLuaArgTypes_Bool = 3;
-    Bool = 3,
+static constexpr size_t TLuaArgTypes_StringStringMap = 4;
-    StringStringMap = 4,
-    Float = 5,
-};
 
 class TLuaPlugin;
 
@@ -114,7 +96,7 @@ public:
     struct QueuedFunction {
         std::string FunctionName;
         std::shared_ptr<TLuaResult> Result;
-        std::vector<TLuaValue> Args;
+        std::vector<TLuaArgTypes> Args;
         std::string EventName; // optional, may be empty
     };
 
@@ -167,7 +149,7 @@ public:
     void ReportErrors(const std::vector<std::shared_ptr<TLuaResult>>& Results);
     bool HasState(TLuaStateId StateId);
     [[nodiscard]] std::shared_ptr<TLuaResult> EnqueueScript(TLuaStateId StateID, const TLuaChunk& Script);
-    [[nodiscard]] std::shared_ptr<TLuaResult> EnqueueFunctionCall(TLuaStateId StateID, const std::string& FunctionName, const std::vector<TLuaValue>& Args, const std::string& EventName);
+    [[nodiscard]] std::shared_ptr<TLuaResult> EnqueueFunctionCall(TLuaStateId StateID, const std::string& FunctionName, const std::vector<TLuaArgTypes>& Args);
     void EnsureStateExists(TLuaStateId StateId, const std::string& Name, bool DontCallOnInit = false);
     void RegisterEvent(const std::string& EventName, TLuaStateId StateId, const std::string& FunctionName);
     /**
@@ -187,14 +169,12 @@ public:
         }
 
         std::vector<std::shared_ptr<TLuaResult>> Results;
-        std::vector<TLuaValue> Arguments { TLuaValue { std::forward<ArgsT>(Args) }... };
+        std::vector<TLuaArgTypes> Arguments { TLuaArgTypes { std::forward<ArgsT>(Args) }... };
 
         for (const auto& Event : mLuaEvents.at(EventName)) {
             for (const auto& Function : Event.second) {
                 if (Event.first != IgnoreId) {
-                    auto Result = EnqueueFunctionCall(Event.first, Function, Arguments, EventName);
+                    Results.push_back(EnqueueFunctionCall(Event.first, Function, Arguments));
-                    Results.push_back(Result);
-                    AddResultToCheck(Result);
                 }
             }
         }
@@ -208,10 +188,10 @@ public:
             return {};
         }
         std::vector<std::shared_ptr<TLuaResult>> Results;
-        std::vector<TLuaValue> Arguments { TLuaValue { std::forward<ArgsT>(Args) }... };
+        std::vector<TLuaArgTypes> Arguments { TLuaArgTypes { std::forward<ArgsT>(Args) }... };
         const auto Handlers = GetEventHandlersForState(EventName, StateId);
         for (const auto& Handler : Handlers) {
-            Results.push_back(EnqueueFunctionCall(StateId, Handler, Arguments, EventName));
+            Results.push_back(EnqueueFunctionCall(StateId, Handler, Arguments));
         }
         return Results;
     }
@@ -245,8 +225,8 @@ private:
         StateThreadData(const StateThreadData&) = delete;
         virtual ~StateThreadData() noexcept { beammp_debug("\"" + mStateId + "\" destroyed"); }
         [[nodiscard]] std::shared_ptr<TLuaResult> EnqueueScript(const TLuaChunk& Script);
-        [[nodiscard]] std::shared_ptr<TLuaResult> EnqueueFunctionCall(const std::string& FunctionName, const std::vector<TLuaValue>& Args, const std::string& EventName);
+        [[nodiscard]] std::shared_ptr<TLuaResult> EnqueueFunctionCall(const std::string& FunctionName, const std::vector<TLuaArgTypes>& Args);
-        [[nodiscard]] std::shared_ptr<TLuaResult> EnqueueFunctionCallFromCustomEvent(const std::string& FunctionName, const std::vector<TLuaValue>& Args, const std::string& EventName, CallStrategy Strategy);
+        [[nodiscard]] std::shared_ptr<TLuaResult> EnqueueFunctionCallFromCustomEvent(const std::string& FunctionName, const std::vector<TLuaArgTypes>& Args, const std::string& EventName, CallStrategy Strategy);
         void RegisterEvent(const std::string& EventName, const std::string& FunctionName);
         void AddPath(const fs::path& Path); // to be added to path and cpath
         void operator()() override;
@@ -263,7 +243,6 @@ private:
         sol::table Lua_TriggerGlobalEvent(const std::string& EventName, sol::variadic_args EventArgs);
         sol::table Lua_TriggerLocalEvent(const std::string& EventName, sol::variadic_args EventArgs);
         sol::table Lua_GetPlayerIdentifiers(int ID);
-        std::variant<std::string, sol::nil_t> Lua_GetPlayerRole(int ID);
         sol::table Lua_GetPlayers();
         std::string Lua_GetPlayerName(int ID);
         sol::table Lua_GetPlayerVehicles(int ID);
@@ -274,9 +253,6 @@ private:
         sol::table Lua_FS_ListFiles(const std::string& Path);
         sol::table Lua_FS_ListDirectories(const std::string& Path);
 
-        prof::UnitProfileCollection mProfile {};
-        std::unordered_map<std::string, prof::TimePoint> mProfileStarts;
-
         std::string mName;
         TLuaStateId mStateId;
         lua_State* mState;
@@ -292,7 +268,6 @@ private:
         std::recursive_mutex mPathsMutex;
         std::mt19937 mMersenneTwister;
         std::uniform_real_distribution<double> mUniformRealDistribution01;
-        std::vector<sol::object> JsonStringToArray(JsonString Str);
     };
 
     struct TimedEvent {

include/TNetwork.h

@@ -55,9 +55,9 @@ private:
     TResourceManager& mResourceManager;
     std::thread mUDPThread;
     std::thread mTCPThread;
-    std::mutex mOpenIDMutex;
 
     std::vector<uint8_t> UDPRcvFromClient(ip::udp::endpoint& ClientEndpoint);
+    void HandleDownload(TConnection&& TCPSock);
     void OnConnect(const std::weak_ptr<TClient>& c);
     void TCPClient(const std::weak_ptr<TClient>& c);
     void Looper(const std::weak_ptr<TClient>& c);
@@ -66,7 +66,7 @@ private:
     void Parse(TClient& c, const std::vector<uint8_t>& Packet);
     void SendFile(TClient& c, const std::string& Name);
     static bool TCPSendRaw(TClient& C, ip::tcp::socket& socket, const uint8_t* Data, size_t Size);
-    static void SendFileToClient(TClient& c, size_t Size, const std::string& Name);
+    static void SplitLoad(TClient& c, size_t Sent, size_t Size, bool D, const std::string& Name);
     static const uint8_t* SendSplit(TClient& c, ip::tcp::socket& Socket, const uint8_t* DataPtr, size_t Size);
 };
 

include/TResourceManager.h

@@ -19,7 +19,6 @@
 #pragma once
 
 #include "Common.h"
-#include <nlohmann/json.hpp>
 
 class TResourceManager {
 public:
@@ -31,17 +30,10 @@ public:
     [[nodiscard]] std::string FileSizes() const { return mFileSizes; }
     [[nodiscard]] int ModsLoaded() const { return mModsLoaded; }
 
-    [[nodiscard]] std::string NewFileList() const;
-
-    void RefreshFiles();
-
 private:
     size_t mMaxModSize = 0;
     std::string mFileSizes;
     std::string mFileList;
     std::string mTrimmedList;
     int mModsLoaded = 0;
-
-    std::mutex mModsMutex;
-    nlohmann::json mMods = nlohmann::json::array();
 };

src/ChronoWrapper.cpp

@@ -1,23 +0,0 @@
-#include "ChronoWrapper.h"
-#include "Common.h"
-#include <regex>
-
-std::chrono::high_resolution_clock::duration ChronoWrapper::TimeFromStringWithLiteral(const std::string& time_str) {
-    // const std::regex time_regex(R"((\d+\.{0,1}\d*)(min|ms|us|ns|[dhs]))"); //i.e one of: "25ns, 6us, 256ms, 2s, 13min, 69h, 356d" will get matched (only available in newer C++ versions)
-    const std::regex time_regex(R"((\d+\.{0,1}\d*)(min|[dhs]))"); // i.e one of: "2.01s, 13min, 69h, 356.69d" will get matched
-    std::smatch match;
-    float time_value;
-    if (!std::regex_search(time_str, match, time_regex))
-        return std::chrono::nanoseconds(0);
-    time_value = stof(match.str(1));
-    if (match.str(2) == "d") {
-        return std::chrono::seconds((uint64_t)(time_value * 86400)); // 86400 seconds in a day
-    } else if (match.str(2) == "h") {
-        return std::chrono::seconds((uint64_t)(time_value * 3600)); // 3600 seconds in an hour
-    } else if (match.str(2) == "min") {
-        return std::chrono::seconds((uint64_t)(time_value * 60));
-    } else if (match.str(2) == "s") {
-        return std::chrono::seconds((uint64_t)time_value);
-    }
-    return std::chrono::nanoseconds(0);
-}

src/Client.cpp

@@ -79,19 +79,14 @@ std::string TClient::GetCarPositionRaw(int Ident) {
 void TClient::Disconnect(std::string_view Reason) {
     beammp_debugf("Disconnecting client {} for reason: {}", GetID(), Reason);
     boost::system::error_code ec;
-    if (mSocket.is_open()) {
     mSocket.shutdown(socket_base::shutdown_both, ec);
     if (ec) {
         beammp_debugf("Failed to shutdown client socket: {}", ec.message());
     }
-        mSocket.cancel();
     mSocket.close(ec);
     if (ec) {
         beammp_debugf("Failed to close client socket: {}", ec.message());
     }
-    } else {
-        beammp_debug("Socket is already closed.");
-    }
 }
 
 void TClient::SetCarPosition(int Ident, const std::string& Data) {
@@ -126,14 +121,6 @@ void TClient::SetCarData(int Ident, const std::string& Data) {
 }
 
 int TClient::GetCarCount() const {
-    // mVechileData holds both unicycle and cars which both count towards the maximum car count
-    // spawning a unicycle meant reaching the max, hence being unable to spawn car. this dirty fixes the problem for now.
-    std::unique_lock lock(mVehicleDataMutex);
-    for (auto& v : mVehicleData) {
-        if (v.ID() == mUnicycleID) {
-            return int(mVehicleData.size() - 1);
-        }
-    }
     return int(mVehicleData.size());
 }
 
@@ -149,6 +136,7 @@ void TClient::EnqueuePacket(const std::vector<uint8_t>& Packet) {
 TClient::TClient(TServer& Server, ip::tcp::socket&& Socket)
     : mServer(Server)
     , mSocket(std::move(Socket))
+    , mDownSocket(ip::tcp::socket(Server.IoCtx()))
     , mLastPingTime(std::chrono::high_resolution_clock::now()) {
 }
 

src/Common.cpp

@@ -22,9 +22,7 @@
 #include "TConsole.h"
 #include <array>
 #include <charconv>
-#include <chrono>
 #include <fmt/core.h>
-#include <fstream>
 #include <iostream>
 #include <map>
 #include <regex>
@@ -35,6 +33,8 @@
 #include "CustomAssert.h"
 #include "Http.h"
 
+Application::TSettings Application::Settings = {};
+
 void Application::RegisterShutdownHandler(const TShutdownHandler& Handler) {
     std::unique_lock Lock(mShutdownHandlersMutex);
     if (Handler) {
@@ -215,14 +215,14 @@ void Application::CheckForUpdates() {
     // checks current version against latest version
     std::regex VersionRegex { R"(\d+\.\d+\.\d+\n*)" };
     for (const auto& url : GetBackendUrlsInOrder()) {
-        auto Response = Http::GET(url + "/v/s");
+        auto Response = Http::GET(url, 443, "/v/s");
         bool Matches = std::regex_match(Response, VersionRegex);
         if (Matches) {
             auto MyVersion = ServerVersion();
             auto RemoteVersion = Version(VersionStrToInts(Response));
             if (IsOutdated(MyVersion, RemoteVersion)) {
                 std::string RealVersionString = std::string("v") + RemoteVersion.AsString();
-                const std::string DefaultUpdateMsg = "NEW VERSION IS OUT! Please update to the new version ({}) of the BeamMP-Server! Download it here: https://beammp.com/! For a guide on how to update, visit: https://docs.beammp.com/server/server-maintenance/#updating-the-server";
+                const std::string DefaultUpdateMsg = "NEW VERSION IS OUT! Please update to the new version ({}) of the BeamMP-Server! Download it here: https://beammp.com/! For a guide on how to update, visit: https://wiki.beammp.com/en/home/server-maintenance#updating-the-server";
                 auto UpdateMsg = Env::Get(Env::Key::PROVIDER_UPDATE_MESSAGE).value_or(DefaultUpdateMsg);
                 UpdateMsg = fmt::vformat(std::string_view(UpdateMsg), fmt::make_format_args(RealVersionString));
                 beammp_warnf("{}{}{}", ANSI_YELLOW_BOLD, UpdateMsg, ANSI_RESET);
@@ -256,7 +256,7 @@ static std::mutex ThreadNameMapMutex {};
 
 std::string ThreadName(bool DebugModeOverride) {
     auto Lock = std::unique_lock(ThreadNameMapMutex);
-    if (DebugModeOverride || Application::Settings.getAsBool(Settings::Key::General_Debug)) {
+    if (DebugModeOverride || Application::Settings.DebugModeEnabled) {
         auto id = std::this_thread::get_id();
         if (threadNameMap.find(id) != threadNameMap.end()) {
             // found
@@ -268,21 +268,21 @@ std::string ThreadName(bool DebugModeOverride) {
 
 TEST_CASE("ThreadName") {
     RegisterThread("MyThread");
-    auto OrigDebug = Application::Settings.getAsBool(Settings::Key::General_Debug);
+    auto OrigDebug = Application::Settings.DebugModeEnabled;
 
     // ThreadName adds a space at the end, legacy but we need it still
     SUBCASE("Debug mode enabled") {
-        Application::Settings.set(Settings::Key::General_Debug, true);
+        Application::Settings.DebugModeEnabled = true;
         CHECK(ThreadName(true) == "MyThread ");
         CHECK(ThreadName(false) == "MyThread ");
     }
     SUBCASE("Debug mode disabled") {
-        Application::Settings.set(Settings::Key::General_Debug, false);
+        Application::Settings.DebugModeEnabled = false;
         CHECK(ThreadName(true) == "MyThread ");
         CHECK(ThreadName(false) == "");
     }
     // cleanup
-    Application::Settings.set(Settings::Key::General_Debug, OrigDebug);
+    Application::Settings.DebugModeEnabled = OrigDebug;
 }
 
 void RegisterThread(const std::string& str) {
@@ -296,7 +296,7 @@ void RegisterThread(const std::string& str) {
 #elif defined(BEAMMP_FREEBSD)
     ThreadId = std::to_string(getpid());
 #endif
-    if (Application::Settings.getAsBool(Settings::Key::General_Debug)) {
+    if (Application::Settings.DebugModeEnabled) {
         std::ofstream ThreadFile(".Threads.log", std::ios::app);
         ThreadFile << ("Thread \"" + str + "\" is TID " + ThreadId) << std::endl;
     }
@@ -329,7 +329,7 @@ TEST_CASE("Version::AsString") {
 }
 
 void LogChatMessage(const std::string& name, int id, const std::string& msg) {
-    if (Application::Settings.getAsBool(Settings::Key::General_LogChat)) {
+    if (Application::Settings.LogChat) {
         std::stringstream ss;
         ss << ThreadName();
         ss << "[CHAT] ";
@@ -384,67 +384,3 @@ void SplitString(const std::string& str, const char delim, std::vector<std::stri
         out.push_back(str.substr(start, end - start));
     }
 }
-static constexpr size_t STARTING_MAX_DECOMPRESSION_BUFFER_SIZE = 15 * 1024 * 1024;
-static constexpr size_t MAX_DECOMPRESSION_BUFFER_SIZE = 30 * 1024 * 1024;
-
-std::vector<uint8_t> DeComp(std::span<const uint8_t> input) {
-    beammp_debugf("got {} bytes of input data", input.size());
-
-    // start with a decompression buffer of 5x the input size, clamped to a maximum of 15 MB.
-    // this buffer can and will grow, but we don't want to start it too large. A 5x compression ratio
-    // is pretty optimistic.
-    std::vector<uint8_t> output_buffer(std::min<size_t>(input.size() * 5, STARTING_MAX_DECOMPRESSION_BUFFER_SIZE));
-
-    uLongf output_size = output_buffer.size();
-
-    while (true) {
-        int res = uncompress(
-            reinterpret_cast<Bytef*>(output_buffer.data()),
-            &output_size,
-            reinterpret_cast<const Bytef*>(input.data()),
-            static_cast<uLongf>(input.size()));
-        if (res == Z_BUF_ERROR) {
-            // We assume that a reasonable maximum size for decompressed packets exists. We want to avoid
-            // a client effectively "zip bombing" us by sending a lot of small packets which decompress
-            // into huge data.
-            // If this limit were to be an issue, this could be made configurable, however clients have a similar
-            // limit. For that reason, we just reject packets which decompress into too much data.
-            if (output_buffer.size() >= MAX_DECOMPRESSION_BUFFER_SIZE) {
-                throw std::runtime_error(fmt::format("decompressed packet size of {} bytes exceeded", MAX_DECOMPRESSION_BUFFER_SIZE));
-            }
-            // if decompression fails, we double the buffer size (up to the allowed limit) and try again
-            output_buffer.resize(std::max<size_t>(output_buffer.size() * 2, MAX_DECOMPRESSION_BUFFER_SIZE));
-            beammp_warnf("zlib uncompress() failed, trying with a larger buffer size of {}", output_buffer.size());
-            output_size = output_buffer.size();
-        } else if (res != Z_OK) {
-            beammp_error("zlib uncompress() failed: " + std::to_string(res));
-            if (res == Z_DATA_ERROR) {
-                throw InvalidDataError {};
-            } else {
-                throw std::runtime_error("zlib uncompress() failed");
-            }
-        } else if (res == Z_OK) {
-            break;
-        }
-    }
-    output_buffer.resize(output_size);
-    return output_buffer;
-}
-
-std::vector<uint8_t> Comp(std::span<const uint8_t> input) {
-    auto max_size = compressBound(input.size());
-    std::vector<uint8_t> output(max_size);
-    uLongf output_size = output.size();
-    int res = compress(
-        reinterpret_cast<Bytef*>(output.data()),
-        &output_size,
-        reinterpret_cast<const Bytef*>(input.data()),
-        static_cast<uLongf>(input.size()));
-    if (res != Z_OK) {
-        beammp_error("zlib compress() failed: " + std::to_string(res));
-        throw std::runtime_error("zlib compress() failed");
-    }
-    beammp_debug("zlib compressed " + std::to_string(input.size()) + " B to " + std::to_string(output_size) + " B");
-    output.resize(output_size);
-    return output;
-}

src/Env.cpp

@@ -33,12 +33,6 @@ std::string_view Env::ToString(Env::Key key) {
     case Key::PROVIDER_UPDATE_MESSAGE:
         return "BEAMMP_PROVIDER_UPDATE_MESSAGE";
         break;
-    case Key::PROVIDER_DISABLE_CONFIG:
-        return "BEAMMP_PROVIDER_DISABLE_CONFIG";
-        break;
-    case Key::PROVIDER_PORT_ENV:
-        return "BEAMMP_PROVIDER_PORT_ENV";
-        break;
     }
     return "";
 }

src/Http.cpp

@@ -28,89 +28,41 @@
 #include <random>
 #include <stdexcept>
 
+// TODO: Add sentry error handling back
+
 using json = nlohmann::json;
 
-static size_t CurlWriteCallback(void* contents, size_t size, size_t nmemb, void* userp) {
+std::string Http::GET(const std::string& host, int port, const std::string& target, unsigned int* status) {
-    std::string* Result = reinterpret_cast<std::string*>(userp);
+    httplib::SSLClient client(host, port);
-    std::string NewContents(reinterpret_cast<char*>(contents), size * nmemb);
+    client.enable_server_certificate_verification(false);
-    *Result += NewContents;
+    client.set_address_family(AF_INET);
-    return size * nmemb;
+    auto res = client.Get(target.c_str());
-}
+    if (res) {
-
-std::string Http::GET(const std::string& url, unsigned int* status) {
-    std::string Ret;
-    static thread_local CURL* curl = curl_easy_init();
-    if (curl) {
-        CURLcode res;
-        char errbuf[CURL_ERROR_SIZE];
-        curl_easy_setopt(curl, CURLOPT_URL, url.c_str());
-        curl_easy_setopt(curl, CURLOPT_IPRESOLVE, CURL_IPRESOLVE_V4);
-        curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, CurlWriteCallback);
-        curl_easy_setopt(curl, CURLOPT_WRITEDATA, (void*)&Ret);
-        curl_easy_setopt(curl, CURLOPT_CONNECTTIMEOUT, 10); // seconds
-        curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1L);
-        curl_easy_setopt(curl, CURLOPT_ERRORBUFFER, errbuf);
-        errbuf[0] = 0;
-        res = curl_easy_perform(curl);
-        if (res != CURLE_OK) {
-            beammp_error("GET to " + url + " failed: " + std::string(curl_easy_strerror(res)));
-            beammp_error("Curl error: " + std::string(errbuf));
-            return Http::ErrorString;
-        }
-
         if (status) {
-            curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, status);
+            *status = res->status;
         }
-
+        return res->body;
     } else {
-        beammp_error("Curl easy init failed");
         return Http::ErrorString;
     }
-    return Ret;
-}
-
-std::string Http::POST(const std::string& url, const std::string& body, const std::string& ContentType, unsigned int* status, const std::map<std::string, std::string>& headers) {
-    std::string Ret;
-    static thread_local CURL* curl = curl_easy_init();
-    if (curl) {
-        CURLcode res;
-        char errbuf[CURL_ERROR_SIZE];
-        curl_easy_setopt(curl, CURLOPT_URL, url.c_str());
-        curl_easy_setopt(curl, CURLOPT_IPRESOLVE, CURL_IPRESOLVE_V4);
-        curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, CurlWriteCallback);
-        curl_easy_setopt(curl, CURLOPT_WRITEDATA, (void*)&Ret);
-        curl_easy_setopt(curl, CURLOPT_POST, 1);
-        curl_easy_setopt(curl, CURLOPT_POSTFIELDS, body.c_str());
-        curl_easy_setopt(curl, CURLOPT_POSTFIELDSIZE, body.size());
-        struct curl_slist* list = nullptr;
-        list = curl_slist_append(list, ("Content-Type: " + ContentType).c_str());
-
-        for (auto [header, value] : headers) {
-            list = curl_slist_append(list, (header + ": " + value).c_str());
-        }
-
-        curl_easy_setopt(curl, CURLOPT_HTTPHEADER, list);
-        curl_easy_setopt(curl, CURLOPT_CONNECTTIMEOUT, 10); // seconds
-        curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1L);
-        curl_easy_setopt(curl, CURLOPT_ERRORBUFFER, errbuf);
-        errbuf[0] = 0;
-        res = curl_easy_perform(curl);
-        curl_slist_free_all(list);
-        if (res != CURLE_OK) {
-            beammp_error("POST to " + url + " failed: " + std::string(curl_easy_strerror(res)));
-            beammp_error("Curl error: " + std::string(errbuf));
-            return Http::ErrorString;
 }
 
+std::string Http::POST(const std::string& host, int port, const std::string& target, const std::string& body, const std::string& ContentType, unsigned int* status, const httplib::Headers& headers) {
+    httplib::SSLClient client(host, port);
+    client.set_read_timeout(std::chrono::seconds(10));
+    beammp_assert(client.is_valid());
+    client.enable_server_certificate_verification(false);
+    client.set_address_family(AF_INET);
+    auto res = client.Post(target.c_str(), headers, body.c_str(), body.size(), ContentType.c_str());
+    if (res) {
         if (status) {
-            curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, status);
+            *status = res->status;
         }
-
+        return res->body;
     } else {
-        beammp_error("Curl easy init failed");
+        beammp_debug("POST failed: " + httplib::to_string(res.error()));
         return Http::ErrorString;
     }
-    return Ret;
 }
 
 // RFC 2616, RFC 7231
@@ -220,6 +172,7 @@ Http::Server::THttpServerInstance::THttpServerInstance() {
 }
 
 void Http::Server::THttpServerInstance::operator()() try {
+    beammp_info("HTTP(S) Server started on port " + std::to_string(Application::Settings.HTTPServerPort));
     std::unique_ptr<httplib::Server> HttpLibServerInstance;
     HttpLibServerInstance = std::make_unique<httplib::Server>();
     // todo: make this IP agnostic so people can set their own IP
@@ -261,6 +214,10 @@ void Http::Server::THttpServerInstance::operator()() try {
         beammp_debug("Http Server: " + Req.method + " " + Req.target + " -> " + std::to_string(Res.status));
     });
     Application::SetSubsystemStatus("HTTPServer", Application::Status::Good);
+    auto ret = HttpLibServerInstance->listen(Application::Settings.HTTPServerIP.c_str(), Application::Settings.HTTPServerPort);
+    if (!ret) {
+        beammp_error("Failed to start http server (failed to listen). Please ensure the http server is configured properly in the ServerConfig.toml, or turn it off if you don't need it.");
+    }
 } catch (const std::exception& e) {
     beammp_error("Failed to start http server. Please ensure the http server is configured properly in the ServerConfig.toml, or turn it off if you don't need it. Error: " + std::string(e.what()));
 }

src/LuaAPI.cpp

@@ -20,7 +20,6 @@
 #include "Client.h"
 #include "Common.h"
 #include "CustomAssert.h"
-#include "Settings.h"
 #include "TLuaEngine.h"
 
 #include <nlohmann/json.hpp>
@@ -61,11 +60,7 @@ std::string LuaAPI::LuaToString(const sol::object Value, size_t Indent, bool Quo
         }
     case sol::type::number: {
         std::stringstream ss;
-        if (Value.is<int>()) {
-            ss << Value.as<int>();
-        } else {
         ss << Value.as<float>();
-        }
         return ss.str();
     }
     case sol::type::lua_nil:
@@ -205,37 +200,6 @@ std::pair<bool, std::string> LuaAPI::MP::SendChatMessage(int ID, const std::stri
     return Result;
 }
 
-std::pair<bool, std::string> LuaAPI::MP::SendNotification(int ID, const std::string& Message, const std::string& Icon, const std::string& Category) {
-    std::pair<bool, std::string> Result;
-    std::string Packet = "n" + Category + ":" + Icon + ":" + Message;
-    if (ID == -1) {
-        Engine->Network().SendToAll(nullptr, StringToVector(Packet), true, true);
-        Result.first = true;
-    } else {
-        auto MaybeClient = GetClient(Engine->Server(), ID);
-        if (MaybeClient) {
-            auto c = MaybeClient.value().lock();
-            if (!c->IsSynced()) {
-                Result.first = false;
-                Result.second = "Player is not synced yet";
-                return Result;
-            }
-            if (!Engine->Network().Respond(*c, StringToVector(Packet), true)) {
-                beammp_errorf("Failed to send notification to player (id {}) - did the player disconnect?", ID);
-                Result.first = false;
-                Result.second = "Failed to send packet";
-            }
-            Result.first = true;
-        } else {
-            beammp_lua_error("SendNotification invalid argument [1] invalid ID");
-            Result.first = false;
-            Result.second = "Invalid Player ID";
-        }
-        return Result;
-    }
-    return Result;
-}
-
 std::pair<bool, std::string> LuaAPI::MP::RemoveVehicle(int PID, int VID) {
     std::pair<bool, std::string> Result;
     auto MaybeClient = GetClient(Engine->Server(), PID);
@@ -248,7 +212,6 @@ std::pair<bool, std::string> LuaAPI::MP::RemoveVehicle(int PID, int VID) {
     auto c = MaybeClient.value().lock();
     if (!c->GetCarData(VID).empty()) {
         std::string Destroy = "Od:" + std::to_string(PID) + "-" + std::to_string(VID);
-        LuaAPI::MP::Engine->ReportErrors(LuaAPI::MP::Engine->TriggerEvent("onVehicleDeleted", "", PID, VID));
         Engine->Network().SendToAll(nullptr, StringToVector(Destroy), true, true);
         c->DeleteCar(VID);
         Result.first = true;
@@ -263,98 +226,66 @@ void LuaAPI::MP::Set(int ConfigID, sol::object NewValue) {
     switch (ConfigID) {
     case 0: // debug
         if (NewValue.is<bool>()) {
-            Application::Settings.set(Settings::Key::General_Debug, NewValue.as<bool>());
+            Application::Settings.DebugModeEnabled = NewValue.as<bool>();
-            beammp_info(std::string("Set `Debug` to ") + (Application::Settings.getAsBool(Settings::Key::General_Debug) ? "true" : "false"));
+            beammp_info(std::string("Set `Debug` to ") + (Application::Settings.DebugModeEnabled ? "true" : "false"));
         } else {
             beammp_lua_error("set invalid argument [2] expected boolean");
         }
         break;
     case 1: // private
         if (NewValue.is<bool>()) {
-            Application::Settings.set(Settings::Key::General_Private, NewValue.as<bool>());
+            Application::Settings.Private = NewValue.as<bool>();
-            beammp_info(std::string("Set `Private` to ") + (Application::Settings.getAsBool(Settings::Key::General_Private) ? "true" : "false"));
+            beammp_info(std::string("Set `Private` to ") + (Application::Settings.Private ? "true" : "false"));
         } else {
             beammp_lua_error("set invalid argument [2] expected boolean");
         }
         break;
     case 2: // max cars
         if (NewValue.is<int>()) {
-            Application::Settings.set(Settings::Key::General_MaxCars, NewValue.as<int>());
+            Application::Settings.MaxCars = NewValue.as<int>();
-            beammp_info(std::string("Set `MaxCars` to ") + std::to_string(Application::Settings.getAsInt(Settings::Key::General_MaxCars)));
+            beammp_info(std::string("Set `MaxCars` to ") + std::to_string(Application::Settings.MaxCars));
         } else {
             beammp_lua_error("set invalid argument [2] expected integer");
         }
         break;
     case 3: // max players
         if (NewValue.is<int>()) {
-            Application::Settings.set(Settings::Key::General_MaxPlayers, NewValue.as<int>());
+            Application::Settings.MaxPlayers = NewValue.as<int>();
-            beammp_info(std::string("Set `MaxPlayers` to ") + std::to_string(Application::Settings.getAsInt(Settings::Key::General_MaxPlayers)));
+            beammp_info(std::string("Set `MaxPlayers` to ") + std::to_string(Application::Settings.MaxPlayers));
         } else {
             beammp_lua_error("set invalid argument [2] expected integer");
         }
         break;
     case 4: // Map
         if (NewValue.is<std::string>()) {
-            Application::Settings.set(Settings::Key::General_Map, NewValue.as<std::string>());
+            Application::Settings.MapName = NewValue.as<std::string>();
-            beammp_info(std::string("Set `Map` to ") + Application::Settings.getAsString(Settings::Key::General_Map));
+            beammp_info(std::string("Set `Map` to ") + Application::Settings.MapName);
         } else {
             beammp_lua_error("set invalid argument [2] expected string");
         }
         break;
     case 5: // Name
         if (NewValue.is<std::string>()) {
-            Application::Settings.set(Settings::Key::General_Name, NewValue.as<std::string>());
+            Application::Settings.ServerName = NewValue.as<std::string>();
-            beammp_info(std::string("Set `Name` to ") + Application::Settings.getAsString(Settings::Key::General_Name));
+            beammp_info(std::string("Set `Name` to ") + Application::Settings.ServerName);
         } else {
             beammp_lua_error("set invalid argument [2] expected string");
         }
         break;
     case 6: // Desc
         if (NewValue.is<std::string>()) {
-            Application::Settings.set(Settings::Key::General_Description, NewValue.as<std::string>());
+            Application::Settings.ServerDesc = NewValue.as<std::string>();
-            beammp_info(std::string("Set `Description` to ") + Application::Settings.getAsString(Settings::Key::General_Description));
+            beammp_info(std::string("Set `Description` to ") + Application::Settings.ServerDesc);
         } else {
             beammp_lua_error("set invalid argument [2] expected string");
         }
         break;
-    case 7: // Information packet
-        if (NewValue.is<bool>()) {
-            Application::Settings.set(Settings::Key::General_InformationPacket, NewValue.as<bool>());
-            beammp_info(std::string("Set `InformationPacket` to ") + (Application::Settings.getAsBool(Settings::Key::General_InformationPacket) ? "true" : "false"));
-        } else {
-            beammp_lua_error("set invalid argument [2] expected boolean");
-        }
-         break;
     default:
         beammp_warn("Invalid config ID \"" + std::to_string(ConfigID) + "\". Use `MP.Settings.*` enum for this.");
         break;
     }
 }
 
-TLuaValue LuaAPI::MP::Get(int ConfigID) {
-    switch (ConfigID) {
-    case 0: // debug
-        return Application::Settings.getAsBool(Settings::Key::General_Debug);
-    case 1: // private
-        return Application::Settings.getAsBool(Settings::Key::General_Private);
-    case 2: // max cars
-        return Application::Settings.getAsInt(Settings::Key::General_MaxCars);
-    case 3: // max players
-        return Application::Settings.getAsInt(Settings::Key::General_MaxPlayers);
-    case 4: // Map
-        return Application::Settings.getAsString(Settings::Key::General_Map);
-    case 5: // Name
-        return Application::Settings.getAsString(Settings::Key::General_Name);
-    case 6: // Desc
-        return Application::Settings.getAsString(Settings::Key::General_Description);
-    case 7: // Information packet
-        return Application::Settings.getAsBool(Settings::Key::General_InformationPacket);
-    default:
-        beammp_warn("Invalid config ID \"" + std::to_string(ConfigID) + "\". Use `MP.Settings.*` enum for this.");
-        return 0;
-    }
-}
-
 void LuaAPI::MP::Sleep(size_t Ms) {
     std::this_thread::sleep_for(std::chrono::milliseconds(Ms));
 }
@@ -362,7 +293,7 @@ void LuaAPI::MP::Sleep(size_t Ms) {
 bool LuaAPI::MP::IsPlayerConnected(int ID) {
     auto MaybeClient = GetClient(Engine->Server(), ID);
     if (MaybeClient && !MaybeClient.value().expired()) {
-        return MaybeClient.value().lock()->IsUDPConnected();
+        return MaybeClient.value().lock()->IsConnected();
     } else {
         return false;
     }
@@ -630,11 +561,7 @@ static void JsonEncodeRecursive(nlohmann::json& json, const sol::object& left, c
         key = left.as<std::string>();
         break;
     case sol::type::number:
-        if (left.is<int>()) {
-            key = std::to_string(left.as<int>());
-        } else {
         key = std::to_string(left.as<double>());
-        }
         break;
     default:
         beammp_assert_not_reachable();
@@ -662,21 +589,13 @@ static void JsonEncodeRecursive(nlohmann::json& json, const sol::object& left, c
     case sol::type::string:
         value = right.as<std::string>();
         break;
-    case sol::type::number: {
+    case sol::type::number:
-        if (right.is<int>()) {
-            value = right.as<int>();
-        } else {
         value = right.as<double>();
-        }
         break;
-    }
     case sol::type::function:
         beammp_lua_warn("unsure what to do with function in JsonEncode, ignoring");
         return;
     case sol::type::table: {
-        if (right.as<sol::table>().empty()) {
-            value = nlohmann::json::object();
-        } else {
         bool local_is_array = true;
         for (const auto& pair : right.as<sol::table>()) {
             if (pair.first.get_type() != sol::type::number) {
@@ -686,7 +605,6 @@ static void JsonEncodeRecursive(nlohmann::json& json, const sol::object& left, c
         for (const auto& pair : right.as<sol::table>()) {
             JsonEncodeRecursive(value, pair.first, pair.second, local_is_array, depth + 1);
         }
-        }
         break;
     }
     default:
@@ -702,9 +620,6 @@ static void JsonEncodeRecursive(nlohmann::json& json, const sol::object& left, c
 std::string LuaAPI::MP::JsonEncode(const sol::table& object) {
     nlohmann::json json;
     // table
-    if (object.as<sol::table>().empty()) {
-        json = nlohmann::json::object();
-    } else {
     bool is_array = true;
     for (const auto& pair : object.as<sol::table>()) {
         if (pair.first.get_type() != sol::type::number) {
@@ -714,7 +629,6 @@ std::string LuaAPI::MP::JsonEncode(const sol::table& object) {
     for (const auto& entry : object) {
         JsonEncodeRecursive(json, entry.first, entry.second, is_array);
     }
-    }
     return json.dump();
 }
 

src/Profiling.cpp

@@ -1,59 +0,0 @@
-#include "Profiling.h"
-#include <limits>
-
-prof::Duration prof::duration(const TimePoint& start, const TimePoint& end) {
-    return end - start;
-}
-prof::TimePoint prof::now() {
-    return std::chrono::high_resolution_clock::now();
-}
-prof::Stats prof::UnitProfileCollection::stats(const std::string& unit) {
-    return m_map->operator[](unit).stats();
-}
-
-size_t prof::UnitProfileCollection::measurement_count(const std::string& unit) {
-    return m_map->operator[](unit).measurement_count();
-}
-
-void prof::UnitProfileCollection::add_sample(const std::string& unit, const Duration& duration) {
-    m_map->operator[](unit).add_sample(duration);
-}
-
-prof::Stats prof::UnitExecutionTime::stats() const {
-    std::unique_lock lock(m_mtx);
-    Stats result {};
-    // calculate sum
-    result.n = m_total_calls;
-    result.max = m_min;
-    result.min = m_max;
-    // calculate mean: mean = sum_x / n
-    result.mean = m_sum / double(m_total_calls);
-    // calculate stdev: stdev = sqrt((sum_x2 / n) - (mean * mean))
-    result.stdev = std::sqrt((m_measurement_sqr_sum / double(result.n)) - (result.mean * result.mean));
-    return result;
-}
-
-void prof::UnitExecutionTime::add_sample(const Duration& dur) {
-    std::unique_lock lock(m_mtx);
-    m_sum += dur.count();
-    m_measurement_sqr_sum += dur.count() * dur.count();
-    m_min = std::min(dur.count(), m_min);
-    m_max = std::max(dur.count(), m_max);
-    ++m_total_calls;
-}
-
-prof::UnitExecutionTime::UnitExecutionTime() {
-}
-
-std::unordered_map<std::string, prof::Stats> prof::UnitProfileCollection::all_stats() {
-    auto map = m_map.synchronize();
-    std::unordered_map<std::string, Stats> result {};
-    for (const auto& [name, time] : *map) {
-        result[name] = time.stats();
-    }
-    return result;
-}
-size_t prof::UnitExecutionTime::measurement_count() const {
-    std::unique_lock lock(m_mtx);
-    return m_total_calls;
-}

src/Settings.cpp

@@ -1,189 +0,0 @@
-// BeamMP, the BeamNG.drive multiplayer mod.
-// Copyright (C) 2024 BeamMP Ltd., BeamMP team and contributors.
-//
-// BeamMP Ltd. can be contacted by electronic mail via contact@beammp.com.
-//
-// This program is free software: you can redistribute it and/or modify
-// it under the terms of the GNU Affero General Public License as published
-// by the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// This program is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU Affero General Public License for more details.
-//
-// You should have received a copy of the GNU Affero General Public License
-// along with this program.  If not, see <https://www.gnu.org/licenses/>.
-
-#include "Settings.h"
-
-Settings::Settings() {
-    SettingsMap = std::unordered_map<Key, SettingsTypeVariant> {
-        // All entries which contain std::strings must be explicitly constructed, otherwise they become 'bool'
-        { General_Description, std::string("BeamMP Default Description") },
-        { General_Tags, std::string("Freeroam") },
-        { General_MaxPlayers, 8 },
-        { General_Name, std::string("BeamMP Server") },
-        { General_Map, std::string("/levels/gridmap_v2/info.json") },
-        { General_AuthKey, std::string("") },
-        { General_Private, true },
-        { General_Port, 30814 },
-        { General_MaxCars, 1 },
-        { General_LogChat, true },
-        { General_ResourceFolder, std::string("Resources") },
-        { General_Debug, false },
-        { General_AllowGuests, true },
-        { General_InformationPacket, true },
-        { Misc_ImScaredOfUpdates, true },
-        { Misc_UpdateReminderTime, "30s" }
-    };
-
-    InputAccessMapping = std::unordered_map<ComposedKey, SettingsAccessControl> {
-        { { "General", "Description" }, { General_Description, READ_WRITE } },
-        { { "General", "Tags" }, { General_Tags, READ_WRITE } },
-        { { "General", "MaxPlayers" }, { General_MaxPlayers, READ_WRITE } },
-        { { "General", "Name" }, { General_Name, READ_WRITE } },
-        { { "General", "Map" }, { General_Map, READ_WRITE } },
-        { { "General", "AuthKey" }, { General_AuthKey, NO_ACCESS } },
-        { { "General", "Private" }, { General_Private, READ_ONLY } },
-        { { "General", "Port" }, { General_Port, READ_ONLY } },
-        { { "General", "MaxCars" }, { General_MaxCars, READ_WRITE } },
-        { { "General", "LogChat" }, { General_LogChat, READ_ONLY } },
-        { { "General", "ResourceFolder" }, { General_ResourceFolder, READ_ONLY } },
-        { { "General", "Debug" }, { General_Debug, READ_WRITE } },
-        { { "General", "AllowGuests" }, { General_AllowGuests, READ_WRITE } },
-        { { "General", "InformationPacket" }, { General_InformationPacket, READ_WRITE } },
-        { { "Misc", "ImScaredOfUpdates" }, { Misc_ImScaredOfUpdates, READ_WRITE } },
-        { { "Misc", "UpdateReminderTime" }, { Misc_UpdateReminderTime, READ_WRITE } }
-    };
-}
-
-std::string Settings::getAsString(Key key) {
-    auto map = SettingsMap.synchronize();
-    if (!map->contains(key)) {
-        throw std::logic_error { "Undefined key accessed in Settings::getAsString" };
-    }
-    return std::get<std::string>(map->at(key));
-}
-int Settings::getAsInt(Key key) {
-    auto map = SettingsMap.synchronize();
-    if (!map->contains(key)) {
-        throw std::logic_error { "Undefined key accessed in Settings::getAsInt" };
-    }
-    return std::get<int>(map->at(key));
-}
-
-bool Settings::getAsBool(Key key) {
-    auto map = SettingsMap.synchronize();
-    if (!map->contains(key)) {
-        throw std::logic_error { "Undefined key accessed in Settings::getAsBool" };
-    }
-    return std::get<bool>(map->at(key));
-}
-
-Settings::SettingsTypeVariant Settings::get(Key key) {
-    auto map = SettingsMap.synchronize();
-    if (!map->contains(key)) {
-        throw std::logic_error { "Undefined setting key accessed in Settings::get" };
-    }
-    return map->at(key);
-}
-
-void Settings::set(Key key, const std::string& value) {
-    auto map = SettingsMap.synchronize();
-    if (!map->contains(key)) {
-        throw std::logic_error { "Undefined setting key accessed in Settings::set(std::string)" };
-    }
-    if (!std::holds_alternative<std::string>(map->at(key))) {
-        throw std::logic_error { fmt::format("Wrong value type in Settings::set(std::string): index {}", map->at(key).index()) };
-    }
-    map->at(key) = value;
-}
-
-const std::unordered_map<ComposedKey, Settings::SettingsAccessControl> Settings::getAccessControlMap() const {
-    return *InputAccessMapping;
-}
-
-Settings::SettingsAccessControl Settings::getConsoleInputAccessMapping(const ComposedKey& keyName) {
-    auto acl_map = InputAccessMapping.synchronize();
-    if (!acl_map->contains(keyName)) {
-        throw std::logic_error { "Unknown key name accessed in Settings::getConsoleInputAccessMapping" };
-    } else if (acl_map->at(keyName).second == SettingsAccessMask::NO_ACCESS) {
-        throw std::logic_error { "Setting '" + keyName.Category + "::" + keyName.Key + "' is not accessible from within the runtime!" };
-    }
-    return acl_map->at(keyName);
-}
-
-void Settings::setConsoleInputAccessMapping(const ComposedKey& keyName, const std::string& value) {
-    auto [map, acl_map] = boost::synchronize(SettingsMap, InputAccessMapping);
-    if (!acl_map->contains(keyName)) {
-        throw std::logic_error { "Unknown key name accessed in Settings::setConsoleInputAccessMapping" };
-    } else if (acl_map->at(keyName).second == SettingsAccessMask::NO_ACCESS) {
-        throw std::logic_error { "Setting '" + keyName.Category + "::" + keyName.Key + "' is not accessible from within the runtime!" };
-    } else if (acl_map->at(keyName).second == SettingsAccessMask::READ_ONLY) {
-        throw std::logic_error { "Setting '" + keyName.Category + "::" + keyName.Key + "' is not writeable from within the runtime!" };
-    }
-
-    Key key = acl_map->at(keyName).first;
-
-    if (!std::holds_alternative<std::string>(map->at(key))) {
-        throw std::logic_error { "Wrong value type in Settings::setConsoleInputAccessMapping: expected std::string" };
-    }
-
-    map->at(key) = value;
-}
-
-void Settings::setConsoleInputAccessMapping(const ComposedKey& keyName, int value) {
-    auto [map, acl_map] = boost::synchronize(SettingsMap, InputAccessMapping);
-    if (!acl_map->contains(keyName)) {
-        throw std::logic_error { "Unknown key name accessed in Settings::setConsoleInputAccessMapping" };
-    } else if (acl_map->at(keyName).second == SettingsAccessMask::NO_ACCESS) {
-        throw std::logic_error { "Key '" + keyName.Category + "::" + keyName.Key + "' is not accessible from within the runtime!" };
-    } else if (acl_map->at(keyName).second == SettingsAccessMask::READ_ONLY) {
-        throw std::logic_error { "Key '" + keyName.Category + "::" + keyName.Key + "' is not writeable from within the runtime!" };
-    }
-
-    Key key = acl_map->at(keyName).first;
-
-    if (!std::holds_alternative<int>(map->at(key))) {
-        throw std::logic_error { "Wrong value type in Settings::setConsoleInputAccessMapping: expected int" };
-    }
-
-    map->at(key) = value;
-}
-
-void Settings::setConsoleInputAccessMapping(const ComposedKey& keyName, bool value) {
-    auto [map, acl_map] = boost::synchronize(SettingsMap, InputAccessMapping);
-    if (!acl_map->contains(keyName)) {
-        throw std::logic_error { "Unknown key name accessed in Settings::setConsoleInputAccessMapping" };
-    } else if (acl_map->at(keyName).second == SettingsAccessMask::NO_ACCESS) {
-        throw std::logic_error { "Key '" + keyName.Category + "::" + keyName.Key + "' is not accessible from within the runtime!" };
-    } else if (acl_map->at(keyName).second == SettingsAccessMask::READ_ONLY) {
-        throw std::logic_error { "Key '" + keyName.Category + "::" + keyName.Key + "' is not writeable from within the runtime!" };
-    }
-
-    Key key = acl_map->at(keyName).first;
-
-    if (!std::holds_alternative<bool>(map->at(key))) {
-        throw std::logic_error { "Wrong value type in Settings::setConsoleInputAccessMapping: expected bool" };
-    }
-
-    map->at(key) = value;
-}
-
-TEST_CASE("settings get/set") {
-    Settings settings;
-    settings.set(Settings::General_Name, "hello, world");
-    CHECK_EQ(settings.getAsString(Settings::General_Name), "hello, world");
-    settings.set(Settings::General_Name, std::string("hello, world"));
-    CHECK_EQ(settings.getAsString(Settings::General_Name), "hello, world");
-    settings.set(Settings::General_MaxPlayers, 12);
-    CHECK_EQ(settings.getAsInt(Settings::General_MaxPlayers), 12);
-}
-
-TEST_CASE("settings check for exception on wrong input type") {
-    Settings settings;
-    CHECK_THROWS(settings.set(Settings::General_Debug, "hello, world"));
-    CHECK_NOTHROW(settings.set(Settings::General_Debug, false));
-}

src/TConfig.cpp

@@ -18,16 +18,12 @@
 
 #include "Common.h"
 
-#include "Env.h"
-#include "Settings.h"
 #include "TConfig.h"
 #include <cstdlib>
-#include <exception>
 #include <fstream>
 #include <iostream>
 #include <istream>
 #include <sstream>
-#include <type_traits>
 
 // General
 static constexpr std::string_view StrDebug = "Debug";
@@ -54,17 +50,12 @@ static constexpr std::string_view StrAuthKey = "AuthKey";
 static constexpr std::string_view EnvStrAuthKey = "BEAMMP_AUTH_KEY";
 static constexpr std::string_view StrLogChat = "LogChat";
 static constexpr std::string_view EnvStrLogChat = "BEAMMP_LOG_CHAT";
-static constexpr std::string_view StrAllowGuests = "AllowGuests";
-static constexpr std::string_view EnvStrAllowGuests = "BEAMMP_ALLOW_GUESTS";
-static constexpr std::string_view StrInformationPacket = "InformationPacket";
-static constexpr std::string_view EnvStrInformationPacket = "BEAMMP_INFORMATION_PACKET";
 static constexpr std::string_view StrPassword = "Password";
 
 // Misc
+static constexpr std::string_view StrSendErrors = "SendErrors";
+static constexpr std::string_view StrSendErrorsMessageEnabled = "SendErrorsShowMessage";
 static constexpr std::string_view StrHideUpdateMessages = "ImScaredOfUpdates";
-static constexpr std::string_view EnvStrHideUpdateMessages = "BEAMMP_IM_SCARED_OF_UPDATES";
-static constexpr std::string_view StrUpdateReminderTime = "UpdateReminderTime";
-static constexpr std::string_view EnvStrUpdateReminderTime = "BEAMMP_UPDATE_REMINDER_TIME";
 
 TEST_CASE("TConfig::TConfig") {
     const std::string CfgFile = "beammp_server_testconfig.toml";
@@ -96,9 +87,7 @@ TEST_CASE("TConfig::TConfig") {
 TConfig::TConfig(const std::string& ConfigFileName)
     : mConfigFileName(ConfigFileName) {
     Application::SetSubsystemStatus("Config", Application::Status::Starting);
-    auto DisableConfig = Env::Get(Env::Key::PROVIDER_DISABLE_CONFIG).value_or("false");
+    if (!fs::exists(mConfigFileName) || !fs::is_regular_file(mConfigFileName)) {
-    mDisableConfig = DisableConfig == "true" || DisableConfig == "1";
-    if (!mDisableConfig && (!fs::exists(mConfigFileName) || !fs::is_regular_file(mConfigFileName))) {
         beammp_info("No config file found! Generating one...");
         CreateConfigFile();
     }
@@ -128,37 +117,35 @@ void SetComment(CommentsT& Comments, const std::string& Comment) {
 void TConfig::FlushToFile() {
     // auto data = toml::parse<toml::preserve_comments>(mConfigFileName);
     auto data = toml::value {};
-    data["General"][StrAuthKey.data()] = Application::Settings.getAsString(Settings::Key::General_AuthKey);
+    data["General"][StrAuthKey.data()] = Application::Settings.Key;
     SetComment(data["General"][StrAuthKey.data()].comments(), " AuthKey has to be filled out in order to run the server");
-    data["General"][StrLogChat.data()] = Application::Settings.getAsBool(Settings::Key::General_LogChat);
+    data["General"][StrLogChat.data()] = Application::Settings.LogChat;
     SetComment(data["General"][StrLogChat.data()].comments(), " Whether to log chat messages in the console / log");
-    data["General"][StrDebug.data()] = Application::Settings.getAsBool(Settings::Key::General_Debug);
+    data["General"][StrDebug.data()] = Application::Settings.DebugModeEnabled;
-    data["General"][StrPrivate.data()] = Application::Settings.getAsBool(Settings::Key::General_Private);
+    data["General"][StrPrivate.data()] = Application::Settings.Private;
-    SetComment(data["General"][StrInformationPacket.data()].comments(), " Whether to allow unconnected clients to get the public server information without joining");
+    data["General"][StrPort.data()] = Application::Settings.Port;
-    data["General"][StrInformationPacket.data()] = Application::Settings.getAsBool(Settings::Key::General_InformationPacket);
+    data["General"][StrName.data()] = Application::Settings.ServerName;
-    data["General"][StrAllowGuests.data()] = Application::Settings.getAsBool(Settings::Key::General_AllowGuests);
-    SetComment(data["General"][StrAllowGuests.data()].comments(), " Whether to allow guests");
-    data["General"][StrPort.data()] = Application::Settings.getAsInt(Settings::Key::General_Port);
-    data["General"][StrName.data()] = Application::Settings.getAsString(Settings::Key::General_Name);
     SetComment(data["General"][StrTags.data()].comments(), " Add custom identifying tags to your server to make it easier to find. Format should be TagA,TagB,TagC. Note the comma seperation.");
-    data["General"][StrTags.data()] = Application::Settings.getAsString(Settings::Key::General_Tags);
+    data["General"][StrTags.data()] = Application::Settings.ServerTags;
-    data["General"][StrMaxCars.data()] = Application::Settings.getAsInt(Settings::Key::General_MaxCars);
+    data["General"][StrMaxCars.data()] = Application::Settings.MaxCars;
-    data["General"][StrMaxPlayers.data()] = Application::Settings.getAsInt(Settings::Key::General_MaxPlayers);
+    data["General"][StrMaxPlayers.data()] = Application::Settings.MaxPlayers;
-    data["General"][StrMap.data()] = Application::Settings.getAsString(Settings::Key::General_Map);
+    data["General"][StrMap.data()] = Application::Settings.MapName;
-    data["General"][StrDescription.data()] = Application::Settings.getAsString(Settings::Key::General_Description);
+    data["General"][StrDescription.data()] = Application::Settings.ServerDesc;
-    data["General"][StrResourceFolder.data()] = Application::Settings.getAsString(Settings::Key::General_ResourceFolder);
+    data["General"][StrResourceFolder.data()] = Application::Settings.Resource;
     // data["General"][StrPassword.data()] = Application::Settings.Password;
     // SetComment(data["General"][StrPassword.data()].comments(), " Sets a password on this server, which restricts people from joining. To join, a player must enter this exact password. Leave empty ("") to disable the password.");
     // Misc
-    data["Misc"][StrHideUpdateMessages.data()] = Application::Settings.getAsBool(Settings::Key::Misc_ImScaredOfUpdates);
+    data["Misc"][StrHideUpdateMessages.data()] = Application::Settings.HideUpdateMessages;
     SetComment(data["Misc"][StrHideUpdateMessages.data()].comments(), " Hides the periodic update message which notifies you of a new server version. You should really keep this on and always update as soon as possible. For more information visit https://wiki.beammp.com/en/home/server-maintenance#updating-the-server. An update message will always appear at startup regardless.");
-    data["Misc"][StrUpdateReminderTime.data()] = Application::Settings.getAsString(Settings::Key::Misc_UpdateReminderTime);
+    data["Misc"][StrSendErrors.data()] = Application::Settings.SendErrors;
-    SetComment(data["Misc"][StrUpdateReminderTime.data()].comments(), " Specifies the time between update reminders. You can use any of \"s, min, h, d\" at the end to specify the units seconds, minutes, hours or days. So 30d or 0.5min will print the update message every 30 days or half a minute.");
+    SetComment(data["Misc"][StrSendErrors.data()].comments(), " If SendErrors is `true`, the server will send helpful info about crashes and other issues back to the BeamMP developers. This info may include your config, who is on your server at the time of the error, and similar general information. This kind of data is vital in helping us diagnose and fix issues faster. This has no impact on server performance. You can opt-out of this system by setting this to `false`");
+    data["Misc"][StrSendErrorsMessageEnabled.data()] = Application::Settings.SendErrorsMessageEnabled;
+    SetComment(data["Misc"][StrSendErrorsMessageEnabled.data()].comments(), " You can turn on/off the SendErrors message you get on startup here");
     std::stringstream Ss;
     Ss << "# This is the BeamMP-Server config file.\n"
-          "# Help & Documentation: `https://docs.beammp.com/server/server-maintenance/`\n"
+          "# Help & Documentation: `https://wiki.beammp.com/en/home/server-maintenance`\n"
           "# IMPORTANT: Fill in the AuthKey with the key you got from `https://keymaster.beammp.com/` on the left under \"Keys\"\n"
-       << toml::format(data);
+       << data;
     auto File = std::fopen(mConfigFileName.c_str(), "w+");
     if (!File) {
         beammp_error("Failed to create/write to config file: " + GetPlatformAgnosticErrorString());
@@ -174,152 +161,172 @@ void TConfig::FlushToFile() {
 
 void TConfig::CreateConfigFile() {
     // build from old config Server.cfg
-    if (mDisableConfig) {
+
-        return;
+    try {
+        if (fs::exists("Server.cfg")) {
+            // parse it (this is weird and bad and should be removed in some future version)
+            ParseOldFormat();
         }
+    } catch (const std::exception& e) {
+        beammp_error("an error occurred and was ignored during config transfer: " + std::string(e.what()));
+    }
+
     FlushToFile();
 }
 
-// This arcane template magic is needed for using lambdas as overloaded visitors
+void TConfig::TryReadValue(toml::value& Table, const std::string& Category, const std::string_view& Key, const std::string_view& Env, std::string& OutValue) {
-// See https://en.cppreference.com/w/cpp/utility/variant/visit for reference
-template <class... Ts>
-struct overloaded : Ts... {
-    using Ts::operator()...;
-};
-template <class... Ts>
-overloaded(Ts...) -> overloaded<Ts...>;
-
-void TConfig::TryReadValue(toml::value& Table, const std::string& Category, const std::string_view& Key, const std::string_view& Env, Settings::Key key) {
     if (!Env.empty()) {
-        if (const char* envp = std::getenv(Env.data());
+        if (const char* envp = std::getenv(Env.data()); envp != nullptr && std::strcmp(envp, "") != 0) {
-            envp != nullptr && std::strcmp(envp, "") != 0) {
+            OutValue = std::string(envp);
-
-            std::visit(
-                overloaded {
-                    [&envp, &key](std::string) {
-                        Application::Settings.set(key, std::string(envp));
-                    },
-                    [&envp, &key](int) {
-                        Application::Settings.set(key, int(std::strtol(envp, nullptr, 10)));
-                    },
-                    [&envp, &key](bool) {
-                        auto Str = std::string(envp);
-                        Application::Settings.set(key, bool(Str == "1" || Str == "true"));
-                    } },
-
-                Application::Settings.get(key));
             return;
         }
     }
-
+    if (Table[Category.c_str()][Key.data()].is_string()) {
-    std::visit([&Table, &Category, &Key, &key](auto&& arg) {
+        OutValue = Table[Category.c_str()][Key.data()].as_string();
-        using T = std::decay_t<decltype(arg)>;
+    }
-        if constexpr (std::is_same_v<T, std::string>) {
+}
-            if (Table[Category.c_str()][Key.data()].is_string())
+
-                Application::Settings.set(key, Table[Category.c_str()][Key.data()].as_string());
+void TConfig::TryReadValue(toml::value& Table, const std::string& Category, const std::string_view& Key, const std::string_view& Env, bool& OutValue) {
-            else
+    if (!Env.empty()) {
-                beammp_warnf("Value '{}.{}' has unexpected type, expected type 'string'", Category, Key);
+        if (const char* envp = std::getenv(Env.data()); envp != nullptr && std::strcmp(envp, "") != 0) {
-        } else if constexpr (std::is_same_v<T, int>) {
+            auto Str = std::string(envp);
-            if (Table[Category.c_str()][Key.data()].is_integer())
+            OutValue = Str == "1" || Str == "true";
-                Application::Settings.set(key, int(Table[Category.c_str()][Key.data()].as_integer()));
+            return;
-            else
+        }
-                beammp_warnf("Value '{}.{}' has unexpected type, expected type 'integer'", Category, Key);
+    }
-        } else if constexpr (std::is_same_v<T, bool>) {
+    if (Table[Category.c_str()][Key.data()].is_boolean()) {
-            if (Table[Category.c_str()][Key.data()].is_boolean())
+        OutValue = Table[Category.c_str()][Key.data()].as_boolean();
-                Application::Settings.set(key, Table[Category.c_str()][Key.data()].as_boolean());
+    }
-            else
+}
-                beammp_warnf("Value '{}.{}' has unexpected type, expected type 'boolean'", Category, Key);
+
-        } else {
+void TConfig::TryReadValue(toml::value& Table, const std::string& Category, const std::string_view& Key, const std::string_view& Env, int& OutValue) {
-            throw std::logic_error { "Invalid type for config value during read attempt" };
+    if (!Env.empty()) {
+        if (const char* envp = std::getenv(Env.data()); envp != nullptr && std::strcmp(envp, "") != 0) {
+            OutValue = int(std::strtol(envp, nullptr, 10));
+            return;
+        }
+    }
+    if (Table[Category.c_str()][Key.data()].is_integer()) {
+        OutValue = int(Table[Category.c_str()][Key.data()].as_integer());
     }
-    },
-        Application::Settings.get(key));
 }
 
 void TConfig::ParseFromFile(std::string_view name) {
     try {
-        toml::value data {};
+        toml::value data = toml::parse<toml::preserve_comments>(name.data());
-        if (!mDisableConfig) {
-            data = toml::parse(name.data());
-        }
-
         // GENERAL
-
+        TryReadValue(data, "General", StrDebug, EnvStrDebug, Application::Settings.DebugModeEnabled);
-        // Read into new Settings Singleton
+        TryReadValue(data, "General", StrPrivate, EnvStrPrivate, Application::Settings.Private);
-        TryReadValue(data, "General", StrDebug, EnvStrDebug, Settings::Key::General_Debug);
+        TryReadValue(data, "General", StrPort, EnvStrPort, Application::Settings.Port);
-        TryReadValue(data, "General", StrPrivate, EnvStrPrivate, Settings::Key::General_Private);
+        TryReadValue(data, "General", StrMaxCars, EnvStrMaxCars, Application::Settings.MaxCars);
-        TryReadValue(data, "General", StrInformationPacket, EnvStrInformationPacket, Settings::Key::General_InformationPacket);
+        TryReadValue(data, "General", StrMaxPlayers, EnvStrMaxPlayers, Application::Settings.MaxPlayers);
-        if (Env::Get(Env::Key::PROVIDER_PORT_ENV).has_value()) {
+        TryReadValue(data, "General", StrMap, EnvStrMap, Application::Settings.MapName);
-            TryReadValue(data, "General", StrPort, Env::Get(Env::Key::PROVIDER_PORT_ENV).value(), Settings::Key::General_Port);
+        TryReadValue(data, "General", StrName, EnvStrName, Application::Settings.ServerName);
-        } else {
+        TryReadValue(data, "General", StrDescription, EnvStrDescription, Application::Settings.ServerDesc);
-            TryReadValue(data, "General", StrPort, EnvStrPort, Settings::Key::General_Port);
+        TryReadValue(data, "General", StrTags, EnvStrTags, Application::Settings.ServerTags);
-        }
+        TryReadValue(data, "General", StrResourceFolder, EnvStrResourceFolder, Application::Settings.Resource);
-        TryReadValue(data, "General", StrMaxCars, EnvStrMaxCars, Settings::Key::General_MaxCars);
+        TryReadValue(data, "General", StrAuthKey, EnvStrAuthKey, Application::Settings.Key);
-        TryReadValue(data, "General", StrMaxPlayers, EnvStrMaxPlayers, Settings::Key::General_MaxPlayers);
+        TryReadValue(data, "General", StrLogChat, EnvStrLogChat, Application::Settings.LogChat);
-        TryReadValue(data, "General", StrMap, EnvStrMap, Settings::Key::General_Map);
+        TryReadValue(data, "General", StrPassword, "", Application::Settings.Password);
-        TryReadValue(data, "General", StrName, EnvStrName, Settings::Key::General_Name);
-        TryReadValue(data, "General", StrDescription, EnvStrDescription, Settings::Key::General_Description);
-        TryReadValue(data, "General", StrTags, EnvStrTags, Settings::Key::General_Tags);
-        TryReadValue(data, "General", StrResourceFolder, EnvStrResourceFolder, Settings::Key::General_ResourceFolder);
-        TryReadValue(data, "General", StrAuthKey, EnvStrAuthKey, Settings::Key::General_AuthKey);
-        TryReadValue(data, "General", StrLogChat, EnvStrLogChat, Settings::Key::General_LogChat);
-        TryReadValue(data, "General", StrAllowGuests, EnvStrAllowGuests, Settings::Key::General_AllowGuests);
         // Misc
-        TryReadValue(data, "Misc", StrHideUpdateMessages, EnvStrHideUpdateMessages, Settings::Key::Misc_ImScaredOfUpdates);
+        TryReadValue(data, "Misc", StrSendErrors, "", Application::Settings.SendErrors);
-        TryReadValue(data, "Misc", StrUpdateReminderTime, EnvStrUpdateReminderTime, Settings::Key::Misc_UpdateReminderTime);
+        TryReadValue(data, "Misc", StrHideUpdateMessages, "", Application::Settings.HideUpdateMessages);
-
+        TryReadValue(data, "Misc", StrSendErrorsMessageEnabled, "", Application::Settings.SendErrorsMessageEnabled);
     } catch (const std::exception& err) {
         beammp_error("Error parsing config file value: " + std::string(err.what()));
         mFailed = true;
         Application::SetSubsystemStatus("Config", Application::Status::Bad);
         return;
     }
+    PrintDebug();
 
     // Update in any case
-    if (!mDisableConfig) {
     FlushToFile();
-    }
     // all good so far, let's check if there's a key
-    if (Application::Settings.getAsString(Settings::Key::General_AuthKey).empty()) {
+    if (Application::Settings.Key.empty()) {
-        if (mDisableConfig) {
-            beammp_error("No AuthKey specified in the environment.");
-        } else {
         beammp_error("No AuthKey specified in the \"" + std::string(mConfigFileName) + "\" file. Please get an AuthKey, enter it into the config file, and restart this server.");
-        }
         Application::SetSubsystemStatus("Config", Application::Status::Bad);
         mFailed = true;
         return;
     }
     Application::SetSubsystemStatus("Config", Application::Status::Good);
-    if (Application::Settings.getAsString(Settings::Key::General_AuthKey).size() != 36) {
+    if (Application::Settings.Key.size() != 36) {
         beammp_warn("AuthKey specified is the wrong length and likely isn't valid.");
     }
 }
 
 void TConfig::PrintDebug() {
-    if (mDisableConfig) {
+    beammp_debug(std::string(StrDebug) + ": " + std::string(Application::Settings.DebugModeEnabled ? "true" : "false"));
-        beammp_debug("Provider turned off the generation and parsing of the ServerConfig.toml");
+    beammp_debug(std::string(StrPrivate) + ": " + std::string(Application::Settings.Private ? "true" : "false"));
-    }
+    beammp_debug(std::string(StrPort) + ": " + std::to_string(Application::Settings.Port));
-    beammp_debug(std::string(StrDebug) + ": " + std::string(Application::Settings.getAsBool(Settings::Key::General_Debug) ? "true" : "false"));
+    beammp_debug(std::string(StrMaxCars) + ": " + std::to_string(Application::Settings.MaxCars));
-    beammp_debug(std::string(StrPrivate) + ": " + std::string(Application::Settings.getAsBool(Settings::Key::General_Private) ? "true" : "false"));
+    beammp_debug(std::string(StrMaxPlayers) + ": " + std::to_string(Application::Settings.MaxPlayers));
-    beammp_debug(std::string(StrInformationPacket) + ": " + std::string(Application::Settings.getAsBool(Settings::Key::General_InformationPacket) ? "true" : "false"));
+    beammp_debug(std::string(StrMap) + ": \"" + Application::Settings.MapName + "\"");
-    beammp_debug(std::string(StrPort) + ": " + std::to_string(Application::Settings.getAsInt(Settings::Key::General_Port)));
+    beammp_debug(std::string(StrName) + ": \"" + Application::Settings.ServerName + "\"");
-    beammp_debug(std::string(StrMaxCars) + ": " + std::to_string(Application::Settings.getAsInt(Settings::Key::General_MaxCars)));
+    beammp_debug(std::string(StrDescription) + ": \"" + Application::Settings.ServerDesc + "\"");
-    beammp_debug(std::string(StrMaxPlayers) + ": " + std::to_string(Application::Settings.getAsInt(Settings::Key::General_MaxPlayers)));
-    beammp_debug(std::string(StrMap) + ": \"" + Application::Settings.getAsString(Settings::Key::General_Map) + "\"");
-    beammp_debug(std::string(StrName) + ": \"" + Application::Settings.getAsString(Settings::Key::General_Name) + "\"");
-    beammp_debug(std::string(StrDescription) + ": \"" + Application::Settings.getAsString(Settings::Key::General_Description) + "\"");
     beammp_debug(std::string(StrTags) + ": " + TagsAsPrettyArray());
-    beammp_debug(std::string(StrLogChat) + ": \"" + (Application::Settings.getAsBool(Settings::Key::General_LogChat) ? "true" : "false") + "\"");
+    beammp_debug(std::string(StrLogChat) + ": \"" + (Application::Settings.LogChat ? "true" : "false") + "\"");
-    beammp_debug(std::string(StrResourceFolder) + ": \"" + Application::Settings.getAsString(Settings::Key::General_ResourceFolder) + "\"");
+    beammp_debug(std::string(StrResourceFolder) + ": \"" + Application::Settings.Resource + "\"");
-    beammp_debug(std::string(StrAllowGuests) + ": \"" + (Application::Settings.getAsBool(Settings::Key::General_AllowGuests) ? "true" : "false") + "\"");
     // special!
-    beammp_debug("Key Length: " + std::to_string(Application::Settings.getAsString(Settings::Key::General_AuthKey).length()) + "");
+    beammp_debug("Key Length: " + std::to_string(Application::Settings.Key.length()) + "");
+    beammp_debug("Password Protected: " + std::string(Application::Settings.Password.empty() ? "false" : "true"));
 }
 
+void TConfig::ParseOldFormat() {
+    std::ifstream File("Server.cfg");
+    // read all, strip comments
+    std::string Content;
+    for (;;) {
+        std::string Line;
+        std::getline(File, Line);
+        if (!Line.empty() && Line.at(0) != '#') {
+            Line = Line.substr(0, Line.find_first_of('#'));
+            Content += Line + "\n";
+        }
+        if (!File.good()) {
+            break;
+        }
+    }
+    std::stringstream Str(Content);
+    std::string Key, Ignore, Value;
+    for (;;) {
+        Str >> Key >> std::ws >> Ignore >> std::ws;
+        std::getline(Str, Value);
+        if (Str.eof()) {
+            break;
+        }
+        std::stringstream ValueStream(Value);
+        ValueStream >> std::ws; // strip leading whitespace if any
+        Value = ValueStream.str();
+        if (Key == "Debug") {
+            Application::Settings.DebugModeEnabled = Value.find("true") != std::string::npos;
+        } else if (Key == "Private") {
+            Application::Settings.Private = Value.find("true") != std::string::npos;
+        } else if (Key == "Port") {
+            ValueStream >> Application::Settings.Port;
+        } else if (Key == "Cars") {
+            ValueStream >> Application::Settings.MaxCars;
+        } else if (Key == "MaxPlayers") {
+            ValueStream >> Application::Settings.MaxPlayers;
+        } else if (Key == "Map") {
+            Application::Settings.MapName = Value.substr(1, Value.size() - 3);
+        } else if (Key == "Name") {
+            Application::Settings.ServerName = Value.substr(1, Value.size() - 3);
+        } else if (Key == "Desc") {
+            Application::Settings.ServerDesc = Value.substr(1, Value.size() - 3);
+        } else if (Key == "use") {
+            Application::Settings.Resource = Value.substr(1, Value.size() - 3);
+        } else if (Key == "AuthKey") {
+            Application::Settings.Key = Value.substr(1, Value.size() - 3);
+        } else {
+            beammp_warn("unknown key in old auth file (ignored): " + Key);
+        }
+        Str >> std::ws;
+    }
+}
 std::string TConfig::TagsAsPrettyArray() const {
     std::vector<std::string> TagsArray = {};
-    SplitString(Application::Settings.getAsString(Settings::General_Tags), ',', TagsArray);
+    SplitString(Application::Settings.ServerTags, ',', TagsArray);
     std::string Pretty = {};
     for (size_t i = 0; i < TagsArray.size() - 1; ++i) {
         Pretty += '\"' + TagsArray[i] + "\", ";

src/TConsole.cpp

@@ -26,12 +26,8 @@
 #include "TLuaEngine.h"
 
 #include <ctime>
-#include <lua.hpp>
 #include <mutex>
-#include <openssl/opensslv.h>
 #include <sstream>
-#include <stdexcept>
-#include <unordered_map>
 
 static inline bool StringStartsWith(const std::string& What, const std::string& StartsWith) {
     return What.size() >= StartsWith.size() && What.substr(0, StartsWith.size()) == StartsWith;
@@ -80,7 +76,7 @@ static std::string GetDate() {
     auto local_tm = std::localtime(&tt);
     char buf[30];
     std::string date;
-    if (Application::Settings.getAsBool(Settings::Key::General_Debug)) {
+    if (Application::Settings.DebugModeEnabled) {
         std::strftime(buf, sizeof(buf), "[%d/%m/%y %T.", local_tm);
         date += buf;
         auto seconds = std::chrono::time_point_cast<std::chrono::seconds>(now);
@@ -108,6 +104,41 @@ void TConsole::BackupOldLog() {
         } catch (const std::exception& e) {
             beammp_warn(e.what());
         }
+        /*
+        int err = 0;
+        zip* z = zip_open("ServerLogs.zip", ZIP_CREATE, &err);
+        if (!z) {
+            std::cerr << GetPlatformAgnosticErrorString() << std::endl;
+            return;
+        }
+        FILE* File = std::fopen(Path.string().c_str(), "r");
+        if (!File) {
+            std::cerr << GetPlatformAgnosticErrorString() << std::endl;
+            return;
+        }
+        std::vector<uint8_t> Buffer;
+        Buffer.resize(fs::file_size(Path));
+        std::fread(Buffer.data(), 1, Buffer.size(), File);
+        std::fclose(File);
+
+        auto s = zip_source_buffer(z, Buffer.data(), Buffer.size(), 0);
+
+        auto TimePoint = fs::last_write_time(Path);
+        auto Secs = TimePoint.time_since_epoch().count();
+        auto MyTimeT = std::time(&Secs);
+
+        std::string NewName = Path.stem().string();
+        NewName += "_";
+        std::string Time;
+        Time.resize(32);
+        size_t n = strftime(Time.data(), Time.size(), "%F_%H.%M.%S", localtime(&MyTimeT));
+        Time.resize(n);
+        NewName += Time;
+        NewName += ".log";
+
+        zip_file_add(z, NewName.c_str(), s, 0);
+        zip_close(z);
+    */
     }
 }
 
@@ -216,8 +247,7 @@ void TConsole::Command_Help(const std::string&, const std::vector<std::string>&
         lua [state id]          switches to lua, optionally into a specific state id's lua
         settings [command]      sets or gets settings for the server, run `settings help` for more info
         status                  how the server is doing and what it's up to
-        clear                   clears the console window
+        clear                   clears the console window)";
-        version                 displays the server version)";
     Application::Console().WriteRaw("BeamMP-Server Console: " + std::string(sHelpString));
 }
 
@@ -237,32 +267,6 @@ void TConsole::Command_Clear(const std::string&, const std::vector<std::string>&
     mCommandline->write("\x1b[;H\x1b[2J");
 }
 
-void TConsole::Command_Version(const std::string& cmd, const std::vector<std::string>& args) {
-    if (!EnsureArgsCount(args, 0)) {
-        return;
-    }
-
-    std::string platform;
-#if defined(BEAMMP_WINDOWS)
-    platform = "Windows";
-#elif defined(BEAMMP_LINUX)
-    platform = "Linux";
-#elif defined(BEAMMP_FREEBSD)
-    platform = "FreeBSD";
-#elif defined(BEAMMP_APPLE)
-    platform = "Apple";
-#else
-    platform = "Unknown";
-#endif
-
-    Application::Console().WriteRaw("Platform: " + platform);
-    Application::Console().WriteRaw("Server:   v" + Application::ServerVersionString());
-    std::string lua_version = fmt::format("Lua:      v{}.{}.{}", LUA_VERSION_MAJOR, LUA_VERSION_MINOR, LUA_VERSION_RELEASE);
-    Application::Console().WriteRaw(lua_version);
-    std::string openssl_version = fmt::format("OpenSSL:  v{}.{}.{}", OPENSSL_VERSION_MAJOR, OPENSSL_VERSION_MINOR, OPENSSL_VERSION_PATCH);
-    Application::Console().WriteRaw(openssl_version);
-}
-
 void TConsole::Command_Kick(const std::string&, const std::vector<std::string>& args) {
     if (!EnsureArgsCount(args, 1, size_t(-1))) {
         return;
@@ -353,142 +357,8 @@ std::tuple<std::string, std::vector<std::string>> TConsole::ParseCommand(const s
     return { Command, Args };
 }
 
-template <class... Ts>
-struct overloaded : Ts... {
-    using Ts::operator()...;
-};
-template <class... Ts>
-overloaded(Ts...) -> overloaded<Ts...>;
-
 void TConsole::Command_Settings(const std::string&, const std::vector<std::string>& args) {
-
+    if (!EnsureArgsCount(args, 1, 2)) {
-    static constexpr const char* sHelpString = R"(
-    Settings:
-        settings help                               displays this help
-        settings list                               lists all settings
-        settings get <category> <setting>           prints current value of specified setting
-        settings set <category> <setting> <value>   sets specified setting to value
-        )";
-
-    if (args.size() == 0) {
-        beammp_errorf("No arguments specified for command 'settings'!");
-        Application::Console().WriteRaw("BeamMP-Server Console: " + std::string(sHelpString));
-        return;
-    }
-
-    if (args.front() == "help") {
-
-        Application::Console().WriteRaw("BeamMP-Server Console: " + std::string(sHelpString));
-        return;
-    } else if (args.front() == "get") {
-        if (args.size() < 3) {
-            beammp_errorf("'settings get' needs at least two arguments!");
-
-            Application::Console().WriteRaw("BeamMP-Server Console: " + std::string(sHelpString));
-            return;
-        }
-
-        try {
-            Settings::SettingsAccessControl acl = Application::Settings.getConsoleInputAccessMapping(ComposedKey { args.at(1), args.at(2) });
-            Settings::SettingsTypeVariant keyType = Application::Settings.get(acl.first);
-
-            std::visit(
-                overloaded {
-                    [&args](std::string keyValue) {
-                        Application::Console().WriteRaw(fmt::format("'{}::{}' = {}", args.at(1), args.at(2), keyValue));
-                    },
-                    [&args](int keyValue) {
-                        Application::Console().WriteRaw(fmt::format("'{}::{}' = {}", args.at(1), args.at(2), keyValue));
-                    },
-                    [&args](bool keyValue) {
-                        Application::Console().WriteRaw(fmt::format("'{}::{}' = {}", args.at(1), args.at(2), keyValue));
-                    }
-
-                },
-                keyType);
-
-        } catch (std::logic_error& e) {
-            beammp_errorf("Error when getting key: {}", e.what());
-            return;
-        }
-    } else if (args.front() == "set") {
-        if (args.size() <= 3) {
-            beammp_errorf("'settings set' needs at least three arguments!");
-
-            Application::Console().WriteRaw("BeamMP-Server Console: " + std::string(sHelpString));
-            return;
-        }
-
-        try {
-
-            Settings::SettingsAccessControl acl = Application::Settings.getConsoleInputAccessMapping(ComposedKey { args.at(1), args.at(2) });
-            Settings::SettingsTypeVariant keyType = Application::Settings.get(acl.first);
-
-            std::visit(
-                overloaded {
-                    [&args](std::string keyValue) {
-                        Application::Settings.setConsoleInputAccessMapping(ComposedKey { args.at(1), args.at(2) }, std::string(args.at(3)));
-                        Application::Console().WriteRaw(fmt::format("{}::{} := {}", args.at(1), args.at(2), std::string(args.at(3))));
-                    },
-                    [&args](int keyValue) {
-                        Application::Settings.setConsoleInputAccessMapping(ComposedKey { args.at(1), args.at(2) }, std::stoi(args.at(3)));
-                        Application::Console().WriteRaw(fmt::format("{}::{} := {}", args.at(1), args.at(2), std::stoi(args.at(3))));
-                    },
-                    [&args](bool keyValue) {
-                        if (args.at(3) == "true") {
-                            Application::Settings.setConsoleInputAccessMapping(ComposedKey { args.at(1), args.at(2) }, true);
-                            Application::Console().WriteRaw(fmt::format("{}::{} := {}", args.at(1), args.at(2), "true"));
-                        } else if (args.at(3) == "false") {
-                            Application::Settings.setConsoleInputAccessMapping(ComposedKey { args.at(1), args.at(2) }, false);
-                            Application::Console().WriteRaw(fmt::format("{}::{} := {}", args.at(1), args.at(2), "false"));
-                        } else {
-                            beammp_errorf("Error when setting key: {}::{} : Unknown literal, use either 'true', or 'false' to set boolean values.", args.at(1), args.at(2));
-                        }
-                    }
-
-                },
-                keyType);
-
-        } catch (std::logic_error& e) {
-            beammp_errorf("Exception when setting settings key via console: {}", e.what());
-            return;
-        }
-
-    } else if (args.front() == "list") {
-        for (const auto& [composedKey, keyACL] : Application::Settings.getAccessControlMap()) {
-            // even though we have the value, we want to ignore it in order to make use of access
-            // control checks
-
-            if (keyACL.second != Settings::SettingsAccessMask::NO_ACCESS) {
-
-                try {
-
-                    Settings::SettingsAccessControl acl = Application::Settings.getConsoleInputAccessMapping(composedKey);
-                    Settings::SettingsTypeVariant keyType = Application::Settings.get(acl.first);
-
-                    std::visit(
-                        overloaded {
-                            [&composedKey](std::string keyValue) {
-                                Application::Console().WriteRaw(fmt::format("{} = {}", composedKey, keyValue));
-                            },
-                            [&composedKey](int keyValue) {
-                                Application::Console().WriteRaw(fmt::format("{} = {}", composedKey, keyValue));
-                            },
-                            [&composedKey](bool keyValue) {
-                                Application::Console().WriteRaw(fmt::format("{} = {}", composedKey, keyValue));
-                            }
-
-                        },
-                        keyType);
-                } catch (std::logic_error& e) {
-                    beammp_errorf("Error when getting key: {}", e.what());
-                }
-            }
-        }
-    } else {
-        beammp_errorf("Unknown argument for command 'settings': {}", args.front());
-
-        Application::Console().WriteRaw("BeamMP-Server Console: " + std::string(sHelpString));
         return;
     }
 }
@@ -497,7 +367,7 @@ void TConsole::Command_Say(const std::string& FullCmd) {
     if (FullCmd.size() > 3) {
         auto Message = FullCmd.substr(4);
         LuaAPI::MP::SendChatMessage(-1, Message);
-        if (!Application::Settings.getAsBool(Settings::Key::General_LogChat)) {
+        if (!Application::Settings.LogChat) {
             Application::Console().WriteRaw("Chat message sent!");
         }
     }
@@ -543,7 +413,7 @@ void TConsole::Command_Status(const std::string&, const std::vector<std::string>
         if (!Client.expired()) {
             auto Locked = Client.lock();
             CarCount += Locked->GetCarCount();
-            ConnectedCount += Locked->IsUDPConnected() ? 1 : 0;
+            ConnectedCount += Locked->IsConnected() ? 1 : 0;
             GuestCount += Locked->IsGuest() ? 1 : 0;
             SyncedCount += Locked->IsSynced() ? 1 : 0;
             SyncingCount += Locked->IsSyncing() ? 1 : 0;

src/THeartbeatThread.cpp

@@ -18,14 +18,15 @@
 
 #include "THeartbeatThread.h"
 
-#include "ChronoWrapper.h"
 #include "Client.h"
-#include "Common.h"
 #include "Http.h"
 //#include "SocketIO.h"
-#include <nlohmann/json.hpp>
+#include <rapidjson/document.h>
+#include <rapidjson/rapidjson.h>
 #include <sstream>
 
+namespace json = rapidjson;
+
 void THeartbeatThread::operator()() {
     RegisterThread("Heartbeat");
     std::string Body;
@@ -35,17 +36,15 @@ void THeartbeatThread::operator()() {
     static std::string Last;
 
     static std::chrono::high_resolution_clock::time_point LastNormalUpdateTime = std::chrono::high_resolution_clock::now();
-    static std::chrono::high_resolution_clock::time_point LastUpdateReminderTime = std::chrono::high_resolution_clock::now();
     bool isAuth = false;
-    std::chrono::high_resolution_clock::duration UpdateReminderTimePassed;
+    size_t UpdateReminderCounter = 0;
     while (!Application::IsShuttingDown()) {
-        auto UpdateReminderTimeout = ChronoWrapper::TimeFromStringWithLiteral(Application::Settings.getAsString(Settings::Key::Misc_UpdateReminderTime));
+        ++UpdateReminderCounter;
         Body = GenerateCall();
         // a hot-change occurs when a setting has changed, to update the backend of that change.
         auto Now = std::chrono::high_resolution_clock::now();
         bool Unchanged = Last == Body;
         auto TimePassed = (Now - LastNormalUpdateTime);
-        UpdateReminderTimePassed = (Now - LastUpdateReminderTime);
         auto Threshold = Unchanged ? 30 : 5;
         if (TimePassed < std::chrono::seconds(Threshold)) {
             std::this_thread::sleep_for(std::chrono::milliseconds(100));
@@ -55,23 +54,22 @@ void THeartbeatThread::operator()() {
 
         Last = Body;
         LastNormalUpdateTime = Now;
+        if (!Application::Settings.CustomIP.empty()) {
+            Body += "&ip=" + Application::Settings.CustomIP;
+        }
 
         auto Target = "/heartbeat";
         unsigned int ResponseCode = 0;
 
-        nlohmann::json Doc;
+        json::Document Doc;
         bool Ok = false;
         for (const auto& Url : Application::GetBackendUrlsInOrder()) {
-            T = Http::POST(Url + Target, Body, "application/json", &ResponseCode, { { "api-v", "2" } });
+            T = Http::POST(Url, 443, Target, Body, "application/x-www-form-urlencoded", &ResponseCode, { { "api-v", "2" } });
-
+            Doc.Parse(T.data(), T.size());
-            if (!Application::Settings.getAsBool(Settings::Key::General_Private)) {
+            if (Doc.HasParseError() || !Doc.IsObject()) {
-                beammp_debug("Backend response was: `" + T + "`");
+                if (!Application::Settings.Private) {
-            }
-
-            Doc = nlohmann::json::parse(T, nullptr, false);
-            if (Doc.is_discarded() || !Doc.is_object()) {
-                if (!Application::Settings.getAsBool(Settings::Key::General_Private)) {
                     beammp_trace("Backend response failed to parse as valid json");
+                    beammp_trace("Response was: `" + T + "`");
                 }
             } else if (ResponseCode != 200) {
                 beammp_errorf("Response code from the heartbeat: {}", ResponseCode);
@@ -90,18 +88,18 @@ void THeartbeatThread::operator()() {
         const auto MessageKey = "msg";
 
         if (Ok) {
-            if (Doc.contains(StatusKey) && Doc[StatusKey].is_string()) {
+            if (Doc.HasMember(StatusKey) && Doc[StatusKey].IsString()) {
-                Status = Doc[StatusKey];
+                Status = Doc[StatusKey].GetString();
             } else {
                 Ok = false;
             }
-            if (Doc.contains(CodeKey) && Doc[CodeKey].is_string()) {
+            if (Doc.HasMember(CodeKey) && Doc[CodeKey].IsString()) {
-                Code = Doc[CodeKey];
+                Code = Doc[CodeKey].GetString();
             } else {
                 Ok = false;
             }
-            if (Doc.contains(MessageKey) && Doc[MessageKey].is_string()) {
+            if (Doc.HasMember(MessageKey) && Doc[MessageKey].IsString()) {
-                Message = Doc[MessageKey];
+                Message = Doc[MessageKey].GetString();
             } else {
                 Ok = false;
             }
@@ -109,12 +107,12 @@ void THeartbeatThread::operator()() {
                 beammp_error("Missing/invalid json members in backend response");
             }
         } else {
-            if (!Application::Settings.getAsBool(Settings::Key::General_Private)) {
+            if (!Application::Settings.Private) {
                 beammp_warn("Backend failed to respond to a heartbeat. Your server may temporarily disappear from the server list. This is not an error, and will likely resolve itself soon. Direct connect will still work.");
             }
         }
 
-        if (Ok && !isAuth && !Application::Settings.getAsBool(Settings::Key::General_Private)) {
+        if (Ok && !isAuth && !Application::Settings.Private) {
             if (Status == "2000") {
                 beammp_info(("Authenticated! " + Message));
                 isAuth = true;
@@ -128,41 +126,35 @@ void THeartbeatThread::operator()() {
                 beammp_error("Backend REFUSED the auth key. Reason: " + Message);
             }
         }
-        if (isAuth || Application::Settings.getAsBool(Settings::Key::General_Private)) {
+        if (isAuth || Application::Settings.Private) {
             Application::SetSubsystemStatus("Heartbeat", Application::Status::Good);
         }
-        if (!Application::Settings.getAsBool(Settings::Key::Misc_ImScaredOfUpdates) && UpdateReminderTimePassed.count() > UpdateReminderTimeout.count()) {
+        if (!Application::Settings.HideUpdateMessages && UpdateReminderCounter % 5) {
-            LastUpdateReminderTime = std::chrono::high_resolution_clock::now();
             Application::CheckForUpdates();
         }
     }
 }
 
 std::string THeartbeatThread::GenerateCall() {
-    nlohmann::json Ret = {
+    std::stringstream Ret;
-        { "players", std::to_string(mServer.ClientCount()) },
-        { "maxplayers", std::to_string(Application::Settings.getAsInt(Settings::Key::General_MaxPlayers)) },
-        { "port", std::to_string(Application::Settings.getAsInt(Settings::Key::General_Port)) },
-        { "map", Application::Settings.getAsString(Settings::Key::General_Map) },
-        { "private", Application::Settings.getAsBool(Settings::Key::General_Private) ? "true" : "false" },
-        { "version", Application::ServerVersionString() },
-        { "clientversion", Application::ClientMinimumVersion().AsString() },
-        { "name", Application::Settings.getAsString(Settings::Key::General_Name) },
-        { "tags", Application::Settings.getAsString(Settings::Key::General_Tags) },
-        { "guests", Application::Settings.getAsBool(Settings::Key::General_AllowGuests) ? "true" : "false" },
-        { "modlist", mResourceManager.TrimmedList() },
-        { "modstotalsize", std::to_string(mResourceManager.MaxModSize()) },
-        { "modstotal", std::to_string(mResourceManager.ModsLoaded()) },
-        { "playerslist", GetPlayers() },
-        { "desc", Application::Settings.getAsString(Settings::Key::General_Description) }
-    };
 
-    lastCall = Ret.dump();
+    Ret << "uuid=" << Application::Settings.Key
-
+        << "&players=" << mServer.ClientCount()
-    // Add sensitive information here because value of lastCall is used for the information packet.
+        << "&maxplayers=" << Application::Settings.MaxPlayers
-    Ret["uuid"] = Application::Settings.getAsString(Settings::Key::General_AuthKey);
+        << "&port=" << Application::Settings.Port
-
+        << "&map=" << Application::Settings.MapName
-    return Ret.dump();
+        << "&private=" << (Application::Settings.Private ? "true" : "false")
+        << "&version=" << Application::ServerVersionString()
+        << "&clientversion=" << std::to_string(Application::ClientMajorVersion()) + ".0" // FIXME: Wtf.
+        << "&name=" << Application::Settings.ServerName
+        << "&tags=" << Application::Settings.ServerTags
+        << "&modlist=" << mResourceManager.TrimmedList()
+        << "&modstotalsize=" << mResourceManager.MaxModSize()
+        << "&modstotal=" << mResourceManager.ModsLoaded()
+        << "&playerslist=" << GetPlayers()
+        << "&desc=" << Application::Settings.ServerDesc
+        << "&pass=" << (Application::Settings.Password.empty() ? "false" : "true");
+    return Ret.str();
 }
 THeartbeatThread::THeartbeatThread(TResourceManager& ResourceManager, TServer& Server)
     : mResourceManager(ResourceManager)

src/TLuaEngine.cpp

@@ -18,48 +18,27 @@
 
 #include "TLuaEngine.h"
 #include "Client.h"
-#include "Common.h"
 #include "CustomAssert.h"
 #include "Http.h"
 #include "LuaAPI.h"
-#include "Profiling.h"
 #include "TLuaPlugin.h"
 #include "sol/object.hpp"
 
 #include <chrono>
 #include <condition_variable>
-#include <fmt/core.h>
 #include <nlohmann/json.hpp>
-#include <optional>
 #include <random>
-#include <sol/stack_core.hpp>
 #include <thread>
 #include <tuple>
 
 TLuaEngine* LuaAPI::MP::Engine;
 
-static sol::protected_function AddTraceback(sol::state_view StateView, sol::protected_function RawFn);
-
-static std::optional<sol::function> GetLuaHandler(sol::state_view StateView, const std::string Handler, const std::string EventName);
-
-static std::optional<sol::function> GetLuaHandler(sol::state_view StateView, const std::string Handler, const std::string EventName) {
-    if (!StateView)
-        return std::nullopt;
-    auto Res = StateView.safe_script("return " + Handler, sol::script_pass_on_error);
-    if (!Res.valid()) {
-        beammp_errorf("invalid handler for event \"{}\". handler: \"{}\"", EventName, Handler);
-    } else if (Res.get_type() == sol::type::function) {
-        return Res.get<sol::function>();
-    }
-    return std::nullopt;
-}
-
 TLuaEngine::TLuaEngine()
-    : mResourceServerPath(fs::path(Application::Settings.getAsString(Settings::Key::General_ResourceFolder)) / "Server") {
+    : mResourceServerPath(fs::path(Application::Settings.Resource) / "Server") {
     Application::SetSubsystemStatus("LuaEngine", Application::Status::Starting);
     LuaAPI::MP::Engine = this;
-    if (!fs::exists(Application::Settings.getAsString(Settings::Key::General_ResourceFolder))) {
+    if (!fs::exists(Application::Settings.Resource)) {
-        fs::create_directory(Application::Settings.getAsString(Settings::Key::General_ResourceFolder));
+        fs::create_directory(Application::Settings.Resource);
     }
     if (!fs::exists(mResourceServerPath)) {
         fs::create_directory(mResourceServerPath);
@@ -75,7 +54,7 @@ TLuaEngine::TLuaEngine()
 }
 
 TEST_CASE("TLuaEngine ctor & dtor") {
-    Application::Settings.set(Settings::Key::General_ResourceFolder, "beammp_server_test_resources");
+    Application::Settings.Resource = "beammp_server_test_resources";
     TLuaEngine engine;
     Application::GracefullyShutdown();
 }
@@ -84,7 +63,6 @@ void TLuaEngine::operator()() {
     RegisterThread("LuaEngine");
     Application::SetSubsystemStatus("LuaEngine", Application::Status::Good);
     // lua engine main thread
-    beammp_infof("Lua v{}.{}.{}", LUA_VERSION_MAJOR, LUA_VERSION_MINOR, LUA_VERSION_RELEASE);
     CollectAndInitPlugins();
     // now call all onInit's
     auto Futures = TriggerEvent("onInit", "");
@@ -287,7 +265,7 @@ std::vector<std::string> TLuaEngine::StateThreadData::GetStateTableKeys(const st
 
     for (size_t i = 0; i < keys.size(); ++i) {
         auto obj = current.get<sol::object>(keys.at(i));
-        if (obj.get_type() == sol::type::lua_nil) {
+        if (obj.get_type() == sol::type::nil) {
             // error
             break;
         } else if (i == keys.size() - 1) {
@@ -372,40 +350,27 @@ std::shared_ptr<TLuaResult> TLuaEngine::EnqueueScript(TLuaStateId StateID, const
     return mLuaStates.at(StateID)->EnqueueScript(Script);
 }
 
-std::shared_ptr<TLuaResult> TLuaEngine::EnqueueFunctionCall(TLuaStateId StateID, const std::string& FunctionName, const std::vector<TLuaValue>& Args, const std::string& EventName) {
+std::shared_ptr<TLuaResult> TLuaEngine::EnqueueFunctionCall(TLuaStateId StateID, const std::string& FunctionName, const std::vector<TLuaArgTypes>& Args) {
     std::unique_lock Lock(mLuaStatesMutex);
-    return mLuaStates.at(StateID)->EnqueueFunctionCall(FunctionName, Args, EventName);
+    return mLuaStates.at(StateID)->EnqueueFunctionCall(FunctionName, Args);
 }
 
 void TLuaEngine::CollectAndInitPlugins() {
     if (!fs::exists(mResourceServerPath)) {
         fs::create_directories(mResourceServerPath);
     }
-
+    for (const auto& Dir : fs::directory_iterator(mResourceServerPath)) {
-    std::vector<fs::path> PluginsEntries;
+        auto Path = Dir.path();
-    for (const auto& Entry : fs::directory_iterator(mResourceServerPath)) {
+        Path = fs::relative(Path);
-        if (Entry.is_directory()) {
+        if (!Dir.is_directory()) {
-            PluginsEntries.push_back(Entry);
+            beammp_error("\"" + Dir.path().string() + "\" is not a directory, skipping");
         } else {
-            beammp_error("\"" + Entry.path().string() + "\" is not a directory, skipping");
-        }
-    }
-
-    std::sort(PluginsEntries.begin(), PluginsEntries.end(), [](const fs::path& first, const fs::path& second) {
-        auto firstStr = first.string();
-        auto secondStr = second.string();
-        std::transform(firstStr.begin(), firstStr.end(), firstStr.begin(), ::tolower);
-        std::transform(secondStr.begin(), secondStr.end(), secondStr.begin(), ::tolower);
-        return firstStr < secondStr;
-    });
-
-    for (const auto& Dir : PluginsEntries) {
-        auto Path = fs::relative(Dir);
             TLuaPluginConfig Config { Path.stem().string() };
             FindAndParseConfig(Path, Config);
             InitializePlugin(Path, Config);
         }
     }
+}
 
 void TLuaEngine::InitializePlugin(const fs::path& Folder, const TLuaPluginConfig& Config) {
     beammp_assert(fs::exists(Folder));
@@ -447,7 +412,7 @@ void TLuaEngine::EnsureStateExists(TLuaStateId StateId, const std::string& Name,
         mLuaStates[StateId] = std::move(DataPtr);
         RegisterEvent("onInit", StateId, "onInit");
         if (!DontCallOnInit) {
-            auto Res = EnqueueFunctionCall(StateId, "onInit", {}, "onInit");
+            auto Res = EnqueueFunctionCall(StateId, "onInit", {});
             Res->WaitUntilReady();
             if (Res->Error && Res->ErrorMessage != TLuaEngine::BeamMPFnNotFoundError) {
                 beammp_lua_error("Calling \"onInit\" on \"" + StateId + "\" failed: " + Res->ErrorMessage);
@@ -465,64 +430,20 @@ std::set<std::string> TLuaEngine::GetEventHandlersForState(const std::string& Ev
     return mLuaEvents[EventName][StateId];
 }
 
-std::vector<sol::object> TLuaEngine::StateThreadData::JsonStringToArray(JsonString Str) {
-    auto LocalTable = Lua_JsonDecode(Str.value).as<std::vector<sol::object>>();
-    for (auto& value : LocalTable) {
-        if (value.is<std::string>() && value.as<std::string>() == BEAMMP_INTERNAL_NIL) {
-            value = sol::object {};
-        }
-    }
-    return LocalTable;
-}
-
 sol::table TLuaEngine::StateThreadData::Lua_TriggerGlobalEvent(const std::string& EventName, sol::variadic_args EventArgs) {
-    auto Table = mStateView.create_table();
+    auto Return = mEngine->TriggerEvent(EventName, mStateId, EventArgs);
-    int i = 1;
-    for (auto Arg : EventArgs) {
-        switch (Arg.get_type()) {
-        case sol::type::none:
-        case sol::type::userdata:
-        case sol::type::lightuserdata:
-        case sol::type::thread:
-        case sol::type::function:
-        case sol::type::poly:
-            Table.set(i, BEAMMP_INTERNAL_NIL);
-            beammp_warnf("Passed a value of type '{}' to TriggerGlobalEvent(\"{}\", ...). This type can not be serialized, and cannot be passed between states. It will arrive as <nil> in handlers.", sol::type_name(EventArgs.lua_state(), Arg.get_type()), EventName);
-            break;
-        case sol::type::lua_nil:
-            Table.set(i, BEAMMP_INTERNAL_NIL);
-            break;
-        case sol::type::string:
-        case sol::type::number:
-        case sol::type::boolean:
-        case sol::type::table:
-            Table.set(i, Arg);
-            break;
-        }
-        ++i;
-    }
-    JsonString Str { LuaAPI::MP::JsonEncode(Table) };
-    beammp_debugf("json: {}", Str.value);
-    auto Return = mEngine->TriggerEvent(EventName, mStateId, Str);
     auto MyHandlers = mEngine->GetEventHandlersForState(EventName, mStateId);
-
-    sol::variadic_results LocalArgs = JsonStringToArray(Str);
     for (const auto& Handler : MyHandlers) {
-        auto Res = GetLuaHandler(mStateView, Handler, EventName);
+        auto Fn = mStateView[Handler];
-        if (Res.has_value()) {
+        if (Fn.valid()) {
-            sol::function Fn = Res.value();
+            auto LuaResult = Fn(EventArgs);
-            Fn = AddTraceback(mStateView, Fn);
-
-            auto LuaResult = Fn(LocalArgs);
             auto Result = std::make_shared<TLuaResult>();
             if (LuaResult.valid()) {
                 Result->Error = false;
                 Result->Result = LuaResult;
             } else {
                 Result->Error = true;
-                sol::error Err = LuaResult;
+                Result->ErrorMessage = "Function result in TriggerGlobalEvent was invalid";
-                Result->ErrorMessage = Err.what();
-                beammp_errorf("An error occured while executing local event handler \"{}\" for event \"{}\": {}", Handler, EventName, Result->ErrorMessage);
             }
             Result->MarkAsReady();
             Return.push_back(Result);
@@ -546,13 +467,11 @@ sol::table TLuaEngine::StateThreadData::Lua_TriggerGlobalEvent(const std::string
             sol::state_view StateView(mState);
             sol::table Result = StateView.create_table();
             auto Vector = Self.get<std::vector<std::shared_ptr<TLuaResult>>>("ReturnValueImpl");
-            int i = 1;
             for (const auto& Value : Vector) {
                 if (!Value->Ready) {
                     return sol::lua_nil;
                 }
-                Result.set(i, Value->Result);
+                Result.add(Value->Result);
-                ++i;
             }
             return Result;
         });
@@ -562,15 +481,12 @@ sol::table TLuaEngine::StateThreadData::Lua_TriggerGlobalEvent(const std::string
 sol::table TLuaEngine::StateThreadData::Lua_TriggerLocalEvent(const std::string& EventName, sol::variadic_args EventArgs) {
     // TODO: make asynchronous?
     sol::table Result = mStateView.create_table();
-    int i = 1;
     for (const auto& Handler : mEngine->GetEventHandlersForState(EventName, mStateId)) {
-        auto Res = GetLuaHandler(mStateView, Handler, EventName);
+        auto Fn = mStateView[Handler];
-        if (Res.has_value()) {
+        if (Fn.valid() && Fn.get_type() == sol::type::function) {
-            sol::function Fn = Res.value();
             auto FnRet = Fn(EventArgs);
             if (FnRet.valid()) {
-                Result.set(i, FnRet);
+                Result.add(FnRet);
-                ++i;
             } else {
                 sol::error Err = FnRet;
                 beammp_lua_error(std::string("TriggerLocalEvent: ") + Err.what());
@@ -597,16 +513,6 @@ sol::table TLuaEngine::StateThreadData::Lua_GetPlayerIdentifiers(int ID) {
     }
 }
 
-std::variant<std::string, sol::nil_t> TLuaEngine::StateThreadData::Lua_GetPlayerRole(int ID) {
-    auto MaybeClient = GetClient(mEngine->Server(), ID);
-    if (MaybeClient) {
-        return MaybeClient.value().lock()->GetRoles();
-    } else {
-        return sol::nil;
-    }
-}
-
-
 sol::table TLuaEngine::StateThreadData::Lua_GetPlayers() {
     sol::table Result = mStateView.create_table();
     mEngine->Server().ForEachClient([&](std::weak_ptr<TClient> Client) -> bool {
@@ -752,7 +658,6 @@ static void AddToTable(sol::table& table, const std::string& left, const T& valu
 static void JsonDecodeRecursive(sol::state_view& StateView, sol::table& table, const std::string& left, const nlohmann::json& right) {
     switch (right.type()) {
     case nlohmann::detail::value_t::null:
-        AddToTable(table, left, sol::lua_nil_t {});
         return;
     case nlohmann::detail::value_t::object: {
         auto value = table.create();
@@ -881,17 +786,6 @@ TLuaEngine::StateThreadData::StateThreadData(const std::string& Name, TLuaStateI
         return Lua_GetPositionRaw(PID, VID);
     });
     MPTable.set_function("SendChatMessage", &LuaAPI::MP::SendChatMessage);
-    MPTable.set_function("SendNotification", [&](sol::variadic_args Args) {
-        if (Args.size() == 2) {
-            LuaAPI::MP::SendNotification(Args.get<int>(0), Args.get<std::string>(1), "", Args.get<std::string>(1));
-        } else if (Args.size() == 3) {
-            LuaAPI::MP::SendNotification(Args.get<int>(0), Args.get<std::string>(1), Args.get<std::string>(2), Args.get<std::string>(1));
-        } else if (Args.size() == 4) {
-            LuaAPI::MP::SendNotification(Args.get<int>(0), Args.get<std::string>(1), Args.get<std::string>(2), Args.get<std::string>(3));
-        } else {
-            beammp_lua_error("SendNotification expects 2, 3 or 4 arguments.");
-        }
-    });
     MPTable.set_function("GetPlayers", [&]() -> sol::table {
         return Lua_GetPlayers();
     });
@@ -906,9 +800,6 @@ TLuaEngine::StateThreadData::StateThreadData(const std::string& Name, TLuaStateI
     MPTable.set_function("GetPlayerIdentifiers", [&](int ID) -> sol::table {
         return Lua_GetPlayerIdentifiers(ID);
     });
-    MPTable.set_function("GetPlayerRole", [&](int ID) -> std::variant<std::string, sol::nil_t> {
-        return Lua_GetPlayerRole(ID);
-    });
     MPTable.set_function("Sleep", &LuaAPI::MP::Sleep);
     //  const std::string& EventName, size_t IntervalMS, int strategy
     MPTable.set_function("CreateEventTimer", [&](sol::variadic_args Args) {
@@ -936,43 +827,8 @@ TLuaEngine::StateThreadData::StateThreadData(const std::string& Name, TLuaStateI
         mEngine->CancelEventTimers(EventName, mStateId);
     });
     MPTable.set_function("Set", &LuaAPI::MP::Set);
-    MPTable.set_function("Get", &LuaAPI::MP::Get);
 
     auto UtilTable = StateView.create_named_table("Util");
-    UtilTable.set_function("LogDebug", [this](sol::variadic_args args) {
-        std::string ToPrint = "";
-        for (const auto& arg : args) {
-            ToPrint += LuaAPI::LuaToString(static_cast<const sol::object>(arg));
-            ToPrint += "\t";
-        }
-        if (Application::Settings.getAsBool(Settings::Key::General_Debug)) {
-            beammp_lua_log("DEBUG", mStateId, ToPrint);
-        }
-    });
-    UtilTable.set_function("LogInfo", [this](sol::variadic_args args) {
-        std::string ToPrint = "";
-        for (const auto& arg : args) {
-            ToPrint += LuaAPI::LuaToString(static_cast<const sol::object>(arg));
-            ToPrint += "\t";
-        }
-        beammp_lua_log("INFO", mStateId, ToPrint);
-    });
-    UtilTable.set_function("LogWarn", [this](sol::variadic_args args) {
-        std::string ToPrint = "";
-        for (const auto& arg : args) {
-            ToPrint += LuaAPI::LuaToString(static_cast<const sol::object>(arg));
-            ToPrint += "\t";
-        }
-        beammp_lua_log("WARN", mStateId, ToPrint);
-    });
-    UtilTable.set_function("LogError", [this](sol::variadic_args args) {
-        std::string ToPrint = "";
-        for (const auto& arg : args) {
-            ToPrint += LuaAPI::LuaToString(static_cast<const sol::object>(arg));
-            ToPrint += "\t";
-        }
-        beammp_lua_log("ERROR", mStateId, ToPrint);
-    });
     UtilTable.set_function("JsonEncode", &LuaAPI::MP::JsonEncode);
     UtilTable.set_function("JsonDecode", [this](const std::string& str) {
         return Lua_JsonDecode(str);
@@ -991,30 +847,6 @@ TLuaEngine::StateThreadData::StateThreadData(const std::string& Name, TLuaStateI
     UtilTable.set_function("RandomIntRange", [this](int64_t min, int64_t max) -> int64_t {
         return std::uniform_int_distribution(min, max)(mMersenneTwister);
     });
-    UtilTable.set_function("DebugExecutionTime", [this]() -> sol::table {
-        sol::state_view StateView(mState);
-        sol::table Result = StateView.create_table();
-        auto stats = mProfile.all_stats();
-        for (const auto& [name, stat] : stats) {
-            Result[name] = StateView.create_table();
-            Result[name]["mean"] = stat.mean;
-            Result[name]["stdev"] = stat.stdev;
-            Result[name]["min"] = stat.min;
-            Result[name]["max"] = stat.max;
-            Result[name]["n"] = stat.n;
-        }
-        return Result;
-    });
-    UtilTable.set_function("DebugStartProfile", [this](const std::string& name) {
-        mProfileStarts[name] = prof::now();
-    });
-    UtilTable.set_function("DebugStopProfile", [this](const std::string& name) {
-        if (!mProfileStarts.contains(name)) {
-            beammp_lua_errorf("DebugStopProfile('{}') failed, because a profile for '{}' wasn't started", name, name);
-            return;
-        }
-        mProfile.add_sample(name, prof::duration(mProfileStarts.at(name), prof::now()));
-    });
 
     auto HttpTable = StateView.create_named_table("Http");
     HttpTable.set_function("CreateConnection", [this](const std::string& host, uint16_t port) {
@@ -1028,8 +860,7 @@ TLuaEngine::StateThreadData::StateThreadData(const std::string& Name, TLuaStateI
         "MaxPlayers", 3,
         "Map", 4,
         "Name", 5,
-        "Description", 6,
+        "Description", 6);
-        "InformationPacket", 7);
 
     MPTable.create_named("CallStrategy",
         "BestEffort", CallStrategy::BestEffort,
@@ -1063,7 +894,7 @@ std::shared_ptr<TLuaResult> TLuaEngine::StateThreadData::EnqueueScript(const TLu
     return Result;
 }
 
-std::shared_ptr<TLuaResult> TLuaEngine::StateThreadData::EnqueueFunctionCallFromCustomEvent(const std::string& FunctionName, const std::vector<TLuaValue>& Args, const std::string& EventName, CallStrategy Strategy) {
+std::shared_ptr<TLuaResult> TLuaEngine::StateThreadData::EnqueueFunctionCallFromCustomEvent(const std::string& FunctionName, const std::vector<TLuaArgTypes>& Args, const std::string& EventName, CallStrategy Strategy) {
     // TODO: Document all this
     decltype(mStateFunctionQueue)::iterator Iter = mStateFunctionQueue.end();
     if (Strategy == CallStrategy::BestEffort) {
@@ -1085,12 +916,12 @@ std::shared_ptr<TLuaResult> TLuaEngine::StateThreadData::EnqueueFunctionCallFrom
     }
 }
 
-std::shared_ptr<TLuaResult> TLuaEngine::StateThreadData::EnqueueFunctionCall(const std::string& FunctionName, const std::vector<TLuaValue>& Args, const std::string& EventName) {
+std::shared_ptr<TLuaResult> TLuaEngine::StateThreadData::EnqueueFunctionCall(const std::string& FunctionName, const std::vector<TLuaArgTypes>& Args) {
     auto Result = std::make_shared<TLuaResult>();
     Result->StateId = mStateId;
     Result->Function = FunctionName;
     std::unique_lock Lock(mStateFunctionQueueMutex);
-    mStateFunctionQueue.push_back({ FunctionName, Result, Args, EventName });
+    mStateFunctionQueue.push_back({ FunctionName, Result, Args, "" });
     mStateFunctionQueueCond.notify_all();
     return Result;
 }
@@ -1099,21 +930,6 @@ void TLuaEngine::StateThreadData::RegisterEvent(const std::string& EventName, co
     mEngine->RegisterEvent(EventName, mStateId, FunctionName);
 }
 
-static sol::protected_function AddTraceback(sol::state_view StateView, sol::protected_function RawFn) {
-    StateView["INTERNAL_ERROR_HANDLER"] = [](lua_State *L) {
-        auto Error = sol::stack::get<std::optional<std::string>>(L);
-        std::string ErrorString = "<Unknown error>";
-        if (Error.has_value()) {
-            ErrorString = Error.value();
-        }
-        auto DebugTracebackFn = sol::state_view(L).globals().get<sol::table>("debug").get<sol::protected_function>("traceback");
-        // 2 = start collecting the trace one above the current function (1=current function)
-        std::string Traceback = DebugTracebackFn(ErrorString, 2);
-        return sol::stack::push(L, Traceback);
-    };
-    return sol::protected_function(RawFn, StateView["INTERNAL_ERROR_HANDLER"]);
-}
-
 void TLuaEngine::StateThreadData::operator()() {
     RegisterThread("Lua:" + mStateId);
     while (!Application::IsShuttingDown()) {
@@ -1168,7 +984,6 @@ void TLuaEngine::StateThreadData::operator()() {
                 std::chrono::milliseconds(500),
                 [&]() -> bool { return !mStateFunctionQueue.empty(); });
             if (NotExpired) {
-                auto ProfStart = prof::now();
                 auto TheQueuedFunction = std::move(mStateFunctionQueue.front());
                 mStateFunctionQueue.erase(mStateFunctionQueue.begin());
                 Lock.unlock();
@@ -1178,31 +993,27 @@ void TLuaEngine::StateThreadData::operator()() {
                 // TODO: Use TheQueuedFunction.EventName for errors, warnings, etc
                 Result->StateId = mStateId;
                 sol::state_view StateView(mState);
-
+                auto Fn = StateView[FnName];
-                auto Res = GetLuaHandler(StateView, FnName, TheQueuedFunction.EventName);
+                if (Fn.valid() && Fn.get_type() == sol::type::function) {
-                if (Res.has_value()) {
-                    sol::function Fn = Res.value();
                     std::vector<sol::object> LuaArgs;
                     for (const auto& Arg : Args) {
                         if (Arg.valueless_by_exception()) {
                             continue;
                         }
                         switch (Arg.index()) {
-                        case TLuaType::String:
+                        case TLuaArgTypes_String:
                             LuaArgs.push_back(sol::make_object(StateView, std::get<std::string>(Arg)));
                             break;
-                        case TLuaType::Int:
+                        case TLuaArgTypes_Int:
                             LuaArgs.push_back(sol::make_object(StateView, std::get<int>(Arg)));
                             break;
-                        case TLuaType::Json: {
+                        case TLuaArgTypes_VariadicArgs:
-                            auto LocalArgs = JsonStringToArray(std::get<JsonString>(Arg));
+                            LuaArgs.push_back(sol::make_object(StateView, std::get<sol::variadic_args>(Arg)));
-                            LuaArgs.insert(LuaArgs.end(), LocalArgs.begin(), LocalArgs.end());
                             break;
-                        }
+                        case TLuaArgTypes_Bool:
-                        case TLuaType::Bool:
                             LuaArgs.push_back(sol::make_object(StateView, std::get<bool>(Arg)));
                             break;
-                        case TLuaType::StringStringMap: {
+                        case TLuaArgTypes_StringStringMap: {
                             auto Map = std::get<std::unordered_map<std::string, std::string>>(Arg);
                             auto Table = StateView.create_table();
                             for (const auto& [k, v] : Map) {
@@ -1216,7 +1027,6 @@ void TLuaEngine::StateThreadData::operator()() {
                             break;
                         }
                     }
-                    Fn = AddTraceback(StateView, Fn);
                     auto Res = Fn(sol::as_args(LuaArgs));
                     if (Res.valid()) {
                         Result->Error = false;
@@ -1232,9 +1042,6 @@ void TLuaEngine::StateThreadData::operator()() {
                     Result->ErrorMessage = BeamMPFnNotFoundError; // special error kind that we can ignore later
                     Result->MarkAsReady();
                 }
-                auto ProfEnd = prof::now();
-                auto ProfDuration = prof::duration(ProfStart, ProfEnd);
-                mProfile.add_sample(FnName, ProfDuration);
             }
         }
     }

src/TNetwork.cpp

@@ -20,19 +20,14 @@
 #include "Client.h"
 #include "Common.h"
 #include "LuaAPI.h"
-#include "THeartbeatThread.h"
 #include "TLuaEngine.h"
-#include "TScopedTimer.h"
 #include "nlohmann/json.hpp"
 #include <CustomAssert.h>
 #include <Http.h>
 #include <array>
 #include <boost/asio/ip/address.hpp>
 #include <boost/asio/ip/address_v4.hpp>
-#include <boost/asio/ip/address_v6.hpp>
-#include <boost/asio/ip/v6_only.hpp>
 #include <cstring>
-#include <zlib.h>
 
 typedef boost::asio::detail::socket_option::integer<SOL_SOCKET, SO_RCVTIMEO> rcv_timeout_option;
 
@@ -85,8 +80,7 @@ TNetwork::TNetwork(TServer& Server, TPPSMonitor& PPSMonitor, TResourceManager& R
 
 void TNetwork::UDPServerMain() {
     RegisterThread("UDPServer");
-    // listen on all ipv6 addresses
+    ip::udp::endpoint UdpListenEndpoint(ip::address::from_string("0.0.0.0"), Application::Settings.Port);
-    ip::udp::endpoint UdpListenEndpoint(ip::make_address("::"), Application::Settings.getAsInt(Settings::Key::General_Port));
     boost::system::error_code ec;
     mUDPSock.open(UdpListenEndpoint.protocol(), ec);
     if (ec) {
@@ -94,12 +88,6 @@ void TNetwork::UDPServerMain() {
         std::this_thread::sleep_for(std::chrono::seconds(5));
         Application::GracefullyShutdown();
     }
-    // set IP_V6ONLY to false to allow both v4 and v6
-    boost::asio::ip::v6_only option(false);
-    mUDPSock.set_option(option, ec);
-    if (ec) {
-        beammp_warnf("Failed to unset IP_V6ONLY on UDP, only IPv6 will work: {}", ec.message());
-    }
     mUDPSock.bind(UdpListenEndpoint, ec);
     if (ec) {
         beammp_error("bind() failed: " + ec.message());
@@ -107,25 +95,15 @@ void TNetwork::UDPServerMain() {
         Application::GracefullyShutdown();
     }
     Application::SetSubsystemStatus("UDPNetwork", Application::Status::Good);
-    beammp_info(("Vehicle data network online on port ") + std::to_string(Application::Settings.getAsInt(Settings::Key::General_Port)) + (" with a Max of ")
+    beammp_info(("Vehicle data network online on port ") + std::to_string(Application::Settings.Port) + (" with a Max of ")
-        + std::to_string(Application::Settings.getAsInt(Settings::Key::General_MaxPlayers)) + (" Clients"));
+        + std::to_string(Application::Settings.MaxPlayers) + (" Clients"));
     while (!Application::IsShuttingDown()) {
         try {
-            ip::udp::endpoint remote_client_ep {};
+            ip::udp::endpoint client {};
-            std::vector<uint8_t> Data = UDPRcvFromClient(remote_client_ep);
+            std::vector<uint8_t> Data = UDPRcvFromClient(client); // Receives any data from Socket
-            if (Data.empty()) {
-                continue;
-            }
-            if (Data.size() == 1 && Data.at(0) == 'P') {
-                mUDPSock.send_to(const_buffer("P", 1), remote_client_ep, {}, ec);
-                // ignore errors
-                (void)ec;
-                continue;
-            }
             auto Pos = std::find(Data.begin(), Data.end(), ':');
-            if (Pos > Data.begin() + 2) {
+            if (Data.empty() || Pos > Data.begin() + 2)
                 continue;
-            }
             uint8_t ID = uint8_t(Data.at(0)) - 1;
             mServer.ForEachClient([&](std::weak_ptr<TClient> ClientPtr) -> bool {
                 std::shared_ptr<TClient> Client;
@@ -138,31 +116,16 @@ void TNetwork::UDPServerMain() {
                 }
 
                 if (Client->GetID() == ID) {
-                    // not initialized yet
+                    Client->SetUDPAddr(client);
-                    if (Client->GetUDPAddr() == ip::udp::endpoint {} || !Client->IsUDPConnected()) {
+                    Client->SetIsConnected(true);
-                        // same IP (just a sanity check)
-                        if (remote_client_ep.address() == Client->GetTCPSock().remote_endpoint().address()) {
-                            Client->SetUDPAddr(remote_client_ep);
-                            Client->SetIsUDPConnected(true);
-                            beammp_debugf("UDP connected for client {}", ID);
-                        } else {
-                            beammp_debugf("Denied initial UDP packet due to IP mismatch");
-                            return false;
-                        }
-                    }
-                    if (Client->GetUDPAddr() == remote_client_ep) {
                     Data.erase(Data.begin(), Data.begin() + 2);
                     mServer.GlobalParser(ClientPtr, std::move(Data), mPPSMonitor, *this);
-                    } else {
-                        beammp_debugf("Ignored UDP packet due to remote address mismatch");
-                        return false;
-                    }
                 }
 
                 return true;
             });
         } catch (const std::exception& e) {
-            beammp_warnf("Failed to receive/parse packet via UDP: {}", e.what());
+            beammp_error(("fatal: ") + std::string(e.what()));
         }
     }
 }
@@ -170,10 +133,7 @@ void TNetwork::UDPServerMain() {
 void TNetwork::TCPServerMain() {
     RegisterThread("TCPServer");
 
-    // listen on all ipv6 addresses
+    ip::tcp::endpoint ListenEp(ip::address::from_string("0.0.0.0"), Application::Settings.Port);
-    auto port = uint16_t(Application::Settings.getAsInt(Settings::Key::General_Port));
-    ip::tcp::endpoint ListenEp(ip::make_address("::"), port);
-    beammp_infof("Listening on 0.0.0.0:{0} and [::]:{0}", port);
     ip::tcp::socket Listener(mServer.IoCtx());
     boost::system::error_code ec;
     Listener.open(ListenEp.protocol(), ec);
@@ -181,16 +141,6 @@ void TNetwork::TCPServerMain() {
         beammp_errorf("Failed to open socket: {}", ec.message());
         return;
     }
-    // set IP_V6ONLY to false to allow both v4 and v6
-    boost::asio::ip::v6_only option(false);
-    Listener.set_option(option, ec);
-    if (ec) {
-        beammp_warnf("Failed to unset IP_V6ONLY on TCP, only IPv6 will work: {}", ec.message());
-    }
-#if defined(BEAMMP_FREEBSD)
-    beammp_warnf("WARNING: On FreeBSD, for IPv4 to work, you must run `sysctl net.inet6.ip6.v6only=0`!");
-    beammp_debugf("This is due to an annoying detail in the *BSDs: In the name of security, unsetting the IPV6_V6ONLY option does not work by default (but does not fail???), as it allows IPv4 mapped IPv6 like ::ffff:127.0.0.1, which they deem a security issue. For more information, see RFC 2553, section 3.7.");
-#endif
     socket_base::linger LingerOpt {};
     LingerOpt.enabled(false);
     Listener.set_option(LingerOpt, ec);
@@ -219,13 +169,13 @@ void TNetwork::TCPServerMain() {
             ip::tcp::endpoint ClientEp;
             ip::tcp::socket ClientSocket = Acceptor.accept(ClientEp, ec);
             if (ec) {
-                beammp_errorf("Failed to accept() new client: {}", ec.message());
+                beammp_errorf("failed to accept: {}", ec.message());
             }
             TConnection Conn { std::move(ClientSocket), ClientEp };
             std::thread ID(&TNetwork::Identify, this, std::move(Conn));
             ID.detach(); // TODO: Add to a queue and attempt to join periodically
         } catch (const std::exception& e) {
-            beammp_errorf("Exception in accept routine: {}", e.what());
+            beammp_error("fatal: " + std::string(e.what()));
         }
     } while (!Application::IsShuttingDown());
 }
@@ -251,28 +201,16 @@ void TNetwork::Identify(TConnection&& RawConnection) {
         if (Code == 'C') {
             Client = Authentication(std::move(RawConnection));
         } else if (Code == 'D') {
-            beammp_errorf("Old download packet detected - the client is wildly out of date, this will be ignored");
+            HandleDownload(std::move(RawConnection));
-            return;
         } else if (Code == 'P') {
             boost::system::error_code ec;
             write(RawConnection.Socket, buffer("P"), ec);
             return;
-        } else if (Code == 'I') {
-            const std::string Data = Application::Settings.getAsBool(Settings::Key::General_InformationPacket) ? THeartbeatThread::lastCall : "";
-
-            const auto Size = static_cast<int32_t>(Data.size());
-            std::vector<uint8_t> ToSend;
-            ToSend.resize(Data.size() + sizeof(Size));
-            std::memcpy(ToSend.data(), &Size, sizeof(Size));
-            std::memcpy(ToSend.data() + sizeof(Size), Data.data(), Data.size());
-
-            boost::system::error_code ec;
-            write(RawConnection.Socket, buffer(ToSend), ec);
         } else {
             beammp_errorf("Invalid code got in Identify: '{}'", Code);
         }
     } catch(const std::exception& e) {
-        beammp_errorf("Error during handling of code {} - client left in invalid state, closing socket: {}", Code, e.what());
+        beammp_errorf("Error during handling of code {} - client left in invalid state, closing socket", Code);
         boost::system::error_code ec;
         RawConnection.Socket.shutdown(socket_base::shutdown_both, ec);
         if (ec) {
@@ -285,7 +223,27 @@ void TNetwork::Identify(TConnection&& RawConnection) {
     }
 }
 
-
+void TNetwork::HandleDownload(TConnection&& Conn) {
+    char D;
+    boost::system::error_code ec;
+    read(Conn.Socket, buffer(&D, 1), ec);
+    if (ec) {
+        Conn.Socket.shutdown(socket_base::shutdown_both, ec);
+        // ignore ec
+        return;
+    }
+    auto ID = uint8_t(D);
+    mServer.ForEachClient([&](const std::weak_ptr<TClient>& ClientPtr) -> bool {
+        ReadLock Lock(mServer.GetClientMutex());
+        if (!ClientPtr.expired()) {
+            auto c = ClientPtr.lock();
+            if (c->GetID() == ID) {
+                c->SetDownSock(std::move(Conn.Socket));
+            }
+        }
+        return true;
+    });
+}
 
 std::string HashPassword(const std::string& str) {
     std::stringstream ret;
@@ -298,14 +256,8 @@ std::string HashPassword(const std::string& str) {
 
 std::shared_ptr<TClient> TNetwork::Authentication(TConnection&& RawConnection) {
     auto Client = CreateClient(std::move(RawConnection.Socket));
-    std::string ip = "";
+    Client->SetIdentifier("ip", RawConnection.SockAddr.address().to_string());
-    if (RawConnection.SockAddr.address().to_v6().is_v4_mapped()) {
+    beammp_tracef("This thread is ip {}", RawConnection.SockAddr.address().to_string());
-        ip = boost::asio::ip::make_address_v4(ip::v4_mapped_t::v4_mapped, RawConnection.SockAddr.address().to_v6()).to_string();
-    } else {
-        ip = RawConnection.SockAddr.address().to_string();
-    }
-    Client->SetIdentifier("ip", ip);
-    beammp_tracef("This thread is ip {} ({})", ip, RawConnection.SockAddr.address().to_v6().is_v4_mapped() ? "IPv4 mapped IPv6" : "IPv6");
 
     beammp_info("Identifying new ClientConnection...");
 
@@ -315,11 +267,10 @@ std::shared_ptr<TClient> TNetwork::Authentication(TConnection&& RawConnection) {
     if (Data.size() > 3 && std::equal(Data.begin(), Data.begin() + VC.size(), VC.begin(), VC.end())) {
         std::string ClientVersionStr(reinterpret_cast<const char*>(Data.data() + 2), Data.size() - 2);
         Version ClientVersion = Application::VersionStrToInts(ClientVersionStr + ".0");
-        Version MinClientVersion = Application::ClientMinimumVersion();
+        if (ClientVersion.major != Application::ClientMajorVersion()) {
-        if (Application::IsOutdated(ClientVersion, MinClientVersion)) {
+            beammp_errorf("Client tried to connect with version '{}', but only versions '{}.x.x' is allowed",
-            beammp_errorf("Client tried to connect with version '{}', but only versions >= {} are allowed",
+                ClientVersion.AsString(), Application::ClientMajorVersion());
-                ClientVersion.AsString(), MinClientVersion.AsString());
+            ClientKick(*Client, "Outdated Version!");
-            ClientKick(*Client, fmt::format("Outdated version, launcher version >={} required to join!", MinClientVersion.AsString()));
             return nullptr;
         }
     } else {
@@ -338,23 +289,18 @@ std::shared_ptr<TClient> TNetwork::Authentication(TConnection&& RawConnection) {
         return nullptr;
     }
 
-    std::string Key(reinterpret_cast<const char*>(Data.data()), Data.size());
+    std::string key(reinterpret_cast<const char*>(Data.data()), Data.size());
-    std::string AuthKey = Application::Settings.getAsString(Settings::Key::General_AuthKey);
-    std::string ClientIp = Client->GetIdentifiers().at("ip");
 
     nlohmann::json AuthReq{};
     std::string AuthResStr{};
     try {
         AuthReq = nlohmann::json {
-            { "key", Key },
+            { "key", key }
-            { "auth_key", AuthKey },
-            { "client_ip", ClientIp }
         };
 
         auto Target = "/pkToUser";
-
         unsigned int ResponseCode = 0;
-        AuthResStr = Http::POST(Application::GetBackendUrlForAuth() + Target, AuthReq.dump(), "application/json", &ResponseCode);
+        AuthResStr = Http::POST(Application::GetBackendUrlForAuth(), 443, Target, AuthReq.dump(), "application/json", &ResponseCode);
 
     } catch (const std::exception& e) {
         beammp_debugf("Invalid json sent by client, kicking: {}", e.what());
@@ -362,8 +308,6 @@ std::shared_ptr<TClient> TNetwork::Authentication(TConnection&& RawConnection) {
         return nullptr;
     }
 
-    beammp_debug("Response from authentication backend: " + AuthResStr);
-
     try {
         nlohmann::json AuthRes = nlohmann::json::parse(AuthResStr);
 
@@ -390,6 +334,22 @@ std::shared_ptr<TClient> TNetwork::Authentication(TConnection&& RawConnection) {
         return nullptr;
     }
 
+    if(!Application::Settings.Password.empty()) { // ask password
+        if(!TCPSend(*Client, StringToVector("S"))) {
+            // TODO: handle
+        }
+        beammp_info("Waiting for password");
+        Data = TCPRcv(*Client);
+        std::string Pass = std::string(reinterpret_cast<const char*>(Data.data()), Data.size());
+        if(Pass != HashPassword(Application::Settings.Password)) {
+            beammp_debug(Client->GetName() + " attempted to connect with a wrong password");
+            ClientKick(*Client, "Wrong password!");
+            return {};
+        } else {
+            beammp_debug(Client->GetName() + " used the correct password");
+        }
+    }
+
     beammp_debug("Name -> " + Client->GetName() + ", Guest -> " + std::to_string(Client->IsGuest()) + ", Roles -> " + Client->GetRoles());
     mServer.ForEachClient([&](const std::weak_ptr<TClient>& ClientPtr) -> bool {
         std::shared_ptr<TClient> Cl;
@@ -410,21 +370,10 @@ std::shared_ptr<TClient> TNetwork::Authentication(TConnection&& RawConnection) {
 
     auto Futures = LuaAPI::MP::Engine->TriggerEvent("onPlayerAuth", "", Client->GetName(), Client->GetRoles(), Client->IsGuest(), Client->GetIdentifiers());
     TLuaEngine::WaitForAll(Futures);
-    bool NotAllowed = false;
+    bool NotAllowed = std::any_of(Futures.begin(), Futures.end(),
-    bool BypassLimit = false;
+        [](const std::shared_ptr<TLuaResult>& Result) {
-
+            return !Result->Error && Result->Result.is<int>() && bool(Result->Result.as<int>());
-    for (const auto& Result : Futures) {
+        });
-        if (!Result->Error && Result->Result.is<int>()) {
-            auto Res = Result->Result.as<int>();
-
-            if (Res == 1) {
-                NotAllowed = true;
-                break;
-            } else if (Res == 2) {
-                BypassLimit = true;
-            }
-        }
-    }
     std::string Reason;
     bool NotAllowedWithReason = std::any_of(Futures.begin(), Futures.end(),
         [&Reason](const std::shared_ptr<TLuaResult>& Result) -> bool {
@@ -435,30 +384,20 @@ std::shared_ptr<TClient> TNetwork::Authentication(TConnection&& RawConnection) {
             return false;
         });
 
-    if (!NotAllowedWithReason && !Application::Settings.getAsBool(Settings::Key::General_AllowGuests) && Client->IsGuest()) { //! NotAllowedWithReason because this message has the lowest priority
+    if (NotAllowed) {
-        NotAllowedWithReason = true;
-        Reason = "No guests are allowed on this server! To join, sign up at: forum.beammp.com.";
-    }
-
-    if (!NotAllowed && !NotAllowedWithReason && mServer.ClientCount() >= size_t(Application::Settings.getAsInt(Settings::Key::General_MaxPlayers)) && !BypassLimit) {
-            NotAllowedWithReason = true;
-            Reason = "Server full!";
-    }
-
-    if (NotAllowedWithReason) {
-        ClientKick(*Client, Reason);
-    } else if (NotAllowed) {
         ClientKick(*Client, "you are not allowed on the server!");
+        return {};
+    } else if (NotAllowedWithReason) {
+        ClientKick(*Client, Reason);
+        return {};
     }
 
-    auto PostFutures = LuaAPI::MP::Engine->TriggerEvent("postPlayerAuth", "", NotAllowed || NotAllowedWithReason, Reason, Client->GetName(), Client->GetRoles(), Client->IsGuest(), Client->GetIdentifiers());
+    if (mServer.ClientCount() < size_t(Application::Settings.MaxPlayers)) {
-    // the post event is not cancellable so we dont wait for it
-    LuaAPI::MP::Engine->ReportErrors(PostFutures);
-
-    if (!NotAllowed && !NotAllowedWithReason) {
         beammp_info("Identification success");
         mServer.InsertClient(Client);
         TCPClient(Client);
+    } else {
+        ClientKick(*Client, "Server full!");
     }
 
     return Client;
@@ -555,17 +494,7 @@ std::vector<uint8_t> TNetwork::TCPRcv(TClient& c) {
     constexpr std::string_view ABG = "ABG:";
     if (Data.size() >= ABG.size() && std::equal(Data.begin(), Data.begin() + ABG.size(), ABG.begin(), ABG.end())) {
         Data.erase(Data.begin(), Data.begin() + ABG.size());
-        try {
         return DeComp(Data);
-        } catch (const InvalidDataError& ) {
-            beammp_errorf("Failed to decompress packet from a client. The receive failed and the client may be disconnected as a result");
-            // return empty -> error
-            return std::vector<uint8_t>();
-        } catch (const std::runtime_error& e) {
-            beammp_errorf("Failed to decompress packet from a client: {}. The server may be out of RAM! The receive failed and the client may be disconnected as a result", e.what());
-            // return empty -> error
-            return std::vector<uint8_t>();
-        }
     } else {
         return Data;
     }
@@ -656,7 +585,7 @@ void TNetwork::TCPClient(const std::weak_ptr<TClient>& c) {
 }
 
 void TNetwork::UpdatePlayer(TClient& Client) {
-    std::string Packet = ("Ss") + std::to_string(mServer.ClientCount()) + "/" + std::to_string(Application::Settings.getAsInt(Settings::Key::General_MaxPlayers)) + ":";
+    std::string Packet = ("Ss") + std::to_string(mServer.ClientCount()) + "/" + std::to_string(Application::Settings.MaxPlayers) + ":";
     mServer.ForEachClient([&](const std::weak_ptr<TClient>& ClientPtr) -> bool {
         ReadLock Lock(mServer.GetClientMutex());
         if (!ClientPtr.expired()) {
@@ -688,7 +617,6 @@ void TNetwork::OnDisconnect(const std::weak_ptr<TClient>& ClientPtr) {
         VehicleData = *LockedData.VehicleData;
     } // End Vehicle Data Lock Scope
     for (auto& v : VehicleData) {
-        LuaAPI::MP::Engine->ReportErrors(LuaAPI::MP::Engine->TriggerEvent("onVehicleDeleted", "", c.GetID(), v.ID()));
         Packet = "Od:" + std::to_string(c.GetID()) + "-" + std::to_string(v.ID());
         SendToAll(&c, StringToVector(Packet), false, true);
     }
@@ -702,7 +630,6 @@ void TNetwork::OnDisconnect(const std::weak_ptr<TClient>& ClientPtr) {
 }
 
 int TNetwork::OpenID() {
-    std::unique_lock OpenIDLock(mOpenIDMutex);
     int ID = 0;
     bool found;
     do {
@@ -732,7 +659,7 @@ void TNetwork::OnConnect(const std::weak_ptr<TClient>& c) {
     SyncResources(*LockedClient);
     if (LockedClient->IsDisconnected())
         return;
-    (void)Respond(*LockedClient, StringToVector("M" + Application::Settings.getAsString(Settings::Key::General_Map)), true); // Send the Map on connect
+    (void)Respond(*LockedClient, StringToVector("M" + Application::Settings.MapName), true); // Send the Map on connect
     beammp_info(LockedClient->GetName() + " : Connected");
     LuaAPI::MP::Engine->ReportErrors(LuaAPI::MP::Engine->TriggerEvent("onPlayerJoining", "", LockedClient->GetID()));
 }
@@ -767,11 +694,11 @@ void TNetwork::Parse(TClient& c, const std::vector<uint8_t>& Packet) {
     case 'S':
         if (SubCode == 'R') {
             beammp_debug("Sending Mod Info");
-            std::string ToSend = mResourceManager.NewFileList();
+            std::string ToSend = mResourceManager.FileList() + mResourceManager.FileSizes();
-            beammp_debugf("Mod Info: {}", ToSend);
+            if (ToSend.empty())
+                ToSend = "-";
             if (!TCPSend(c, StringToVector(ToSend))) {
-                ClientKick(c, "TCP Send 'SY' failed");
+                // TODO: error
-                return;
             }
         }
         return;
@@ -781,6 +708,8 @@ void TNetwork::Parse(TClient& c, const std::vector<uint8_t>& Packet) {
 }
 
 void TNetwork::SendFile(TClient& c, const std::string& UnsafeName) {
+    beammp_info(c.GetName() + " requesting : " + UnsafeName.substr(UnsafeName.find_last_of('/')));
+
     if (!fs::path(UnsafeName).has_filename()) {
         if (!TCPSend(c, StringToVector("CO"))) {
             // TODO: handle
@@ -789,7 +718,7 @@ void TNetwork::SendFile(TClient& c, const std::string& UnsafeName) {
         return;
     }
     auto FileName = fs::path(UnsafeName).filename().string();
-    FileName = Application::Settings.getAsString(Settings::Key::General_ResourceFolder) + "/Client/" + FileName;
+    FileName = Application::Settings.Resource + "/Client/" + FileName;
 
     if (!std::filesystem::exists(FileName)) {
         if (!TCPSend(c, StringToVector("CO"))) {
@@ -803,44 +732,89 @@ void TNetwork::SendFile(TClient& c, const std::string& UnsafeName) {
         // TODO: handle
     }
 
-    size_t Size = size_t(std::filesystem::file_size(FileName));
+    /// Wait for connections
-
+    int T = 0;
-    SendFileToClient(c, Size, FileName);
+    while (!c.GetDownSock().is_open() && T < 50) {
+        std::this_thread::sleep_for(std::chrono::milliseconds(100));
+        T++;
     }
 
-#if defined(BEAMMP_LINUX)
+    if (!c.GetDownSock().is_open()) {
-#include <cerrno>
+        beammp_error("Client doesn't have a download socket!");
-#include <cstring>
+        if (!c.IsDisconnected())
-#include <sys/sendfile.h>
+            c.Disconnect("Missing download socket");
-#include <unistd.h>
-#include <signal.h>
-#endif
-void TNetwork::SendFileToClient(TClient& c, size_t Size, const std::string& Name) {
-    TScopedTimer timer(fmt::format("Download of '{}' for client {}", Name, c.GetID()));
-#if defined(BEAMMP_LINUX)
-    signal(SIGPIPE, SIG_IGN);
-    // on linux, we can use sendfile(2)!
-    int fd = ::open(Name.c_str(), O_RDONLY);
-    if (fd < 0) {
-        beammp_errorf("Failed to open mod '{}' for sending, error: {}", Name, std::strerror(errno));
         return;
     }
-    // native handle, needed in order to make native syscalls with it
-    int socket = c.GetTCPSock().native_handle();
 
-    ssize_t ret = 0;
+    size_t Size = size_t(std::filesystem::file_size(FileName)), MSize = Size / 2;
-    auto ToSendTotal = Size;
+
-    auto Start = 0;
+    std::thread SplitThreads[2] {
-    while (ret < ssize_t(ToSendTotal)) {
+        std::thread([&] {
-        auto SysOffset = off_t(Start + size_t(ret));
+            RegisterThread("SplitLoad_0");
-        ret = sendfile(socket, fd, &SysOffset, ToSendTotal - size_t(ret));
+            SplitLoad(c, 0, MSize, false, FileName);
-        if (ret < 0) {
+        }),
-            beammp_errorf("Failed to send mod '{}' to client {}: {}", Name, c.GetID(), std::strerror(errno));
+        std::thread([&] {
-            return;
+            RegisterThread("SplitLoad_1");
+            SplitLoad(c, MSize, Size, true, FileName);
+        })
+    };
+
+    for (auto& SplitThread : SplitThreads) {
+        if (SplitThread.joinable()) {
+            SplitThread.join();
+        }
     }
 }
 
-#else
+static std::pair<size_t /* count */, size_t /* last chunk */> SplitIntoChunks(size_t FullSize, size_t ChunkSize) {
+    if (FullSize < ChunkSize) {
+        return { 0, FullSize };
+    }
+    size_t Count = FullSize / (FullSize / ChunkSize);
+    size_t LastChunkSize = FullSize - (Count * ChunkSize);
+    return { Count, LastChunkSize };
+}
+
+TEST_CASE("SplitIntoChunks") {
+    size_t FullSize;
+    size_t ChunkSize;
+    SUBCASE("Normal case") {
+        FullSize = 1234567;
+        ChunkSize = 1234;
+    }
+    SUBCASE("Zero original size") {
+        FullSize = 0;
+        ChunkSize = 100;
+    }
+    SUBCASE("Equal full size and chunk size") {
+        FullSize = 125;
+        ChunkSize = 125;
+    }
+    SUBCASE("Even split") {
+        FullSize = 10000;
+        ChunkSize = 100;
+    }
+    SUBCASE("Odd split") {
+        FullSize = 13;
+        ChunkSize = 2;
+    }
+    SUBCASE("Large sizes") {
+        FullSize = 10 * GB;
+        ChunkSize = 125 * MB;
+    }
+    auto [Count, LastSize] = SplitIntoChunks(FullSize, ChunkSize);
+    CHECK((Count * ChunkSize) + LastSize == FullSize);
+}
+
+const uint8_t* /* end ptr */ TNetwork::SendSplit(TClient& c, ip::tcp::socket& Socket, const uint8_t* DataPtr, size_t Size) {
+    if (TCPSendRaw(c, Socket, DataPtr, Size)) {
+        return DataPtr + Size;
+    } else {
+        return nullptr;
+    }
+}
+
+void TNetwork::SplitLoad(TClient& c, size_t Sent, size_t Size, bool D, const std::string& Name) {
     std::ifstream f(Name.c_str(), std::ios::binary);
     uint32_t Split = 125 * MB;
     std::vector<uint8_t> Data;
@@ -848,8 +822,11 @@ void TNetwork::SendFileToClient(TClient& c, size_t Size, const std::string& Name
         Data.resize(Split);
     else
         Data.resize(Size);
-    ip::tcp::socket* TCPSock = &c.GetTCPSock();
+    ip::tcp::socket* TCPSock { nullptr };
-    std::streamsize Sent = 0;
+    if (D)
+        TCPSock = &c.GetDownSock();
+    else
+        TCPSock = &c.GetTCPSock();
     while (!c.IsDisconnected() && Sent < Size) {
         size_t Diff = Size - Sent;
         if (Diff > Split) {
@@ -872,7 +849,6 @@ void TNetwork::SendFileToClient(TClient& c, size_t Size, const std::string& Name
             Sent += Diff;
         }
     }
-#endif
 }
 
 bool TNetwork::TCPSendRaw(TClient& C, ip::tcp::socket& socket, const uint8_t* Data, size_t Size) {
@@ -895,7 +871,7 @@ bool TNetwork::SendLarge(TClient& c, std::vector<uint8_t> Data, bool isSync) {
 
 bool TNetwork::Respond(TClient& c, const std::vector<uint8_t>& MSG, bool Rel, bool isSync) {
     char C = MSG.at(0);
-    if (Rel || C == 'W' || C == 'Y' || C == 'V' || C == 'E' || compressBound(MSG.size()) > 1024) {
+    if (Rel || C == 'W' || C == 'Y' || C == 'V' || C == 'E') {
         if (C == 'O' || C == 'T' || MSG.size() > 1000) {
             return SendLarge(c, MSG, isSync);
         } else {
@@ -978,7 +954,7 @@ void TNetwork::SendToAll(TClient* c, const std::vector<uint8_t>& Data, bool Self
         }
         if (Self || Client.get() != c) {
             if (Client->IsSynced() || Client->IsSyncing()) {
-                if (Rel || C == 'W' || C == 'Y' || C == 'V' || C == 'E' || compressBound(Data.size()) > 1024) {
+                if (Rel || C == 'W' || C == 'Y' || C == 'V' || C == 'E') {
                     if (C == 'O' || C == 'T' || Data.size() > 1000) {
                         if (Data.size() > 400) {
                             auto CompressedData = Data;
@@ -1006,7 +982,7 @@ void TNetwork::SendToAll(TClient* c, const std::vector<uint8_t>& Data, bool Self
 }
 
 bool TNetwork::UDPSend(TClient& Client, std::vector<uint8_t> Data) {
-    if (!Client.IsUDPConnected() || Client.IsDisconnected()) {
+    if (!Client.IsConnected() || Client.IsDisconnected()) {
         // this can happen if we try to send a packet to a client that is either
         // 1. not yet fully connected, or
         // 2. disconnected and not yet fully removed

src/TPPSMonitor.cpp

@@ -66,17 +66,14 @@ void TPPSMonitor::operator()() {
             }
             // kick on "no ping"
             if (c->SecondsSinceLastPing() > (20 * 60)) {
-                beammp_debugf("client {} ({}) timing out: {}", c->GetID(), c->GetName(), c->SecondsSinceLastPing());
+                beammp_debug("client " + std::string("(") + std::to_string(c->GetID()) + ")" + c->GetName() + " timing out: " + std::to_string(c->SecondsSinceLastPing()) + ", pps: " + Application::PPS());
-                TimedOutClients.push_back(c);
-            } else if (c->IsSynced() && c->SecondsSinceLastPing() > (1 * 60)) {
-                beammp_debugf("client {} ({}) timing out: {}", c->GetName(), c->GetID(), c->SecondsSinceLastPing());
                 TimedOutClients.push_back(c);
             }
 
             return true;
         });
         for (auto& ClientToKick : TimedOutClients) {
-            ClientToKick->Disconnect("Timeout");
+            Network().ClientKick(*ClientToKick, "Timeout (no ping for way too long)");
         }
         TimedOutClients.clear();
         if (C == 0 || mInternalPPS == 0) {

src/TResourceManager.cpp

@@ -17,20 +17,15 @@
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 #include "TResourceManager.h"
-#include "Common.h"
 
 #include <algorithm>
 #include <filesystem>
-#include <fmt/core.h>
-#include <ios>
-#include <nlohmann/json.hpp>
-#include <openssl/evp.h>
 
 namespace fs = std::filesystem;
 
 TResourceManager::TResourceManager() {
     Application::SetSubsystemStatus("ResourceManager", Application::Status::Starting);
-    std::string Path = Application::Settings.getAsString(Settings::Key::General_ResourceFolder) + "/Client";
+    std::string Path = Application::Settings.Resource + "/Client";
     if (!fs::exists(Path))
         fs::create_directories(Path);
     for (const auto& entry : fs::directory_iterator(Path)) {
@@ -57,85 +52,3 @@ TResourceManager::TResourceManager() {
 
     Application::SetSubsystemStatus("ResourceManager", Application::Status::Good);
 }
-
-std::string TResourceManager::NewFileList() const {
-    return mMods.dump();
-}
-void TResourceManager::RefreshFiles() {
-    mMods.clear();
-    std::unique_lock Lock(mModsMutex);
-
-    std::string Path = Application::Settings.getAsString(Settings::Key::General_ResourceFolder) + "/Client";
-    for (const auto& entry : fs::directory_iterator(Path)) {
-        std::string File(entry.path().string());
-
-        if (entry.path().extension() != ".zip" || std::filesystem::is_directory(entry.path())) {
-            beammp_warnf("'{}' is not a ZIP file and will be ignored", File);
-            continue;
-        }
-
-        try {
-            EVP_MD_CTX* mdctx;
-            const EVP_MD* md;
-            uint8_t sha256_value[EVP_MAX_MD_SIZE];
-            md = EVP_sha256();
-            if (md == nullptr) {
-                throw std::runtime_error("EVP_sha256() failed");
-            }
-
-            mdctx = EVP_MD_CTX_new();
-            if (mdctx == nullptr) {
-                throw std::runtime_error("EVP_MD_CTX_new() failed");
-            }
-            if (!EVP_DigestInit_ex2(mdctx, md, NULL)) {
-                EVP_MD_CTX_free(mdctx);
-                throw std::runtime_error("EVP_DigestInit_ex2() failed");
-            }
-
-            std::ifstream stream(File, std::ios::binary);
-
-            const size_t FileSize = std::filesystem::file_size(File);
-            size_t Read = 0;
-            std::vector<char> Data;
-            while (Read < FileSize) {
-                Data.resize(size_t(std::min<size_t>(FileSize - Read, 4096)));
-                size_t RealDataSize = Data.size();
-                stream.read(Data.data(), std::streamsize(Data.size()));
-                if (stream.eof() || stream.fail()) {
-                    RealDataSize = size_t(stream.gcount());
-                }
-                Data.resize(RealDataSize);
-                if (RealDataSize == 0) {
-                    break;
-                }
-                if (RealDataSize > 0 && !EVP_DigestUpdate(mdctx, Data.data(), Data.size())) {
-                    EVP_MD_CTX_free(mdctx);
-                    throw std::runtime_error("EVP_DigestUpdate() failed");
-                }
-                Read += RealDataSize;
-            }
-            unsigned int sha256_len = 0;
-            if (!EVP_DigestFinal_ex(mdctx, sha256_value, &sha256_len)) {
-                EVP_MD_CTX_free(mdctx);
-                throw std::runtime_error("EVP_DigestFinal_ex() failed");
-            }
-            EVP_MD_CTX_free(mdctx);
-
-            stream.close();
-
-            std::string result;
-            for (size_t i = 0; i < sha256_len; i++) {
-                result += fmt::format("{:02x}", sha256_value[i]);
-            }
-            beammp_debugf("sha256('{}'): {}", File, result);
-            mMods.push_back(nlohmann::json {
-                { "file_name", std::filesystem::path(File).filename() },
-                { "file_size", std::filesystem::file_size(File) },
-                { "hash_algorithm", "sha256" },
-                { "hash", result },
-            });
-        } catch (const std::exception& e) {
-            beammp_errorf("Sha256 hashing of '{}' failed: {}", File, e.what());
-        }
-    }
-}

src/TServer.cpp

@@ -20,7 +20,6 @@
 #include "Client.h"
 #include "Common.h"
 #include "CustomAssert.h"
-#include "TLuaEngine.h"
 #include "TNetwork.h"
 #include "TPPSMonitor.h"
 #include <TLuaPlugin.h>
@@ -124,6 +123,17 @@ TEST_CASE("GetPidVid") {
 TServer::TServer(const std::vector<std::string_view>& Arguments) {
     beammp_info("BeamMP Server v" + Application::ServerVersionString());
     Application::SetSubsystemStatus("Server", Application::Status::Starting);
+    if (Arguments.size() > 1) {
+        Application::Settings.CustomIP = Arguments[0];
+        size_t n = std::count(Application::Settings.CustomIP.begin(), Application::Settings.CustomIP.end(), '.');
+        auto p = Application::Settings.CustomIP.find_first_not_of(".0123456789");
+        if (p != std::string::npos || n != 3 || Application::Settings.CustomIP.substr(0, 3) == "127") {
+            Application::Settings.CustomIP.clear();
+            beammp_warn("IP Specified is invalid! Ignoring");
+        } else {
+            beammp_info("server started with custom IP");
+        }
+    }
     Application::SetSubsystemStatus("Server", Application::Status::Good);
 }
 
@@ -138,6 +148,7 @@ void TServer::RemoveClient(const std::weak_ptr<TClient>& WeakClientPtr) {
     beammp_assert(LockedClientPtr != nullptr);
     TClient& Client = *LockedClientPtr;
     beammp_debug("removing client " + Client.GetName() + " (" + std::to_string(ClientCount()) + ")");
+    // TODO: Send delete packets for all cars
     Client.ClearCars();
     WriteLock Lock(mClientsMutex);
     mClients.erase(WeakClientPtr.lock());
@@ -165,19 +176,7 @@ void TServer::GlobalParser(const std::weak_ptr<TClient>& Client, std::vector<uin
     constexpr std::string_view ABG = "ABG:";
     if (Packet.size() >= ABG.size() && std::equal(Packet.begin(), Packet.begin() + ABG.size(), ABG.begin(), ABG.end())) {
         Packet.erase(Packet.begin(), Packet.begin() + ABG.size());
-        try {
         Packet = DeComp(Packet);
-        } catch (const InvalidDataError& ) {
-            auto LockedClient = Client.lock();
-            beammp_errorf("Failed to decompress packet from client {}. The client sent invalid data and will now be disconnected.", LockedClient->GetID());
-            Network.ClientKick(*LockedClient, "Sent invalid compressed packet (this is likely a bug on your end)");
-            return;
-        } catch (const std::runtime_error& e) {
-            auto LockedClient = Client.lock();
-            beammp_errorf("Failed to decompress packet from client {}: {}. The server might be out of RAM! The client will now be disconnected.", LockedClient->GetID(), e.what());
-            Network.ClientKick(*LockedClient, "Decompression failed (likely a server-side problem)");
-            return;
-        }
     }
     if (Packet.empty()) {
         return;
@@ -235,24 +234,23 @@ void TServer::GlobalParser(const std::weak_ptr<TClient>& Client, std::vector<uin
         auto Futures = LuaAPI::MP::Engine->TriggerEvent("onChatMessage", "", LockedClient->GetID(), LockedClient->GetName(), Message);
         TLuaEngine::WaitForAll(Futures);
         LogChatMessage(LockedClient->GetName(), LockedClient->GetID(), PacketAsString.substr(PacketAsString.find(':', 3) + 1));
-        bool Rejected = std::any_of(Futures.begin(), Futures.end(),
+        if (std::any_of(Futures.begin(), Futures.end(),
                 [](const std::shared_ptr<TLuaResult>& Elem) {
                     return !Elem->Error
                         && Elem->Result.is<int>()
                         && bool(Elem->Result.as<int>());
-            });
+                })) {
-        if (!Rejected) {
+            break;
+        }
         std::string SanitizedPacket = fmt::format("C:{}: {}", LockedClient->GetName(), Message);
         Network.SendToAll(nullptr, StringToVector(SanitizedPacket), true, true);
-        }
-        auto PostFutures = LuaAPI::MP::Engine->TriggerEvent("postChatMessage", "", !Rejected, LockedClient->GetID(), LockedClient->GetName(), Message);
-        LuaAPI::MP::Engine->ReportErrors(PostFutures);
         return;
     }
     case 'E':
         HandleEvent(*LockedClient, StringPacket);
         return;
     case 'N':
+        beammp_trace("got 'N' packet (" + std::to_string(Packet.size()) + ")");
         Network.SendToAll(LockedClient.get(), Packet, false, true);
         return;
     case 'Z': // position packet
@@ -299,7 +297,7 @@ bool TServer::ShouldSpawn(TClient& c, const std::string& CarJson, int ID) {
         c.SetUnicycleID(ID);
         return true;
     } else {
-        return c.GetCarCount() < Application::Settings.getAsInt(Settings::Key::General_MaxCars);
+        return c.GetCarCount() < Application::Settings.MaxCars;
     }
 }
 
@@ -327,26 +325,19 @@ void TServer::ParseVehicle(TClient& c, const std::string& Pckt, TNetwork& Networ
                     return !Result->Error && Result->Result.is<int>() && Result->Result.as<int>() != 0;
                 });
 
-            bool SpawnConfirmed = false;
             if (ShouldSpawn(c, CarJson, CarID) && !ShouldntSpawn) {
                 c.AddNewCar(CarID, Packet);
                 Network.SendToAll(nullptr, StringToVector(Packet), true, true);
-                SpawnConfirmed = true;
             } else {
                 if (!Network.Respond(c, StringToVector(Packet), true)) {
                     // TODO: handle
                 }
                 std::string Destroy = "Od:" + std::to_string(c.GetID()) + "-" + std::to_string(CarID);
-                LuaAPI::MP::Engine->ReportErrors(LuaAPI::MP::Engine->TriggerEvent("onVehicleDeleted", "", c.GetID(), CarID));
                 if (!Network.Respond(c, StringToVector(Destroy), true)) {
                     // TODO: handle
                 }
                 beammp_debugf("{} (force : car limit/lua) removed ID {}", c.GetName(), CarID);
-                SpawnConfirmed = false;
             }
-            auto PostFutures = LuaAPI::MP::Engine->TriggerEvent("postVehicleSpawn", "", SpawnConfirmed, c.GetID(), CarID, Packet.substr(3));
-            // the post event is not cancellable so we dont wait for it
-            LuaAPI::MP::Engine->ReportErrors(PostFutures);
         }
         return;
     case 'c': {
@@ -365,26 +356,18 @@ void TServer::ParseVehicle(TClient& c, const std::string& Pckt, TNetwork& Networ
 
             auto FoundPos = Packet.find('{');
             FoundPos = FoundPos == std::string::npos ? 0 : FoundPos; // attempt at sanitizing this
-            bool Allowed = false;
             if ((c.GetUnicycleID() != VID || IsUnicycle(c, Packet.substr(FoundPos)))
                 && !ShouldntAllow) {
                 Network.SendToAll(&c, StringToVector(Packet), false, true);
                 Apply(c, VID, Packet);
-                Allowed = true;
             } else {
                 if (c.GetUnicycleID() == VID) {
                     c.SetUnicycleID(-1);
                 }
                 std::string Destroy = "Od:" + std::to_string(c.GetID()) + "-" + std::to_string(VID);
                 Network.SendToAll(nullptr, StringToVector(Destroy), true, true);
-                LuaAPI::MP::Engine->ReportErrors(LuaAPI::MP::Engine->TriggerEvent("onVehicleDeleted", "", c.GetID(), VID));
                 c.DeleteCar(VID);
-                Allowed = false;
             }
-
-            auto PostFutures = LuaAPI::MP::Engine->TriggerEvent("postVehicleEdited", "", Allowed, c.GetID(), VID, Packet.substr(3));
-            // the post event is not cancellable so we dont wait for it
-            LuaAPI::MP::Engine->ReportErrors(PostFutures);
         }
         return;
     }
@@ -420,35 +403,13 @@ void TServer::ParseVehicle(TClient& c, const std::string& Pckt, TNetwork& Networ
         }
         return;
     }
-    case 't': {
+    case 't':
         beammp_trace(std::string(("got 'Ot' packet: '")) + Packet + ("' (") + std::to_string(Packet.size()) + (")"));
-        auto MaybePidVid = GetPidVid(Data.substr(0, Data.find(':', 1)));
-        if (MaybePidVid) {
-            std::tie(PID, VID) = MaybePidVid.value();
-        }
-        if (PID != -1 && VID != -1 && PID == c.GetID()) {
-            Network.SendToAll(&c, StringToVector(Packet), false, true);
-        }
-        return;
-    }
-    case 'm': {
         Network.SendToAll(&c, StringToVector(Packet), false, true);
         return;
-    }
+    case 'm':
-    case 'p': {
+        Network.SendToAll(&c, StringToVector(Packet), true, true);
-        beammp_trace(std::string(("got 'Op' packet: '")) + Packet + ("' (") + std::to_string(Packet.size()) + (")"));
-        auto MaybePidVid = GetPidVid(Data.substr(0, Data.find(':', 1)));
-        if (MaybePidVid) {
-            std::tie(PID, VID) = MaybePidVid.value();
-        }
-
-        if (PID != -1 && VID != -1 && PID == c.GetID()) {
-            Data = Data.substr(Data.find('['));
-            LuaAPI::MP::Engine->ReportErrors(LuaAPI::MP::Engine->TriggerEvent("onVehiclePaintChanged", "", c.GetID(), VID, Data));
-            Network.SendToAll(&c, StringToVector(Packet), false, true);
-        }
         return;
-    }
     default:
         beammp_trace(std::string(("possibly not implemented: '") + Packet + ("' (") + std::to_string(Packet.size()) + (")")));
         return;

src/main.cpp

@@ -20,7 +20,6 @@
 #include "Common.h"
 #include "Http.h"
 #include "LuaAPI.h"
-#include "Settings.h"
 #include "SignalHandling.h"
 #include "TConfig.h"
 #include "THeartbeatThread.h"
@@ -31,7 +30,6 @@
 #include "TResourceManager.h"
 #include "TServer.h"
 
-#include <cstdint>
 #include <iostream>
 #include <thread>
 
@@ -42,9 +40,6 @@ USAGE:
 ARGUMENTS:
     --help              
                         Displays this help and exits.
-    --port=1234
-                        Sets the server's listening TCP and
-                        UDP port. Overrides ENV and ServerConfig.
     --config=/path/to/ServerConfig.toml
                         Absolute or relative path to the 
                         Server Config file, including the
@@ -96,7 +91,6 @@ int BeamMPServerMain(MainArguments Arguments) {
     Parser.RegisterArgument({ "help" }, ArgsParser::NONE);
     Parser.RegisterArgument({ "version" }, ArgsParser::NONE);
     Parser.RegisterArgument({ "config" }, ArgsParser::HAS_VALUE);
-    Parser.RegisterArgument({ "port" }, ArgsParser::HAS_VALUE);
     Parser.RegisterArgument({ "working-directory" }, ArgsParser::HAS_VALUE);
     Parser.Parse(Arguments.List);
     if (!Parser.Verify()) {
@@ -141,24 +135,6 @@ int BeamMPServerMain(MainArguments Arguments) {
         }
         return 1;
     }
-
-    // override port if provided via arguments
-    if (Parser.FoundArgument({ "port" })) {
-        auto Port = Parser.GetValueOfArgument({ "port" });
-        if (Port.has_value()) {
-            auto P = int(std::strtoul(Port.value().c_str(), nullptr, 10));
-            if (P == 0 || P < 0 || P > UINT16_MAX) {
-                beammp_errorf("Custom port requested via --port is invalid: '{}'", Port.value());
-                return 1;
-            } else {
-                Application::Settings.set(Settings::Key::General_Port, P);
-                beammp_info("Custom port requested via commandline arguments: " + Port.value());
-            }
-        }
-    }
-
-    Config.PrintDebug();
-
     Application::InitializeConsole();
     Application::Console().StartLoggingToFile();
 
@@ -166,9 +142,6 @@ int BeamMPServerMain(MainArguments Arguments) {
 
     SetupSignalHandlers();
 
-    Settings settings {};
-    beammp_infof("Server name set in new impl: {}", settings.getAsString(Settings::Key::General_Name));
-
     bool Shutdown = false;
     Application::RegisterShutdownHandler([&Shutdown] {
         beammp_info("If this takes too long, you can press Ctrl+C repeatedly to force a shutdown.");
@@ -190,7 +163,6 @@ int BeamMPServerMain(MainArguments Arguments) {
 
     beammp_trace("Running in debug mode on a debug build");
     TResourceManager ResourceManager;
-    ResourceManager.RefreshFiles();
     TPPSMonitor PPSMonitor(Server);
     THeartbeatThread Heartbeat(ResourceManager, Server);
     TNetwork Network(Server, PPSMonitor, ResourceManager);
@@ -198,7 +170,11 @@ int BeamMPServerMain(MainArguments Arguments) {
     PPSMonitor.SetNetwork(Network);
     Application::CheckForUpdates();
 
-    TPluginMonitor PluginMonitor(fs::path(Application::Settings.getAsString(Settings::Key::General_ResourceFolder)) / "Server", LuaEngine);
+    TPluginMonitor PluginMonitor(fs::path(Application::Settings.Resource) / "Server", LuaEngine);
+
+    if (Application::Settings.HTTPServerEnabled) {
+        Http::Server::THttpServerInstance HttpServerInstance {};
+    }
 
     Application::SetSubsystemStatus("Main", Application::Status::Good);
     RegisterThread("Main(Waiting)");

test/Server/JsonTests/main.lua

@@ -1,66 +0,0 @@
-local function assert_eq(x, y, explain)
-	if x ~= y then
-		print("assertion '"..explain.."' failed:\n\tgot:\t", x, "\n\texpected:", y)
-	end
-end
-
----@param o1 any|table First object to compare
----@param o2 any|table Second object to compare
----@param ignore_mt boolean True to ignore metatables (a recursive function to tests tables inside tables)
-function equals(o1, o2, ignore_mt)
-    if o1 == o2 then return true end
-    local o1Type = type(o1)
-    local o2Type = type(o2)
-    if o1Type ~= o2Type then return false end
-    if o1Type ~= 'table' then return false end
-
-    if not ignore_mt then
-        local mt1 = getmetatable(o1)
-        if mt1 and mt1.__eq then
-            --compare using built in method
-            return o1 == o2
-        end
-    end
-
-    local keySet = {}
-
-    for key1, value1 in pairs(o1) do
-        local value2 = o2[key1]
-        if value2 == nil or equals(value1, value2, ignore_mt) == false then
-            return false
-        end
-        keySet[key1] = true
-    end
-
-    for key2, _ in pairs(o2) do
-        if not keySet[key2] then return false end
-    end
-    return true
-end
-
-
-local function assert_table_eq(x, y, explain)
-	if not equals(x, y, true) then
-		print("assertion '"..explain.."' failed:\n\tgot:\t", x, "\n\texpected:", y)
-	end
-end
-
-assert_eq(Util.JsonEncode({1, 2, 3, 4, 5}), "[1,2,3,4,5]", "table to array")
-assert_eq(Util.JsonEncode({"a", 1, 2, 3, 4, 5}), '["a",1,2,3,4,5]', "table to array")
-assert_eq(Util.JsonEncode({"a", 1, 2.0, 3, 4, 5}), '["a",1,2.0,3,4,5]', "table to array")
-assert_eq(Util.JsonEncode({hello="world", john={doe = 1, jane = 2.5, mike = {2, 3, 4}}, dave={}}), '{"dave":{},"hello":"world","john":{"doe":1,"jane":2.5,"mike":[2,3,4]}}', "table to obj")
-assert_eq(Util.JsonEncode({a = nil}), "{}", "null obj member")
-assert_eq(Util.JsonEncode({1, nil, 3}), "[1,3]", "null array member")
-assert_eq(Util.JsonEncode({}), "{}", "empty array/table")
-assert_eq(Util.JsonEncode({1234}), "[1234]", "int")
-assert_eq(Util.JsonEncode({1234.0}), "[1234.0]", "double")
-
-assert_table_eq(Util.JsonDecode("[1,2,3,4,5]"), {1, 2, 3, 4, 5}, "decode table to array")
-assert_table_eq(Util.JsonDecode('["a",1,2,3,4,5]'), {"a", 1, 2, 3, 4, 5}, "decode table to array")
-assert_table_eq(Util.JsonDecode('["a",1,2.0,3,4,5]'), {"a", 1, 2.0, 3, 4, 5}, "decode table to array")
-assert_table_eq(Util.JsonDecode('{"dave":{},"hello":"world","john":{"doe":1,"jane":2.5,"mike":[2,3,4]}}'), {hello="world", john={doe = 1, jane = 2.5, mike = {2, 3, 4}}, dave={}}, "decode table to obj")
-assert_table_eq(Util.JsonDecode("{}"), {a = nil}, "decode null obj member")
-assert_table_eq(Util.JsonDecode("[1,3]"), {1, 3}, "decode null array member")
-assert_table_eq(Util.JsonDecode("{}"), {}, "decode empty array/table")
-assert_table_eq(Util.JsonDecode("[1234]"), {1234}, "decode int")
-assert_table_eq(Util.JsonDecode("[1234.0]"), {1234.0}, "decode double")

vcpkg.json

@@ -14,6 +14,6 @@
     "openssl",
     "rapidjson",
     "sol2",
-    "curl"
+    "toml11"
   ]
 }