BeamMP/BeamMP-Server
1
0
Fork 0
mirror of https://github.com/BeamMP/BeamMP-Server.git synced 2026-04-04 06:46:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

add owner check to other vehicle packets

Browse Source
This commit is contained in:
20dka
2022-11-04 23:40:52 +01:00
committed by Lion Kortlepel
parent 9acb6951d6
commit 69726a9b03
2 changed files with 40 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
src/TServer.cpp
View File

@@ -152,8 +152,11 @@ void TServer::GlobalParser(const std::weak_ptr<TClient>& Client, std::vector<uin
// V to Y
if (Code <= 89 && Code >= 86) {
PPSMonitor.IncrementInternalPPS();
Network.SendToAll(LockedClient.get(), Packet, false, false);
if (HandleVehicleUpdate(*LockedClient, StringPacket)){
Network.SendToAll(LockedClient.get(), Packet, false, false);
} else {
beammp_debugf("Invalid vehicle update packet received from '{}' ({}), ignoring it", LockedClient->GetName(), LockedClient->GetID());
}
return;
}
switch (Code) {
@@ -469,3 +472,37 @@ bool TServer::HandlePosition(TClient& c, const std::string& Packet) {
}
return false;
}
bool TServer::HandleVehicleUpdate(TClient& c, const std::string& Packet) {
if (Packet.size() < 3) {
// invalid packet
return false;
}
// (Vi/We/Yl):serverVehicleID:data
// (Vi/We/Yl):serverVehicleID:data
std::string withoutCode = Packet.substr(3);
auto NameDataSep = withoutCode.find(':', 2);
if (NameDataSep == std::string::npos || NameDataSep < 2) {
// invalid packet
return false;
}
// FIXME: ensure that -2 does what it should... it seems weird.
std::string ServerVehicleID = withoutCode.substr(2, NameDataSep - 2);
if (NameDataSep + 1 > withoutCode.size()) {
// invalid packet
return false;
}
std::string Data = withoutCode.substr(NameDataSep + 1);
// parse veh ID
auto MaybePidVid = GetPidVid(ServerVehicleID);
if (MaybePidVid) {
int PID = -1;
int VID = -1;
std::tie(PID, VID) = MaybePidVid.value();
if (PID == c.GetID()) {
return true;
}
}
return false;
}