fix vehicle copy on GetAllCars, TSetOfVehicleData is now vector<>

include/Client.h

@@ -14,10 +14,10 @@ class TServer;
 
 class TClient final {
 public:
-    using TSetOfVehicleData = std::unordered_set<TVehicleData>;
+    using TSetOfVehicleData = std::vector<TVehicleData>;
 
     struct TVehicleDataLockPair {
-        TSetOfVehicleData& VehicleData;
+        TSetOfVehicleData* VehicleData;
         std::unique_lock<std::mutex> Lock;
     };
 
@@ -31,6 +31,7 @@ public:
     void SetName(const std::string& Name) { mName = Name; }
     void SetRoles(const std::string& Role) { mRole = Role; }
     void AddIdentifier(const std::string& ID) { mIdentifiers.insert(ID); };
+    void EraseVehicle(TVehicleData& VehicleData);
     std::string GetCarData(int Ident);
     void SetUDPAddr(sockaddr_in Addr) { mUDPAddress = Addr; }
     void SetDownSock(SOCKET CSock) { mSocket[1] = CSock; }
@@ -67,6 +68,8 @@ public:
     int SecondsSinceLastPing();
 
 private:
+    void InsertVehicle(int ID, const std::string& Data);
+
     TServer& mServer;
     bool mIsConnected = false;
     bool mIsSynced = false;

include/VehicleData.h

@@ -6,20 +6,25 @@ class TVehicleData final {
 public:
     TVehicleData(int ID, std::string Data);
     ~TVehicleData();
+    // We cannot delete this, since vector needs to be able to copy when it resizes.
+    // Deleting this causes some wacky template errors which are hard to decipher,
+    // and end up making no sense, so let's just leave the copy ctor.
+    // TVehicleData(const TVehicleData&) = delete;
 
     [[nodiscard]] bool IsInvalid() const { return mID == -1; }
     [[nodiscard]] int ID() const { return mID; }
 
     [[nodiscard]] std::string Data() const { return mData; }
-    void SetData(const std::string& Data) const { mData = Data; }
+    void SetData(const std::string& Data) { mData = Data; }
 
     bool operator==(const TVehicleData& v) const { return mID == v.mID; }
 
 private:
     int mID { -1 };
-    mutable std::string mData;
+    std::string mData;
 };
 
+// TODO: unused now, remove?
 namespace std {
 template <>
 struct hash<TVehicleData> {