From 2a92a08587d9764360594eb1f456fc55183c357e Mon Sep 17 00:00:00 2001 From: galacticlemonade <90120199+galacticlemonade@users.noreply.github.com> Date: Wed, 8 Apr 2026 15:05:58 -0600 Subject: [PATCH 1/3] guard GameSend when game is not connected prevents WSAENOTSOCK --- src/Network/GlobalHandler.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Network/GlobalHandler.cpp b/src/Network/GlobalHandler.cpp index da4b6f2..755e406 100644 --- a/src/Network/GlobalHandler.cpp +++ b/src/Network/GlobalHandler.cpp @@ -62,6 +62,8 @@ bool CheckBytes(uint32_t Bytes) { } void GameSend(std::string_view Data) { + if (!GConnected) + return; static std::mutex Lock; std::scoped_lock Guard(Lock); auto ToSend = Utils::PrependHeader(Data); From 901b7df8098536cf8ce23a18371a0340fd0d5509 Mon Sep 17 00:00:00 2001 From: Tixx <83774803+WiserTixx@users.noreply.github.com> Date: Sun, 2 Aug 2026 13:06:33 +0200 Subject: [PATCH 2/3] Log debug message on GameSend connection check --- src/Network/GlobalHandler.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Network/GlobalHandler.cpp b/src/Network/GlobalHandler.cpp index 755e406..ec08ec3 100644 --- a/src/Network/GlobalHandler.cpp +++ b/src/Network/GlobalHandler.cpp @@ -62,8 +62,10 @@ bool CheckBytes(uint32_t Bytes) { } void GameSend(std::string_view Data) { - if (!GConnected) + if (!GConnected) { + debug("Tried to call GameSend but socket was not connected. Data: " + Data) return; + } static std::mutex Lock; std::scoped_lock Guard(Lock); auto ToSend = Utils::PrependHeader(Data); From 44211e7235eba4e248404149e8c43383307a46f4 Mon Sep 17 00:00:00 2001 From: Tixx <83774803+WiserTixx@users.noreply.github.com> Date: Sun, 2 Aug 2026 13:18:59 +0200 Subject: [PATCH 3/3] Fix incorrect string_view usage in log message and I somehow forgot the semicolon --- src/Network/GlobalHandler.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Network/GlobalHandler.cpp b/src/Network/GlobalHandler.cpp index ec08ec3..2e2c8c2 100644 --- a/src/Network/GlobalHandler.cpp +++ b/src/Network/GlobalHandler.cpp @@ -63,7 +63,7 @@ bool CheckBytes(uint32_t Bytes) { void GameSend(std::string_view Data) { if (!GConnected) { - debug("Tried to call GameSend but socket was not connected. Data: " + Data) + debug("Tried to call GameSend but socket was not connected. Data: " + std::string(Data)); return; } static std::mutex Lock;